Apart from the two comments, the patch set is fine.
With respect to the license text, maybe just copy the content of the
LICENSE file into the source file. Maybe STM fixes the Github issues and
provides SPDX License Identifiers in their next release.
--
embedded brains GmbH
Herr Sebastian HUB
On 16/05/2022 14:12, Karel Gardas wrote:
+
**
+ * @attention
+ *
+ * Copyright (c) 2019 STMicroelectronics.
+ * All rights reserved.
+ *
+ * This software is licensed under terms that can be found in the LICENSE f
On 19/05/2022 09:06, Karel Gardas wrote:
On 5/19/22 08:58, Sebastian Huber wrote:
On 16/05/2022 14:12, Karel Gardas wrote:
+ bld.install_as("${BSP_LIBDIR}/linkcmds.flash+sdram",
"linkcmds.flash+sdram")
I would not use '+' in file names.
Indeed, then there are two obvious choices:
- came
On 07/04/2022 21:15, Karel Gardas wrote:
REGION_WORK may be backed by external RAM which may not be initialized
in a time we need stack to work well. E.g. code loaded in flash,
stack allocated on in-cpu SRAM and data (REGION_WORK) on external SDRAM.
Sponsored-By: Precidata
This change could
On 16/05/2022 14:12, Karel Gardas wrote:
+ bld.install_as("${BSP_LIBDIR}/linkcmds.flash+sdram", "linkcmds.flash+sdram")
I would not use '+' in file names.
--
embedded brains GmbH
Herr Sebastian HUBER
Dornierstr. 4
82178 Puchheim
Germany
email: sebastian.hu...@embedded-brains.de
phone: +49-89-
On 19/05/2022 09:18, Karel Gardas wrote:
On 5/19/22 09:06, Sebastian Huber wrote:
On 19/05/2022 09:03, Karel Gardas wrote:
On 5/19/22 08:55, Sebastian Huber wrote:
On 16/05/2022 14:12, Karel Gardas wrote:
+
**
+ *
On 19/05/2022 08:59, Karel Gardas wrote:
On 5/19/22 08:53, Sebastian Huber wrote:
On 07/04/2022 21:15, Karel Gardas wrote:
REGION_WORK may be backed by external RAM which may not be initialized
in a time we need stack to work well. E.g. code loaded in flash,
stack allocated on in-cpu SRAM and d
On 19/05/2022 09:03, Karel Gardas wrote:
On 5/19/22 08:55, Sebastian Huber wrote:
On 16/05/2022 14:12, Karel Gardas wrote:
+
**
+ * @attention
+ *
+ * Copyright (c) 2019 STMicroelectronics.
+ * All rights reserve
