Re: [PATCH rtems-tools v2 2/7] TraceReader: Convert to C++

2021-09-23 Thread Chris Johns
On 24/9/21 7:26 am, Ryan Long wrote: > -bool ReadUntilFound( FILE *file, const char *line ) > +bool ReadUntilFound( std::ifstream& file, const char* line ) > { > - char discardBuff[100]; > - size_t len = strlen( line ); > + #define BUFFER_LENGTH There is no value? > + char discardBuff[BUF

Re: [PATCH rtems-tools v2 5/7] TraceWriterQEMU.cc: Fix formatting

2021-09-23 Thread Chris Johns
On 24/9/21 7:27 am, Ryan Long wrote: > --- > tester/covoar/TraceWriterQEMU.cc | 47 > +--- > 1 file changed, 29 insertions(+), 18 deletions(-) > > diff --git a/tester/covoar/TraceWriterQEMU.cc > b/tester/covoar/TraceWriterQEMU.cc > index d14260f..1f0e719 1

Re: [PATCH rtems-tools v2 4/7] TraceReaderLogQEMU.cc: Fix formatting

2021-09-23 Thread Chris Johns
On 24/9/21 7:26 am, Ryan Long wrote: > --- > tester/covoar/TraceReaderLogQEMU.cc | 21 +++-- > 1 file changed, 11 insertions(+), 10 deletions(-) > > diff --git a/tester/covoar/TraceReaderLogQEMU.cc > b/tester/covoar/TraceReaderLogQEMU.cc > index 7f72168..b1c52a9 100644 > --- a/te

[PATCH rtems-tools v2 3/7] TraceWriter: Convert to C++

2021-09-23 Thread Ryan Long
--- tester/covoar/TraceWriterBase.h | 3 ++- tester/covoar/TraceWriterQEMU.cc | 43 +--- tester/covoar/TraceWriterQEMU.h | 2 +- 3 files changed, 21 insertions(+), 27 deletions(-) diff --git a/tester/covoar/TraceWriterBase.h b/tester/covoar/TraceWriterBase.

[PATCH rtems-tools v2 7/7] TraceWriterQEMU.h: Fix formatting

2021-09-23 Thread Ryan Long
--- tester/covoar/TraceWriterQEMU.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tester/covoar/TraceWriterQEMU.h b/tester/covoar/TraceWriterQEMU.h index aa89860..7078837 100644 --- a/tester/covoar/TraceWriterQEMU.h +++ b/tester/covoar/TraceWriterQEMU.h @@ -44,9 +44,9 @

[PATCH rtems-tools v2 2/7] TraceReader: Convert to C++

2021-09-23 Thread Ryan Long
--- tester/covoar/ObjdumpProcessor.cc | 4 +- tester/covoar/ObjdumpProcessor.h| 2 +- tester/covoar/TargetBase.cc | 6 +- tester/covoar/TargetBase.h | 4 +- tester/covoar/TraceReaderBase.h | 4 +- tester/covoar/TraceReaderLogQEMU.cc | 123 --

[PATCH rtems-tools v2 1/7] CoverageRanges.cc: Fix formatting

2021-09-23 Thread Ryan Long
--- tester/covoar/CoverageRanges.cc | 13 + tester/covoar/CoverageRanges.h | 13 +++-- 2 files changed, 12 insertions(+), 14 deletions(-) diff --git a/tester/covoar/CoverageRanges.cc b/tester/covoar/CoverageRanges.cc index 159c556..cfd58df 100644 --- a/tester/covoar/CoverageR

[PATCH rtems-tools v2 6/7] TraceReaderLogQEMU.h: Fix formatting

2021-09-23 Thread Ryan Long
--- tester/covoar/TraceReaderLogQEMU.h | 1 - 1 file changed, 1 deletion(-) diff --git a/tester/covoar/TraceReaderLogQEMU.h b/tester/covoar/TraceReaderLogQEMU.h index 59b5d23..636df3a 100644 --- a/tester/covoar/TraceReaderLogQEMU.h +++ b/tester/covoar/TraceReaderLogQEMU.h @@ -22,7 +22,6 @@ names

[PATCH rtems-tools v2 5/7] TraceWriterQEMU.cc: Fix formatting

2021-09-23 Thread Ryan Long
--- tester/covoar/TraceWriterQEMU.cc | 47 +--- 1 file changed, 29 insertions(+), 18 deletions(-) diff --git a/tester/covoar/TraceWriterQEMU.cc b/tester/covoar/TraceWriterQEMU.cc index d14260f..1f0e719 100644 --- a/tester/covoar/TraceWriterQEMU.cc +++ b/tester/

[PATCH rtems-tools v2 4/7] TraceReaderLogQEMU.cc: Fix formatting

2021-09-23 Thread Ryan Long
--- tester/covoar/TraceReaderLogQEMU.cc | 21 +++-- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/tester/covoar/TraceReaderLogQEMU.cc b/tester/covoar/TraceReaderLogQEMU.cc index 7f72168..b1c52a9 100644 --- a/tester/covoar/TraceReaderLogQEMU.cc +++ b/tester/covoar

[PATCH rtems-tools v2 0/7] Convert and reformat pt. 3

2021-09-23 Thread Ryan Long
Hi, For this series of patches, I - initialized an uninitialized array - added check for length of "line" parameter - simplified a conditional Thanks, Ryan Ryan Long (7): CoverageRanges.cc: Fix formatting TraceReader: Convert to C++ TraceWriter: Convert to C++ TraceReaderLogQEMU.cc: Fix

[PATCH] cpukit/aarch64: Use correct context register sets

2021-09-23 Thread Kinsey Moore
Context validation for AArch64 was ported from the ARM implementation without a reinterpretation of the actual requirements. The spcontext01 test just happened to pass because the set of scratch registers in ARM is a subset of the scratch registers in AArch64. --- .../cpu/aarch64/aarch64-context-v

RE: [PATCH rtems-tools v1 4/7] TraceReaderLogQEMU.cc: Fix formatting

2021-09-23 Thread Ryan Long
Both of those definitions of discardBuff do the same thing. The form of value initializing in the example I showed was introduced in C++11. It was put in to zero out templated objects evidently. I just saw it on stackoverflow. :) -Original Message- From: Chris Johns Sent: Wednesday, Se

Re: [PATCH rtems-libbsd] rtemsbsd/syscalls: Remove pipe()

2021-09-23 Thread Chris Johns
On 23/9/21 7:02 pm, Sebastian Huber wrote: > On 23/09/2021 10:44, Chris Johns wrote: >> On 23/9/21 4:29 pm, Sebastian Huber wrote: >>> On 23/09/2021 07:43,chr...@rtems.org  wrote: From: Chris Johns - This call is provided by RTEMS and that is preferred Closes #4518 >>> This

Re: [PATCH rtems-libbsd] rtemsbsd/syscalls: Remove pipe()

2021-09-23 Thread Sebastian Huber
On 23/09/2021 10:44, Chris Johns wrote: On 23/9/21 4:29 pm, Sebastian Huber wrote: On 23/09/2021 07:43,chr...@rtems.org wrote: From: Chris Johns - This call is provided by RTEMS and that is preferred Closes #4518 This removes the kqueue() support for pipe(). It does but it also lets the RT

Re: [PATCH rtems-libbsd] rtemsbsd/syscalls: Remove pipe()

2021-09-23 Thread Chris Johns
On 23/9/21 4:29 pm, Sebastian Huber wrote: > On 23/09/2021 07:43, chr...@rtems.org wrote: >> From: Chris Johns >> >> - This call is provided by RTEMS and that is preferred >> >> Closes #4518 > > This removes the kqueue() support for pipe(). It does but it also lets the RTEMS one get linked in and