Re: [PATCH 6/7] score: Always validate ticks in _TOD_Validate()

On 4/9/21 2:20 pm, Joel Sherrill wrote: On Fri, Sep 3, 2021, 11:01 PM Chris Johns > wrote: > > On 3/9/21 11:33 pm, Sebastian Huber wrote: > > The behaviour with respect to the handling of the ticks member in the > *_when() > > directives was inconsistent.  I

Re: [PATCH 6/7] score: Always validate ticks in _TOD_Validate()

On Fri, Sep 3, 2021, 11:10 PM Chris Johns wrote: > On 3/9/21 11:33 pm, Sebastian Huber wrote: > > diff --git a/bsps/arm/altera-cyclone-v/rtc/rtc.c > b/bsps/arm/altera-cyclone-v/rtc/rtc.c > > index 779a093459..d1c12ee874 100644 > > --- a/bsps/arm/altera-cyclone-v/rtc/rtc.c > > +++ b/bsps/arm/alter

Re: [PATCH 6/7] score: Always validate ticks in _TOD_Validate()

On Fri, Sep 3, 2021, 11:01 PM Chris Johns wrote: > On 3/9/21 11:33 pm, Sebastian Huber wrote: > > The behaviour with respect to the handling of the ticks member in the > *_when() > > directives was inconsistent. In all *_when() directives the ticks > member is > > not used to calculate the watch

Re: [PATCH 6/7] score: Always validate ticks in _TOD_Validate()

On 3/9/21 11:33 pm, Sebastian Huber wrote: > diff --git a/bsps/arm/altera-cyclone-v/rtc/rtc.c > b/bsps/arm/altera-cyclone-v/rtc/rtc.c > index 779a093459..d1c12ee874 100644 > --- a/bsps/arm/altera-cyclone-v/rtc/rtc.c > +++ b/bsps/arm/altera-cyclone-v/rtc/rtc.c > @@ -353,7 +353,7 @@ static int alter

Re: [PATCH 6/7] score: Always validate ticks in _TOD_Validate()

On 3/9/21 11:33 pm, Sebastian Huber wrote: > The behaviour with respect to the handling of the ticks member in the *_when() > directives was inconsistent. In all *_when() directives the ticks member is > not used to calculate the watchdog expiration time. However, the > rtems_task_wake_when() dir

Does the arm/xilinx-zynqmp BSP work?

Hi, I am testing the console driver with the aarch64/xilinx_zynqmp_lp64_zu3eg BSP when I saw the BSP. Is this BSP still valid? Does this BSP work on real hardware? Who is looking after this BSP? Chris ___ devel mailing list devel@rtems.org http://lis

Re: [PATCH RSB] rtems-gcc-10-newlib-head.cfg: Add newlib patch

Can we please join onto this an rtems-tools update so the recent fixes I pushed can be picked up? Thanks Chris On 4/9/21 2:40 am, Joel Sherrill wrote: > You also should add the patch in the gcc-head-newlib-head > configuration as well for rtems7 tools. > > --joel > > On Fri, Sep 3, 2021 at 11:0

Re: [PATCH v1 00/10] Convert and reformat rtems-tools pt. 1

On 3/9/21 10:07 pm, Ryan Long wrote: > I haven't been building these with clang, so I'll make sure to start doing > that. I've got a Macbook, so I can test it on there as well. This great and thanks. I am amazed how each compiler and version of that compiler generates new issues. On the positive

Re: Ticket #4203 clarification

Say i find an exception (ex format string printing a decimal.) How do I test that my improvement works? Thanks Zack On Fri, 3 Sept 2021 at 01:36, Joel Sherrill wrote: > On Thu, Sep 2, 2021 at 8:01 PM zack leung > wrote: > > > > Hello! > > > > I'd like to begin working on 4203. It involves impr

[PATCH RSB v2 2/2] rtems-gcc-head-newlib-head.cfg: Add newlib patch

Adds patch to add the -DPREFER_SIZE_OVER_SPEED flag to AArch64 tools builds with newlib. This forces the generation of AArch64 assembly from C sources instead of using the hand-optimized code in newlib since it does not support ILP32. This can be removed when it is fixed upstream. Updates #4510 --

[PATCH RSB v2 1/2] rtems-gcc-10-newlib-head.cfg: Add newlib patch

Adds patch to add the -DPREFER_SIZE_OVER_SPEED flag to AArch64 tool builds with newlib. This forces the generation of AArch64 assembly from C sources instead of using the hand-optimized code in newlib since it does not support ILP32. This can be removed when it is fixed upstream. Updates #4510 ---

Re: [PATCH RSB] rtems-gcc-10-newlib-head.cfg: Add newlib patch

You also should add the patch in the gcc-head-newlib-head configuration as well for rtems7 tools. --joel On Fri, Sep 3, 2021 at 11:01 AM Joel Sherrill wrote: > > On Fri, Sep 3, 2021 at 9:27 AM Ryan Long wrote: > > > > Adds patch to add the -DPREFER_SIZE_OVER_SPEED flag to aarch64 tool > > build

Re: [PATCH RSB] rtems-gcc-10-newlib-head.cfg: Add newlib patch

On Fri, Sep 3, 2021 at 9:27 AM Ryan Long wrote: > > Adds patch to add the -DPREFER_SIZE_OVER_SPEED flag to aarch64 tool > builds with newlib. This doesn't explain why. This patch is needed to prevent the use of the assembly versions of some methods in newlib which are incorrect for ilp32. This ca

[PATCH] score: Move _Thread_Dispatch()

The _Thread_Dispatch() function was customized over time and now the work is done by _Thread_Do_dispatch() and specialized wrappers. The plain _Thread_Dispatch() is now only used in some CPU ports. Move it to a separate file to avoid dead code in the general. Change license to BSD-2-Clause accor

[PATCH] score: Split up rbtreenext.c

Split up rbtreenext.c since only _RBTree_Minimum() is used by the operating system core services (thread queues and the EDF scheduler). Change license to BSD-2-Clause according to file history and re-licensing agreement. Update #3053. --- cpukit/Makefile.am| 3 ++ cpukit/score/s

[PATCH RSB] rtems-gcc-10-newlib-head.cfg: Add newlib patch

Adds patch to add the -DPREFER_SIZE_OVER_SPEED flag to aarch64 tool builds with newlib. --- rtems/config/tools/rtems-gcc-10-newlib-head.cfg | 3 +++ 1 file changed, 3 insertions(+) diff --git a/rtems/config/tools/rtems-gcc-10-newlib-head.cfg b/rtems/config/tools/rtems-gcc-10-newlib-head.cfg inde

[PATCH] c-user: Document time of day constraints

Close #4338. --- c-user/clock/directives.rst | 19 +++ 1 file changed, 15 insertions(+), 4 deletions(-) diff --git a/c-user/clock/directives.rst b/c-user/clock/directives.rst index e0f858a..50272ba 100644 --- a/c-user/clock/directives.rst +++ b/c-user/clock/directives.rst @@ -70,1

[PATCH 7/7] score: Change TOD_LATEST_YEAR to 2099

This simplifies the implementation a bit. Declare _TOD_Days_to_date[] in . Make _TOD_Days_per_month[] and _TOD_Days_since_last_leap_year[] static. Update #4338. --- bsps/bfin/shared/dev/rtc.c | 9 ++ cpukit/include/rtems/score/todimpl.h| 31 -- cpukit/rtems

[PATCH 3/7] score: Add _TOD_Is_valid_new_time_of_day()

Move the TOD validation to the callers of _TOD_Set(). This avoids dead code in case only rtems_clock_set() is used in an application because rtems_clock_set() always calls _TOD_Set() with a valid time of day. --- cpukit/Makefile.am | 1 + cpukit/include/rtems/score/todimpl.h |

[PATCH 2/7] score: Remove TOD_TICKS_PER_SECOND_method()

Use _Watchdog_Ticks_per_second instead. --- cpukit/Makefile.am| 1 - cpukit/include/rtems/score/todimpl.h | 20 ++ cpukit/score/src/coretodtickspersec.c | 30 --- spec/build/cpukit/librtemscpu.yml | 1 - 4 files changed, 2 insertio

[PATCH 5/7] score: Simplify _TOD_Validate()

Split up the multi line if statement into smaller parts. --- cpukit/rtems/src/clocktodvalidate.c | 34 + 1 file changed, 25 insertions(+), 9 deletions(-) diff --git a/cpukit/rtems/src/clocktodvalidate.c b/cpukit/rtems/src/clocktodvalidate.c index 14b3f79d8e..0e3b5772b

[PATCH 0/7] Clean up some CLOCK_REALTIME related issues

See also: https://lists.rtems.org/pipermail/devel/2021-May/067247.html https://devel.rtems.org/ticket/4338 Sebastian Huber (7): score: Return status in _TOD_Adjust() score: Remove TOD_TICKS_PER_SECOND_method() score: Add _TOD_Is_valid_new_time_of_day() score: Limit the CLOCK_REALTIME set

[PATCH 1/7] score: Return status in _TOD_Adjust()

--- cpukit/include/rtems/score/todimpl.h | 5 - cpukit/posix/src/adjtime.c | 6 +- cpukit/score/src/coretodadjust.c | 7 +-- 3 files changed, 14 insertions(+), 4 deletions(-) diff --git a/cpukit/include/rtems/score/todimpl.h b/cpukit/include/rtems/score/todimpl.h index

[PATCH 6/7] score: Always validate ticks in _TOD_Validate()

The behaviour with respect to the handling of the ticks member in the *_when() directives was inconsistent. In all *_when() directives the ticks member is not used to calculate the watchdog expiration time. However, the rtems_task_wake_when() directive ignores the ticks member of the time of day

[PATCH 4/7] score: Limit the CLOCK_REALTIME setting

Limit the CLOCK_REALTIME setting to ensure that the CLOCK_REALTIME is defined for a system uptime of at least 114 years. --- cpukit/include/rtems/score/todimpl.h | 9 + cpukit/score/src/coretodcheck.c | 2 +- testsuites/psxtests/psxclock/init.c | 15 +++ 3 files changed

RE: [PATCH v1 00/10] Convert and reformat rtems-tools pt. 1

I haven't been building these with clang, so I'll make sure to start doing that. I've got a Macbook, so I can test it on there as well. -Original Message- From: Chris Johns Sent: Thursday, September 2, 2021 11:59 PM To: Ryan Long ; devel@rtems.org Subject: Re: [PATCH v1 00/10] Convert a