On 12/8/21 9:42 pm, Christian Mauderer wrote:
> The pppstart expected that a driver write would somehow magically
> process all data passed to the write function. Because ppp disables all
> buffering that originally has been in termios, that assumption is not
> true for all but polled drivers.
>
>
+1
On 13/8/21 3:43 am, Gedare Bloom wrote:
> looks good to me.
>
> On Thu, Aug 12, 2021 at 8:26 AM Sebastian Huber
> wrote:
>>
>> Use the new Priority_Group_order enum instead of a boolean to indicated if a
>> priority should be inserted as the first or last node into its priority
>> group.
>>
Adjusted number of bytes to be read
CID 1506208: Out-of-bounds access
CID 1506209: Out-of-bounds access
Closes #4485
---
tester/covoar/GcovData.cc | 13 ++---
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/tester/covoar/GcovData.cc b/tester/covoar/GcovData.cc
index 02e7489
Oh now I see what you mean. Preamble is of gcov_preamble type. I'll change
sizeof( gcov_preamble ) to sizeof( preamble ) to make that easier to follow.
-Original Message-
From: Gedare Bloom
Sent: Thursday, August 12, 2021 12:39 PM
To: Ryan Long
Cc: devel@rtems.org
Subject: Re: [PATCH]
This is fine, but should do some testing on a few BSPs if you can.
On Thu, Aug 12, 2021 at 5:42 AM Christian Mauderer
wrote:
>
> At the moment the line discipline start function (l_start) has no
> possibility to get feedback about the number of characters that have
> been sent. This patch passes
looks ok, but hold until chris pushes his big patches through I think.
(Not that it should conflict, but I think it will be better this way.)
On Thu, Aug 12, 2021 at 5:42 AM Christian Mauderer
wrote:
>
> The pppstart expected that a driver write would somehow magically
> process all data passed t
looks good to me.
On Thu, Aug 12, 2021 at 8:26 AM Sebastian Huber
wrote:
>
> Use the new Priority_Group_order enum instead of a boolean to indicated if a
> priority should be inserted as the first or last node into its priority group.
> This makes the code more expressive. It is also a bit more
On Thu, Aug 12, 2021 at 7:54 AM Ryan Long wrote:
>
> Would you need to check if length < sizeof(gcov_preamble) since length is
> assigned that value?
>
No, but my question is about 'preamble'. If there's a difference
between 'preamble' and 'gcov_preamble', then that should be checked.
If they sho
ok
On Thu, Aug 12, 2021 at 3:11 AM Sebastian Huber
wrote:
>
> The NULL pointer check for the executing thread was introduced by
> commit:
>
> commit be3c257286ad870d8d1a64941cde53fd2d33a633
> Author: Sebastian Huber
> Date: Thu Jun 5 11:17:26 2014 +0200
>
> score: Avoid NULL pointer access
> On 2021-August-12, at 03:36, Sebastian Huber
> wrote:
>
> On 11/08/2021 18:22, Mr. Andrei Chichak wrote:
>> On 2021-August-11, at 01:06, Sebastian
>> Huber wrote:
>>> On 10/08/2021 23:48, Mr. Andrei Chichak wrote:
From what I can figure out, there seems to be a problem with the
Hello,
We noticed a bit strange behavior while doing some measurements with the riscv
bsps running on SIS.
If we run "T_get_one_clock_tick_busy" to get a base reference for busy cycles,
the values between cpu0 and other secondary cores differ by a constant value.
For example for a 200us tick tim
Use the new Priority_Group_order enum instead of a boolean to indicated if a
priority should be inserted as the first or last node into its priority group.
This makes the code more expressive. It is also a bit more efficient since a
branch in _Scheduler_Node_set_priority() is avoided and a simple
Replaced header.magic with QEMU_TRACE_MAGIC to get rid of "String not
null terminated" Coverity issue.
CID 1506203: String not null terminated
Closes #4486
---
tester/covoar/TraceWriterQEMU.cc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tester/covoar/TraceWriterQEMU.cc b/
Would you need to check if length < sizeof(gcov_preamble) since length is
assigned that value?
-Original Message-
From: Gedare Bloom
Sent: Wednesday, August 11, 2021 11:13 AM
To: Ryan Long
Cc: devel@rtems.org
Subject: Re: [PATCH] GcovData.cc: Fix out-of-bounds access errors
On Wed, A
The pppstart expected that a driver write would somehow magically
process all data passed to the write function. Because ppp disables all
buffering that originally has been in termios, that assumption is not
true for all but polled drivers.
With this patch, the pppstart now gets and processes the
Put the next character into the send buffer if the buffer is empty and
not when the last character has been sent out to the line. This improves
the performance slightly.
Before that patch, the receive path was faster than the transmit path.
Therefore a simple echo could drop characters on a busy c
At the moment the line discipline start function (l_start) has no
possibility to get feedback about the number of characters that have
been sent. This patch passes that information via an additional
parameter.
The change might trigger a warning on existing code because of a pointer
mismatch but it
Hello,
this set of patches fixes PPP. Basically the current implementation in
libbsd can't work with console drivers that can't buffer a lot of
characters. The pppstart() function just assumes that the low level
console write can send an arbitrary number of characters without
checking how many cha
On 11/08/2021 18:22, Mr. Andrei Chichak wrote:
On 2021-August-11, at 01:06, Sebastian
Huber wrote:
On 10/08/2021 23:48, Mr. Andrei Chichak wrote:
From what I can figure out, there seems to be a problem with the
out-of-the-box build of newly that the STM32F4 uses.
memset() goes for a few ARM
The NULL pointer check for the executing thread was introduced by
commit:
commit be3c257286ad870d8d1a64941cde53fd2d33a633
Author: Sebastian Huber
Date: Thu Jun 5 11:17:26 2014 +0200
score: Avoid NULL pointer access
Check that the executing thread is not NULL in _Scheduler_Tick(). It
20 matches
Mail list logo
