Re: [PATCH rtems-libbsd 0/5] RTEMS LibBSD Documentation

Hello Husni, thanks for the patches. I'm sure that this will start a discussion about the right place for that documentation. libbsd documentation is a long overdue topic that has been neglected by all of us (including myself) so I think it's good to start that discussion. Best regards Chri

Re: [PATCH rtems-libbsd v2 0/5] Beagle BSP: USB Template Driver for CDC Ethernet

Hello Husni, Am 01.08.21 um 19:59 schrieb Ahamed Husni: Hi Christian, On Sun, Aug 1, 2021 at 4:57 PM Christian Mauderer > wrote: Hello Husni, just tested that and it works fine. With a simple curl I can reach about 8.5 MByte/s sending to the beagle

Re: [PATCH v1 09/13] Remove SymbolsToAnalyze global variable

On 2/8/21 1:20 pm, Joel Sherrill wrote: > > > On Sun, Aug 1, 2021, 10:11 PM Chris Johns > wrote: > > On 2/8/21 9:23 am, Ryan Long wrote: > > - Removed SymbolsToAnalyze from app_common and replaced it with the > >   symbolsToAnalyze_m member variable in Des

Re: [PATCH v1 11/13] Remove TargetInfo global variable

On 2/8/21 9:23 am, Ryan Long wrote: > - Remove TargetInfo from app_common > - Created the targetInfo_m member variable in CoverageReaderBase, > TraceWriterBase, and ObjdumpProcessor > - Made functions to set the value of targetInfo_m > --- > tester/covoar/CoverageReaderBase.cc | 5 + > tes

Re: [PATCH v1 09/13] Remove SymbolsToAnalyze global variable

On Sun, Aug 1, 2021, 10:11 PM Chris Johns wrote: > On 2/8/21 9:23 am, Ryan Long wrote: > > - Removed SymbolsToAnalyze from app_common and replaced it with the > > symbolsToAnalyze_m member variable in DesiredSymbols, GcovData, and > > ObjdumpProcessor > > - Added a parameter to constructors t

Re: [PATCH v1 09/13] Remove SymbolsToAnalyze global variable

On 2/8/21 9:23 am, Ryan Long wrote: > - Removed SymbolsToAnalyze from app_common and replaced it with the > symbolsToAnalyze_m member variable in DesiredSymbols, GcovData, and > ObjdumpProcessor > - Added a parameter to constructors to initialize symbolsToAnalyze_m > - Moved the definition of o

[PATCH v1 13/13] Remove app_common and all references to it

- Removed the includes of app_common.h - Removed app_common references in build infrastructure - Removed app_common.cc and app_common.h --- tester/covoar/CoverageReaderQEMU.cc | 1 - tester/covoar/CoverageReaderTSIM.cc | 1 - tester/covoar/DesiredSymbols.cc | 1 - tester/covoar/ExecutableIn

[PATCH v1 12/13] app_common: Remove functions and macros

- Moved functions from app_common to the file they are used - Got rid of FileIsNewer() since it's not being used - Removed macros --- tester/covoar/TraceReaderLogQEMU.cc | 14 + tester/covoar/app_common.cc | 58 - tester/covoar/app_common.h

[PATCH v1 11/13] Remove TargetInfo global variable

- Remove TargetInfo from app_common - Created the targetInfo_m member variable in CoverageReaderBase, TraceWriterBase, and ObjdumpProcessor - Made functions to set the value of targetInfo_m --- tester/covoar/CoverageReaderBase.cc | 5 + tester/covoar/CoverageReaderBase.h | 12

[PATCH v1 10/13] Remove BranchInfoAvailable global variable

- Removed BranchInfoAvailable from app_common - Created member variable in CoverageReaderBase and ReportsBase and a function to get the value of the member variable --- tester/covoar/CoverageReaderBase.cc | 5 + tester/covoar/CoverageReaderBase.h | 10 ++ tester/covoar/CoverageRead

[PATCH v1 09/13] Remove SymbolsToAnalyze global variable

- Removed SymbolsToAnalyze from app_common and replaced it with the symbolsToAnalyze_m member variable in DesiredSymbols, GcovData, and ObjdumpProcessor - Added a parameter to constructors to initialize symbolsToAnalyze_m - Moved the definition of objdumpLine_t out of ObjdumpProcessor to make

[PATCH v1 08/13] Remove input buffer global variables

- Removed input buffers from app_common and added them as a local variable to functions where inputBuffer was being used - Added #define for MAX_LINE_LENGTH in files where it is used - Changed Explanations::load to use a string instead of a C-string --- tester/covoar/Explanations.cc | 20

[PATCH v1 07/13] Remove outputDirectory global variable

- Replaced outputDirectory in app_common with a local variable in covoar() - Created the outputDirectory_m member variable - Added parameters to Reports* constructors to initialize outputDirectory_m and non member functions --- tester/covoar/ReportsBase.cc | 41 ++--

[PATCH v1 06/13] Remove projectName global variable

- Replaced projectName in app_common with a local variable in covoar() - Changed datatype to string - Changed conditionals to reflect this - Created projectName_m member variable for ReportsBase - Added parameter to Reports* constructors to initialize projectName_m --- tester/covoar/ReportsBase.

[PATCH v1 05/13] Remove dynamicLibrary global variable

- Replaced dynamicLibrary in app_common with local variables - Changed data type to string - Changed conditionals to reflect this --- tester/covoar/ExecutableInfo.cc | 10 +- tester/covoar/ExecutableInfo.h | 6 +++--- tester/covoar/TraceConverter.cc | 5 +++-- tester/covoar/app_common

[PATCH v1 04/13] Remove Verbose global variable

Replaced Verbose in app_common with local variables that are passed as a parameter into numerous functions --- tester/covoar/DesiredSymbols.cc | 17 tester/covoar/DesiredSymbols.h| 13 +--- tester/covoar/ExecutableInfo.h| 1 + tester/covoar/ObjdumpProcessor.cc |

[PATCH v1 03/13] Remove objdumpProcessor global variable

- Replaced objdumpProcessor in app_common with a local variable in TraceConverter.cc and covoar.cc - Added objdumpProcessor as a parameter for GenerateReports() and the processFile() member function of TraceReaderBase and its derived classes - Changed previous objdumpProcessor member function

[PATCH v1 00/13] Remove the global variables in app_common

Hi, This is a tedious series of patches. To remove the global variables, the process was generally: 1. Remove the global variable, reokace it with a variable in main() 2. Pass it to a constructor for the objects that were using the global variable and initialize a newly created member variable

[PATCH v1 02/13] ReportsHtml.cc: Initialize lastState_m

When not initialized, an extra code segment would be added to annotated.html --- tester/covoar/ReportsHtml.cc | 1 + 1 file changed, 1 insertion(+) diff --git a/tester/covoar/ReportsHtml.cc b/tester/covoar/ReportsHtml.cc index 88ea25b..4c024d5 100644 --- a/tester/covoar/ReportsHtml.cc +++ b/teste

Re: [PATCH rtems-libbsd 0/5] RTEMS LibBSD Documentation

Github repo https://github.com/drac98/rtems-docs/commits/libbsd On Mon, Aug 2, 2021 at 12:56 AM Husni Faiz wrote: > The RTEMS LibBSD doesn't have a documentation in the RTEMS Documentation > Project. > As I'm currently porting USB device drivers to LibBSD I decided to > document the drivers I po

Re: [PATCH rtems-libbsd v2 4/5] libbsd.py: add usb template files

I don't get notified of the replies to my patch. Not sure why. Replies don't go to spam either. That's why my replies are late. I added the rtems.org to the whitelist. I hope next time I'll get notified ;) On Thu, Jul 29, 2021 at 5:38 AM Chris Johns wrote: > On 28/7/21 9:56 pm, Husni Faiz wrote:

[PATCH rtems-libbsd 5/5] libbsd: USB Template Driver Documentation

Signed-off-by: Husni Faiz --- libbsd/device_driver.rst | 30 ++ libbsd/index.rst | 1 + 2 files changed, 31 insertions(+) create mode 100644 libbsd/device_driver.rst diff --git a/libbsd/device_driver.rst b/libbsd/device_driver.rst new file mode 100644 index

[PATCH rtems-libbsd 4/5] wscript: Enable build for LibBSD Doc

Signed-off-by: Husni Faiz --- wscript | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/wscript b/wscript index fd8f10c..5ae735d 100644 --- a/wscript +++ b/wscript @@ -35,7 +35,8 @@ build_all = ['user', 'shell', 'cpu-supplement', 'deve

[PATCH rtems-libbsd 3/5] libbsd: Add conf.py and wscript for the libbsd doc.

Signed-off-by: Husni Faiz --- libbsd/conf.py | 14 ++ libbsd/wscript | 7 +++ 2 files changed, 21 insertions(+) create mode 100644 libbsd/conf.py create mode 100644 libbsd/wscript diff --git a/libbsd/conf.py b/libbsd/conf.py new file mode 100644 index 000..3f76889 --- /dev

[PATCH rtems-libbsd 2/5] libbsd: Index for LibBSD Doc

Add the index file and an empty page for introduction. Signed-off-by: Husni Faiz --- libbsd/index.rst| 23 +++ libbsd/introduction.rst | 8 2 files changed, 31 insertions(+) create mode 100644 libbsd/index.rst create mode 100644 libbsd/introduction.rst di

[PATCH rtems-libbsd 1/5] libbsd: Quick Start Guide for RTEMS LibBSD

This guide has instructions to build the RTESM LibBSD manually for Beagle BSP. Signed-off-by: Husni Faiz --- libbsd/quick_start.rst | 51 ++ 1 file changed, 51 insertions(+) create mode 100644 libbsd/quick_start.rst diff --git a/libbsd/quick_start.rst b/

[PATCH rtems-libbsd 0/5] RTEMS LibBSD Documentation

The RTEMS LibBSD doesn't have a documentation in the RTEMS Documentation Project. As I'm currently porting USB device drivers to LibBSD I decided to document the drivers I port in the rtems-docs. In this patch set I have added a quick-start guide and the USB template driver documentation. Husni

Re: [PATCH rtems-libbsd v2 5/5] create-kernel-namespace for USB Template driver

Hello Chris, On Thu, Jul 29, 2021 at 5:41 AM Chris Johns wrote: > On 28/7/21 9:56 pm, Husni Faiz wrote: > > Signed-off-by: Husni Faiz > > --- > > rtemsbsd/include/machine/rtems-bsd-kernel-namespace.h | 5 + > > 1 file changed, 5 insertions(+) > > > > diff --git a/rtemsbsd/include/machine/r

Re: [PATCH rtems-libbsd v2 0/5] Beagle BSP: USB Template Driver for CDC Ethernet

Hi Christian, On Sun, Aug 1, 2021 at 4:57 PM Christian Mauderer wrote: > Hello Husni, > > just tested that and it works fine. With a simple curl I can reach about > 8.5 MByte/s sending to the beagle and 19.5 MByte/s receiving from it. > > That's 68 Mbps for sending. That's an acceptable speed is

Re: [PATCH rtems-libbsd v2 2/5] usb_template: Configure template driver only for CDC Ethernet

Hello Chris, Sorry for the late reply. On Thu, Jul 29, 2021 at 5:37 AM Chris Johns wrote: > On 29/7/21 1:10 am, Ahamed Husni wrote: > > > > > > On Wed, 28 Jul 2021, 17:27 Husni Faiz, > > wrote: > > > > Add the conditional macro to prevent the driver from ref

Re: [PATCH rtems-libbsd v2 0/5] Beagle BSP: USB Template Driver for CDC Ethernet

Hello Husni, just tested that and it works fine. With a simple curl I can reach about 8.5 MByte/s sending to the beagle and 19.5 MByte/s receiving from it. Please take a look at the points that Chris Johns asked. As soon as these are addressed, I think the patches could be merged. Please al