Re: [PATCH v1 4/4] rtl-allocator.c: Put dereferences after nullcheck

Ok On 29/5/21 7:11 am, Ryan Long wrote: > CID 1444139: Dereference null return value in rtems_rtl_alloc_hook(). > > Closes #4333 > --- > cpukit/libdl/rtl-allocator.c | 7 +-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/cpukit/libdl/rtl-allocator.c b/cpukit/libdl/rtl-a

Re: [PATCH v1 1/6] Explanations.cc: Fix resource leaks

On 29/5/21 8:08 am, Ryan Long wrote: > CID 1399608: Resource leak in load(). > CID 1399611: Resource leak in load(). > > Closes #4417 > --- > tester/covoar/Explanations.cc | 18 +++--- > 1 file changed, 11 insertions(+), 7 deletions(-) > > diff --git a/tester/covoar/Explanations.cc b

Re: [PATCH v2] cpukit/libmisc/monitor: Fix src/dest overlap of strcpy in mon-editor.c

On Fri, May 28, 2021 at 1:08 PM Joel Sherrill wrote: > > This looks OK. Pushed. Thanks. > > On Thu, May 27, 2021 at 7:32 PM Harrison Edward Gerber > wrote: >> >> From: Harrison Edward Gerber >> >> See also CID 1399727 >> >> Closes # >> --- >> cpukit/libmisc/monitor/mon-editor.c | 12 +

Re: [PATCH v1 0/4] Acked patches

Unless there is an objection over the weekend, I will push these Monday. Then we can begin to wade through the ones with commentary that have lingered. Probably one at a time now. --joel On Fri, May 28, 2021 at 2:11 PM Ryan Long wrote: > Hi, > > These patches are from various patch sets to fix

[PATCH v1 6/6] ReportsBase.cc: Fix Resource leak

CID 1503711: Resource leak in WriteSummaryReport(). Closes #4422 --- tester/covoar/ReportsBase.cc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tester/covoar/ReportsBase.cc b/tester/covoar/ReportsBase.cc index d904f8d..b4a755c 100644 --- a/tester/covoar/ReportsBase.cc +++ b/tester/covoar/

[PATCH v1 5/6] DesiredSymbols.cc: Fix resource leak

CID 1503018: Resource leak in load(). Closes #4421 --- tester/covoar/DesiredSymbols.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tester/covoar/DesiredSymbols.cc b/tester/covoar/DesiredSymbols.cc index 2866dbe..5278891 100644 --- a/tester/covoar/DesiredSymbols.cc +++

[PATCH v1 2/6] TraceReaderLogQEMU.cc: Fix resource leak

CID 1399615: Resource leak in processFile(). Closes #4419 --- tester/covoar/TraceReaderLogQEMU.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tester/covoar/TraceReaderLogQEMU.cc b/tester/covoar/TraceReaderLogQEMU.cc index 508074a..b64a149 100644 --- a/tester/covoar/Trac

[PATCH v1 3/6] GcovData.cc: Fix resource leak

CID 1399610: Resource leak in readFrame(). Closes #4418 --- tester/covoar/GcovData.cc | 40 ++-- tester/covoar/GcovData.h | 4 ++-- 2 files changed, 24 insertions(+), 20 deletions(-) diff --git a/tester/covoar/GcovData.cc b/tester/covoar/GcovData.cc index 51

[PATCH v1 4/6] TraceWriterQEMU.cc: Fix resource leak

CID 1399621: Resource leak in writeFile(). Closes #4420 --- tester/covoar/TraceWriterQEMU.cc | 1 + 1 file changed, 1 insertion(+) diff --git a/tester/covoar/TraceWriterQEMU.cc b/tester/covoar/TraceWriterQEMU.cc index 4bc9667..26447af 100644 --- a/tester/covoar/TraceWriterQEMU.cc +++ b/tester/co

[PATCH v1 0/6] rtems-tools resource leak patches

Hi, In these patches, I added missing fclose()'s and converted some pointers to be of the data type that they were pointing to. Thanks, Ryan Ryan Long (6): Explanations.cc: Fix resource leaks TraceReaderLogQEMU.cc: Fix resource leak GcovData.cc: Fix resource leak TraceWriterQEMU.cc: Fix

[PATCH v1 1/6] Explanations.cc: Fix resource leaks

CID 1399608: Resource leak in load(). CID 1399611: Resource leak in load(). Closes #4417 --- tester/covoar/Explanations.cc | 18 +++--- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/tester/covoar/Explanations.cc b/tester/covoar/Explanations.cc index 12bd809..d94cd2e 1

[PATCH v1 3/4] objectextendinformation.c: Ensure information->object_blocks is not NULL

CID 26033: Dereference after null check in _Objects_Extend_information(). Closes #4326 --- cpukit/score/src/objectextendinformation.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/cpukit/score/src/objectextendinformation.c b/cpukit/score/src/objectextendinformation.c index 979

[PATCH v1 4/4] rtl-allocator.c: Put dereferences after nullcheck

CID 1444139: Dereference null return value in rtems_rtl_alloc_hook(). Closes #4333 --- cpukit/libdl/rtl-allocator.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/cpukit/libdl/rtl-allocator.c b/cpukit/libdl/rtl-allocator.c index 647c0c8..861754e 100644 --- a/cpukit/lib

[PATCH v1 2/4] main_rtrace.c: Add error return when malloc fails

CID 1399709: Dereference after null check in rtems_trace_buffering_shell_save(). Closes #4329 --- cpukit/libmisc/shell/main_rtrace.c | 1 + 1 file changed, 1 insertion(+) diff --git a/cpukit/libmisc/shell/main_rtrace.c b/cpukit/libmisc/shell/main_rtrace.c index 753ab9d..e4f59c4 100644 --- a/cpu

[PATCH v1 1/4] rtems-fdt.c: Fix Resource leak (CID #1437645)

CID 1437645: Resource leak in rtems_fdt_load(). Closes #4297 --- cpukit/libmisc/rtems-fdt/rtems-fdt.c | 1 + 1 file changed, 1 insertion(+) diff --git a/cpukit/libmisc/rtems-fdt/rtems-fdt.c b/cpukit/libmisc/rtems-fdt/rtems-fdt.c index 7747ba9..dc5393c 100644 --- a/cpukit/libmisc/rtems-fdt/rtems

[PATCH v1 0/4] Acked patches

Hi, These patches are from various patch sets to fix Coverity issues. These were previously acked, but other patches in the corresponding patch sets prevented them from getting pushed. Thanks, Ryan Ryan Long (4): rtems-fdt.c: Fix Resource leak (CID #1437645) main_rtrace.c: Add error return

Re: [PATCH v2] cpukit/libmisc/monitor: Fix src/dest overlap of strcpy in mon-editor.c

This looks OK. On Thu, May 27, 2021 at 7:32 PM Harrison Edward Gerber wrote: > From: Harrison Edward Gerber > > See also CID 1399727 > > Closes # > --- > cpukit/libmisc/monitor/mon-editor.c | 12 +++- > 1 file changed, 11 insertions(+), 1 deletion(-) > > diff --git a/cpukit/libmisc

Re: [PATCH v2] legacy nfs.c: Change filesystem utime_h handler to utimens_h

The RSB has been updated to include the newlib patch for a week now. I plan to push the utimens patches to rtems, libbsd, and legacy by the end of today. I've held off a bit since this required a newlib/tool bump. I think there has been plenty of notice now. --joel On Fri, May 28, 2021 at 9:14 A

RE: [PATCH 1/2] rtl-obj.c: Added an early return if rtl lock fails

-Original Message- From: Chris Johns Sent: Monday, April 5, 2021 6:46 PM To: Ryan Long ; Gedare Bloom Cc: devel@rtems.org Subject: Re: [PATCH 1/2] rtl-obj.c: Added an early return if rtl lock fails On 5/4/21 11:11 pm, Ryan Long wrote: > When you say "allocating the main data structur

Re: [PATCH v2 3/3] main_help.c: Do not care what char is returned by getchar()

Hi all, On Fri, May 28, 2021, 08:54 Gedare Bloom wrote: > Are these three still pending? If so, can you ping the other 2 or > advise what is blocking? > > On Mon, Apr 5, 2021 at 7:28 AM Ryan Long wrote: > > > > CID 1437650: Unchecked return value from library in rtems_shell_help(). > > > > Clo

RE: [PATCH v2 3/3] main_help.c: Do not care what char is returned by getchar()

You acked them, and I sent the tarball with the patches to Joel. So I think Joel just forgot to put them in. -Original Message- From: Gedare Bloom Sent: Friday, May 28, 2021 9:55 AM To: Ryan Long Cc: devel@rtems.org Subject: Re: [PATCH v2 3/3] main_help.c: Do not care what char is retu

Re: [PATCH v2 3/3] main_help.c: Do not care what char is returned by getchar()

Are these three still pending? If so, can you ping the other 2 or advise what is blocking? On Mon, Apr 5, 2021 at 7:28 AM Ryan Long wrote: > > CID 1437650: Unchecked return value from library in rtems_shell_help(). > > Closes #4291 > --- > cpukit/libmisc/shell/main_help.c | 2 +- > 1 file change

RE: [PATCH v2] legacy nfs.c: Change filesystem utime_h handler to utimens_h

Reply is below. From: Joel Sherrill Sent: Friday, May 21, 2021 9:44 AM To: Gedare Bloom Cc: Ryan Long ; vi...@rtems.rog; rtems-de...@rtems.org Subject: Re: [PATCH v2] legacy nfs.c: Change filesystem utime_h handler to utimens_h As a warning, this and the corresponding libbsd patch are queued