Re: [PATCH] Make zero size allocation result consistent

2021-05-03 Thread Gedare Bloom
ok. This could break applications in strange ways if they depended on the old behavior. A clear note will be needed in release. On Mon, May 3, 2021 at 1:21 AM Sebastian Huber wrote: > > The zero size allocations had no consistent behaviour in RTEMS. For > example, malloc( 0 ) returned NULL and p

Re: [PATCH] rtems: Use allocator mutex for timer server

2021-05-03 Thread Sebastian Huber
On 04/05/2021 08:39, Gedare Bloom wrote: ok. It seems like it was a bit of a misuse of the _Once interface to directly access its lock mechanism. Does this now make the only use of _Once_Lock inside of _Once? Maybe, _Once_Lock/Unlock should not be exposed (change to static in once.c)? Yes, this

Re: [PATCH] rtems: Use allocator mutex for timer server

2021-05-03 Thread Gedare Bloom
ok. It seems like it was a bit of a misuse of the _Once interface to directly access its lock mechanism. Does this now make the only use of _Once_Lock inside of _Once? Maybe, _Once_Lock/Unlock should not be exposed (change to static in once.c)? On Sun, May 2, 2021 at 11:00 PM Sebastian Huber wrot

Re: About finding the bsp for qemu ( t2080rdb)

2021-05-03 Thread Karel Gardas
I've tried all variants IIRC of qoriq (e550/e5500/e6500) in qemu sometime ago (5.x development branch) and it booted but then was blocked on the serial port interaction and I really had no idea how to fix that. Debugger points out to the function where RTEMS asked serial port about a status and th

Re: About finding the bsp for qemu ( t2080rdb)

2021-05-03 Thread Richi Dubey
Hi? On Fri, Apr 30, 2021 at 12:01 PM Richi Dubey wrote: > Hi, > > I looked at the docs > , > and I want to build a bsp that I can test on qemu (it would be best if the > bsp models qoriq t2080). The doc says that "qoriq_

Re: [PATCH v1 1/5] libcsupport: Added futimens() and utimensat()

2021-05-03 Thread Sebastian Huber
On 03/05/2021 15:40, Ryan Long wrote: Created futimens.c and utimensat.c to add support for the POSIX methods futimens() and utimensat(). utime() and utimes() are considered obsolote by POSIX, but RTEMS will continue to support them. Closes #4396 --- cpukit/Makefile.am | 2

Re: [PATCH v1 2/5] libcsupport: Implement utime() in terms of utimensat()

2021-05-03 Thread Sebastian Huber
On 03/05/2021 15:40, Ryan Long wrote: utime() now calls utimensat() to update file access and modification timestamps. Mention license change? Closes #4397 --- cpukit/libcsupport/src/utime.c | 74 +++--- 1 file changed, 41 insertions(+), 33 deletions(-)

[PATCH rtems-net-legacy] Re-license copyright texts

2021-05-03 Thread Vijay Kumar Banerjee
--- bsp_drivers.py | 3 ++- netlegacy.py| 3 ++- testsuites/ftp01/wscript| 3 ++- testsuites/loopback/wscript | 3 ++- testsuites/networking01/wscript | 3 ++- testsuites/pppd/wscript | 3 ++- testsuites/syscall01/wscript| 3 ++- testsui

Re: [PATCH rtems-net-legacy v2] bsp_drivers: Use os.path for compatibility with non Unix host

2021-05-03 Thread Vijay Kumar Banerjee
Is this Ok to push? On Mon, Apr 19, 2021 at 11:32 AM Vijay Kumar Banerjee wrote: > > On Mon, Apr 19, 2021 at 11:30 AM Vijay Kumar Banerjee wrote: > > > > --- > > bsp_drivers.py | 22 +++--- > > 1 file changed, 11 insertions(+), 11 deletions(-) > > > > diff --git a/bsp_drivers.py

[PATCH v2] legacy nfs.c: Change filesystem utime_h handler to utimens_h

2021-05-03 Thread Ryan Long
Changed nfs_utime() to nfs_utimens(), changed the arguments to use a timespec array instead of individual variables for access and modified time. Updates #4400 --- nfsclient/src/nfs.c | 50 +- 1 file changed, 25 insertions(+), 25 deletions(-) diff

[PATCH v2] libbsd nfs.c: Change filesystem utime_h handler to utimens_h

2021-05-03 Thread Ryan Long
Changed nfs_utime() to nfs_utimens(), changed the arguments to use a timespec array instead of individual variables for access and modified time. Updates #4400 --- rtemsbsd/nfsclient/nfs.c | 50 1 file changed, 25 insertions(+), 25 deletions(-) di

Re: [PATCH] nfs.c: Change filesystem utime_h handler to utimens_h

2021-05-03 Thread Joel Sherrill
Ryan.. these have the same subject/short message and are threading together as the same patch. Resubmit both as v2 with libbsd and net-legacy added to the commit message. Something like: legacy nfs.c: Change filesystem utime_h handler to utimens_h libbsd nfs.c: Change filesystem utime_h handler t

[PATCH] nfs.c: Change filesystem utime_h handler to utimens_h

2021-05-03 Thread Ryan Long
Changed nfs_utime() to nfs_utimens(), changed the arguments to use a timespec array instead of individual variables for access and modified time. Updates #4400 --- nfsclient/src/nfs.c | 50 +- 1 file changed, 25 insertions(+), 25 deletions(-) diff

[PATCH] nfs.c: Change filesystem utime_h handler to utimens_h

2021-05-03 Thread Ryan Long
Changed nfs_utime() to nfs_utimens(), changed the arguments to use a timespec array instead of individual variables for access and modified time. Updates #4400 --- rtemsbsd/nfsclient/nfs.c | 50 1 file changed, 25 insertions(+), 25 deletions(-) di

Re: [PATCH v2] bsps/shared/ofw: Fix coverity defects

2021-05-03 Thread Gedare Bloom
Hi Niteesh, This looks good to me. What/how did you test it? Gedare On Sat, May 1, 2021 at 6:31 AM G S Niteesh Babu wrote: > > This patch adds asserts to fix coverity defects > 1) CID 1474437 (Out-of-bounds access) > 2) CID 1474436 (Out-of-bounds access) > > From manual inspection, out of bound

Re: Issues with rtems_waf on Windows 10 with gccdeps module

2021-05-03 Thread Vijay Kumar Banerjee
Hi Robin, On Mon, May 3, 2021 at 6:37 AM Robin Müller wrote: > > I also tried bld.path.find_or_declare('rtems.h') like in the supplied example, but that did not work for me either. > That worked for me in multiple places before. not sure what's happening there. > Kind Regards > Robin > > On Mo

[PATCH v1 5/5] Change filesystem utime_h handler to utimens_h

2021-05-03 Thread Ryan Long
Closes #4400 --- bsps/arm/csb337/umon/tfsDriver.c| 2 +- cpukit/Makefile.am | 4 +-- cpukit/include/rtems/confdefs/libio.h | 4 +-- cpukit/include/rtems/imfs.h | 7 +++-- cpukit/include/rtems/libio.h| 21 +++

[PATCH v1 3/5] libcsupport: Implement utimes() in terms of utimensat()

2021-05-03 Thread Ryan Long
utimes() now calls utimensat() to update file access and modification timestamps. Closes #4398 --- cpukit/libcsupport/src/utimes.c | 54 ++--- 1 file changed, 40 insertions(+), 14 deletions(-) diff --git a/cpukit/libcsupport/src/utimes.c b/cpukit/libcsupport/s

[PATCH v1 4/5] psx13: Added tests for utimensat() and futimens()

2021-05-03 Thread Ryan Long
Improved tests for utime() and utimes(). Close #4399 --- testsuites/psxtests/psx13/main.c | 2 - testsuites/psxtests/psx13/test.c | 484 +-- 2 files changed, 471 insertions(+), 15 deletions(-) diff --git a/testsuites/psxtests/psx13/main.c b/testsuites/psxtes

[PATCH v1 2/5] libcsupport: Implement utime() in terms of utimensat()

2021-05-03 Thread Ryan Long
utime() now calls utimensat() to update file access and modification timestamps. Closes #4397 --- cpukit/libcsupport/src/utime.c | 74 +++--- 1 file changed, 41 insertions(+), 33 deletions(-) diff --git a/cpukit/libcsupport/src/utime.c b/cpukit/libcsupport/src

[PATCH v1 1/5] libcsupport: Added futimens() and utimensat()

2021-05-03 Thread Ryan Long
Created futimens.c and utimensat.c to add support for the POSIX methods futimens() and utimensat(). utime() and utimes() are considered obsolote by POSIX, but RTEMS will continue to support them. Closes #4396 --- cpukit/Makefile.am | 2 + cpukit/include/rtems/libio_.h | 6

[PATCH v1 0/5] Add nanosecond support patch

2021-05-03 Thread Ryan Long
Hi, For this series of patches, I - Created the futimens() and utimensat() functions - Reimplemented utime() and utimes() using utimensat() - Added onto the test cases for utime() and utimes() - Made tests for utimensat() and futimens() - Changed the utime_h handler to utimens_h() I still have t

Re: Issues with rtems_waf on Windows 10 with gccdeps module

2021-05-03 Thread Robin Müller
I also tried bld.path.find_or_declare('rtems.h') like in the supplied example, but that did not work for me either. Kind Regards Robin On Mon, 3 May 2021 at 14:31, Robin Müller wrote: > Hello Vijay, > > I tried bld.find_or_declare('rtems.h') but that did not work for me. > > Just out of curiosi

Re: Issues with rtems_waf on Windows 10 with gccdeps module

2021-05-03 Thread Robin Müller
Hello Vijay, I tried bld.find_or_declare('rtems.h') but that did not work for me. Just out of curiosity, why was the patch not accepted? I did not find anything in the waf gitlab. Kind Regards Robin On Sat, 1 May 2021 at 20:29, Vijay Kumar Banerjee wrote: > Hi Robin, > > On Fri, Apr 30, 2021

Re: [PATCH] riscv/start: Startup sequence update.

2021-05-03 Thread somesh deshmukh
On Mon, May 3, 2021 at 5:36 PM Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > On 03/05/2021 13:47, somesh deshmukh wrote: > > > I performed the following sequence of instruction: > > ./waf clean > > ./waf configure > > ./waf > > > > Tried this couple of times but the same result al

Re: [PATCH] riscv/start: Startup sequence update.

2021-05-03 Thread Sebastian Huber
On 03/05/2021 13:47, somesh deshmukh wrote: I performed the following sequence of instruction: ./waf clean ./waf configure ./waf Tried this couple of times but the same result always. I will try this again with fresh sources from rsb and rtems master branches. Now it should work. I forgot to

Re: [PATCH] riscv/start: Startup sequence update.

2021-05-03 Thread somesh deshmukh
On Mon, May 3, 2021 at 5:01 PM Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > On 03/05/2021 13:25, somesh deshmukh wrote: > > > > > I tried this patch with the master branch and the build is failing > > after applying the patch. > > > > The error message includes: > > > > > /home/s

Re: [PATCH] riscv/start: Startup sequence update.

2021-05-03 Thread Sebastian Huber
On 03/05/2021 13:25, somesh deshmukh wrote: I tried this patch with the master branch and the build is failing after applying the patch. The error message includes: /home/somesh/Documents/rtems-temp/rtems/6/lib/gcc/riscv-rtems6/10.2.1/../../../../riscv-rtems6/bin/ld: /home/somesh/work/rtem

Re: [PATCH] riscv/start: Startup sequence update.

2021-05-03 Thread somesh deshmukh
Hi Sebastian, I tried this patch with the master branch and the build is failing after applying the patch. The error message includes: /home/somesh/Documents/rtems-temp/rtems/6/lib/gcc/riscv-rtems6/10.2.1/../../../../riscv-rtems6/bin/ld: /home/somesh/work/rtems-master/rtems/build/riscv/rv64imafd

[PATCH] Make zero size allocation result consistent

2021-05-03 Thread Sebastian Huber
The zero size allocations had no consistent behaviour in RTEMS. For example, malloc( 0 ) returned NULL and posix_memalign( &p, align, 0 ) retruned in p a unique pointer (or NULL if no memory is available). In POSIX, zero size memory allocations are implementation-defined behaviour. The implement