Re: [rtems commit] getgrent.c: Fix Unchecked return value error (CID #1459004)

2021-02-26 Thread Vijay Kumar Banerjee
Hi, I'm getting build error after this commit. ``` /home/vijay/development/rtems/6/lib/gcc/i386-rtems6/10.2.1/../../../../i386-rtems6/bin/ld: ./librtemscpu.a(getgrent.c.57.o): in function `endgrent': /home/vijay/rtems-class/rtems/build/i386/pc386/../../../cpukit/libcsupport/src/getgrent.c:109: und

Re: [PATCH v2 0/4] Fix Unchecked return value Coverity errors

2021-02-26 Thread Chris Johns
On 27/2/21 9:36 am, Gedare Bloom wrote: > v2 looks good to me +1 > > On Fri, Feb 26, 2021 at 3:15 PM Ryan Long wrote: >> >> Hi, >> >> Here's the patches with the changes. >> >> Thanks, >> Ryan >> >> Ryan Long (4): >> printertask.c: Fix Unchecked return value (CID #1399710) >> record-client.

[5 PATCH] powerpc/motorola_power: Place any common data in the .bss section

2021-02-26 Thread chrisj
From: Chris Johns - It seems the compiler how defaults to -fcommon and this means some uninitialised data is ignored. Closes #4266 --- bsps/powerpc/motorola_powerpc/bootloader/ppcboot.lds | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/bsps/powerpc/motorola_powerpc/

Re: [PATCH v2 0/4] Fix Unchecked return value Coverity errors

2021-02-26 Thread Gedare Bloom
v2 looks good to me On Fri, Feb 26, 2021 at 3:15 PM Ryan Long wrote: > > Hi, > > Here's the patches with the changes. > > Thanks, > Ryan > > Ryan Long (4): > printertask.c: Fix Unchecked return value (CID #1399710) > record-client.c: Fix Unchecked return value (CID #1456677) > getgrent.c: F

[PATCH v2 4/4] rtems-debugger-threads.c: Fix Unchecked return value error (CID #1468688)

2021-02-26 Thread Ryan Long
CID 1468688: Unchecked return value in snapshot_thread(). Closes #4262 --- cpukit/libdebugger/rtems-debugger-threads.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/cpukit/libdebugger/rtems-debugger-threads.c b/cpukit/libdebugger/rtems-debugger-threads.c index 5b96e5f..e

[PATCH v2 3/4] getgrent.c: Fix Unchecked return value error (CID #1459004)

2021-02-26 Thread Ryan Long
CID 1459004: Unchecked return value in endgrent(). Closes #4261 --- cpukit/libcsupport/src/getgrent.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/cpukit/libcsupport/src/getgrent.c b/cpukit/libcsupport/src/getgrent.c index b358cb9..de56430 100644 --- a/cpukit/libcsuppor

[PATCH v2 2/4] record-client.c: Fix Unchecked return value (CID #1456677)

2021-02-26 Thread Ryan Long
CID 1456677: Unchecked return value in resolve_hold_back(). Closes #4260 --- cpukit/libtrace/record/record-client.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/cpukit/libtrace/record/record-client.c b/cpukit/libtrace/record/record-client.c index 5a68115..975e3a7 100644

[PATCH v2 1/4] printertask.c: Fix Unchecked return value (CID #1399710)

2021-02-26 Thread Ryan Long
CID 1399710: Unchecked return value in printer_task(). CID 1472764: Unchecked return value in rtems_print_printer_task(). Closes #4258 --- cpukit/libcsupport/src/printertask.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/cpukit/libcsupport/src/printertask.c b/c

[PATCH v2 0/4] Fix Unchecked return value Coverity errors

2021-02-26 Thread Ryan Long
Hi, Here's the patches with the changes. Thanks, Ryan Ryan Long (4): printertask.c: Fix Unchecked return value (CID #1399710) record-client.c: Fix Unchecked return value (CID #1456677) getgrent.c: Fix Unchecked return value error (CID #1459004) rtems-debugger-threads.c: Fix Unchecked ret

Re: [PATCH 4/4] rtems-debugger-threads.c: Fix Unchecked return value error (CID #1468688)

2021-02-26 Thread Gedare Bloom
On Fri, Feb 26, 2021 at 2:35 PM Ryan Long wrote: > > CID 1468688: Unchecked return value in snapshot_thread(). > > Closes #4262 > --- > cpukit/libdebugger/rtems-debugger-threads.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/cpukit/libdebugger/rtems-debugger-thread

Re: [PATCH 3/4] getgrent.c: Fix Unchecked return value error (CID #1459004)

2021-02-26 Thread Gedare Bloom
On Fri, Feb 26, 2021 at 2:35 PM Ryan Long wrote: > > CID 1459004: Unchecked return value in endgrent(). > > Closes #4261 > --- > cpukit/libcsupport/src/getgrent.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/cpukit/libcsupport/src/getgrent.c > b/cpukit/libcsupport/

Re: [PATCH 1/4] printertask.c: Fix Unchecked return value (CID #1399710)

2021-02-26 Thread Gedare Bloom
On Fri, Feb 26, 2021 at 2:34 PM Ryan Long wrote: > > CID 1399710: Unchecked return value in printer_task(). > CID 1472764: Unchecked return value in rtems_print_printer_task(). > > Closes #4258 > --- > cpukit/libcsupport/src/printertask.c | 9 ++--- > 1 file changed, 6 insertions(+), 3 deleti

[PATCH 4/4] rtems-debugger-threads.c: Fix Unchecked return value error (CID #1468688)

2021-02-26 Thread Ryan Long
CID 1468688: Unchecked return value in snapshot_thread(). Closes #4262 --- cpukit/libdebugger/rtems-debugger-threads.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/cpukit/libdebugger/rtems-debugger-threads.c b/cpukit/libdebugger/rtems-debugger-threads.c index 5b96e5f..

[PATCH 3/4] getgrent.c: Fix Unchecked return value error (CID #1459004)

2021-02-26 Thread Ryan Long
CID 1459004: Unchecked return value in endgrent(). Closes #4261 --- cpukit/libcsupport/src/getgrent.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/cpukit/libcsupport/src/getgrent.c b/cpukit/libcsupport/src/getgrent.c index b358cb9..534e04c 100644 --- a/cpukit/libcsuppor

[PATCH 1/4] printertask.c: Fix Unchecked return value (CID #1399710)

2021-02-26 Thread Ryan Long
CID 1399710: Unchecked return value in printer_task(). CID 1472764: Unchecked return value in rtems_print_printer_task(). Closes #4258 --- cpukit/libcsupport/src/printertask.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/cpukit/libcsupport/src/printertask.c b/cpuk

[PATCH 2/4] record-client.c: Fix Unchecked return value (CID #1456677)

2021-02-26 Thread Ryan Long
CID 1456677: Unchecked return value in resolve_hold_back(). Closes #4260 --- cpukit/libtrace/record/record-client.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/cpukit/libtrace/record/record-client.c b/cpukit/libtrace/record/record-client.c index 5a68115..975e3a7 100644

[PATCH 0/4] Fix Unchecked return value Coverity errors

2021-02-26 Thread Ryan Long
Hi, Here are some fixes for a few of the "Unchecked return value" Coverity errors. Mainly, I just created a variable to store the status code returned from function calls and used the _Assert_Unused_variable_equals() macro to assert that the call was successful. I also added a (void) in front of

Re: Standalone repository for libnetworking stack

2021-02-26 Thread Joel Sherrill
On Fri, Feb 26, 2021, 11:49 AM Chris Johns wrote: > On 27/2/21 4:40 am, Vijay Kumar Banerjee wrote: > > Hi all, > > > > Thanks for reviewing > > > > On Fri, Feb 26, 2021 at 10:13 AM Joel Sherrill wrote: > >> > >> Some odd questions that are mostly about making this a self-contained > entity with

Re: Standalone repository for libnetworking stack

2021-02-26 Thread Gedare Bloom
On Fri, Feb 26, 2021 at 10:49 AM Chris Johns wrote: > On 27/2/21 4:40 am, Vijay Kumar Banerjee wrote: > > On Fri, Feb 26, 2021 at 10:13 AM Joel Sherrill wrote: > >> On Fri, Feb 26, 2021 at 12:12 AM Gedare Bloom wrote: > >>> On Thu, Feb 25, 2021 at 6:06 PM Chris Johns wrote: > On 26/2/21 4:

Re: [PATCH rtems-libbsd 1/2] racoon/session: Honor file descriptor maximum

2021-02-26 Thread Chris Johns
On 26/2/21 2:01 am, Christian Mauderer wrote: > Dynamically allocate a big enough file descriptor set for select(). A > better solution would be to use kqueue() instead of select(). > --- > .../racoon/rtems-bsd-racoon-session-data.h| 6 +-- > ipsec-tools/src/racoon/session.c | 40

Re: Standalone repository for libnetworking stack

2021-02-26 Thread Vijay Kumar Banerjee
On Fri, Feb 26, 2021 at 10:49 AM Chris Johns wrote: > > On 27/2/21 4:40 am, Vijay Kumar Banerjee wrote: > > Hi all, > > > > Thanks for reviewing > > > > On Fri, Feb 26, 2021 at 10:13 AM Joel Sherrill wrote: > >> > >> Some odd questions that are mostly about making this a self-contained > >> enti

Re: Standalone repository for libnetworking stack

2021-02-26 Thread Vijay Kumar Banerjee
On Fri, Feb 26, 2021 at 10:46 AM Joel Sherrill wrote: > > > > On Fri, Feb 26, 2021, 11:40 AM Vijay Kumar Banerjee wrote: >> >> Hi all, >> >> Thanks for reviewing >> >> On Fri, Feb 26, 2021 at 10:13 AM Joel Sherrill wrote: >> > >> > Some odd questions that are mostly about making this a self-cont

Re: Standalone repository for libnetworking stack

2021-02-26 Thread Chris Johns
On 27/2/21 4:40 am, Vijay Kumar Banerjee wrote: > Hi all, > > Thanks for reviewing > > On Fri, Feb 26, 2021 at 10:13 AM Joel Sherrill wrote: >> >> Some odd questions that are mostly about making this a self-contained entity >> with no loose ends. >> >> + Can the network demos be merged also? >>

Re: Standalone repository for libnetworking stack

2021-02-26 Thread Joel Sherrill
On Fri, Feb 26, 2021, 11:40 AM Vijay Kumar Banerjee wrote: > Hi all, > > Thanks for reviewing > > On Fri, Feb 26, 2021 at 10:13 AM Joel Sherrill wrote: > > > > Some odd questions that are mostly about making this a self-contained > entity with no loose ends. > > > > + Can the network demos be me

Re: Standalone repository for libnetworking stack

2021-02-26 Thread Vijay Kumar Banerjee
Hi all, Thanks for reviewing On Fri, Feb 26, 2021 at 10:13 AM Joel Sherrill wrote: > > Some odd questions that are mostly about making this a self-contained entity > with no loose ends. > > + Can the network demos be merged also? > Are we talking about testsuites tests that use legacy networkin

Re: Standalone repository for libnetworking stack

2021-02-26 Thread Joel Sherrill
Some odd questions that are mostly about making this a self-contained entity with no loose ends. + Can the network demos be merged also? + rtems-docs has the Network Users Guide which is legacy only. As a minimum, it needs to be renamed to have Legacy in the title. Better would be to convert it t

[PATCH 2/2] score: Fix _Stack_Extend_size()

2021-02-26 Thread Sebastian Huber
Check for an integer overflow. Add a validation test for task create errors. --- cpukit/include/rtems/score/stackimpl.h| 28 +- .../testsuites/validation/validation-0.yml|1 + testsuites/validation/tc-task-create-errors.c | 3180 + 3 files changed, 3202 insertion