Re: [PATCH] eng: Move code formatting rules into one section

2020-11-06 Thread Sebastian Huber
On 06/11/2020 10:35, Andrew Butterfield wrote: The closing ``*/`` should appear on a line by itself at the end. Thanks for the review, I changed the patch to use this sentence. -- embedded brains GmbH Sebastian HUBER Dornierstr. 4 82178 Puchheim Germany email: sebastian.hu...@embedded-brains.d

Re: [PATCH] eng: Move code formatting rules into one section

2020-11-06 Thread Andrew Butterfield
Hi Sebastian > + /* > + * Excessively long comments should be broken up at a word boundary or > + * somewhere that makes sense, for example. > + */ > + > +Note that multiline comments have a single asterisk aligned with the asterisk > +in the opening ``/*``. > The closing ``*/`` should g

[PATCH] if_ffec: Fix cache handling on tx.

2020-11-06 Thread Christian Mauderer
With the previous fix, it could happen that the end of the packet hasn't been flushed. For example assume the following addresses: ds_addr: 0x81c804A ds_len: 0x57 In that case the data ends at 0x81c80a1. But due to the rounding the area from 0x81c8040 to 0x81c80a0 would have been flushed. This f

[PATCH] eng: Move code formatting rules into one section

2020-11-06 Thread Sebastian Huber
Clarify the 80 character limit. Change the line continuation indent level. --- eng/coding-80cols.rst | 154 - eng/coding-conventions.rst | 26 - eng/coding-formatting.rst | 196 + eng/coding.rst | 2 +- 4 fil

Breaking Long Lines

2020-11-06 Thread Sebastian Huber
Hello, for breaking long lines we have currently: "Should be replaced with .. code-block:: c   for (     initialization = statement;     a + really + longish + statement + that + evaluates + to <     a + boolean;     another + statement++   ) {     z = a + really + longish + statement + that +