Re: 80 or 79 characters limit?

On Thu, Nov 5, 2020 at 2:42 PM Christian Mauderer wrote: > On 05/11/2020 21:28, Gedare Bloom wrote: > > On Thu, Nov 5, 2020 at 1:14 PM Joel Sherrill wrote: > >> > >> I tried at one point to figure out how to script the changes when I ran > into them. > >> But it was easier to fix them by hand. I

Re: 80 or 79 characters limit?

On 05/11/2020 21:28, Gedare Bloom wrote: > On Thu, Nov 5, 2020 at 1:14 PM Joel Sherrill wrote: >> >> I tried at one point to figure out how to script the changes when I ran into >> them. >> But it was easier to fix them by hand. If you have a simple script, it would >> be good >> to have a home

Re: 80 or 79 characters limit?

On Thu, Nov 5, 2020 at 2:28 PM Gedare Bloom wrote: > On Thu, Nov 5, 2020 at 1:14 PM Joel Sherrill wrote: > > > > I tried at one point to figure out how to script the changes when I ran > into them. > > But it was easier to fix them by hand. If you have a simple script, it > would be good > > to

Re: 80 or 79 characters limit?

On Thu, Nov 5, 2020 at 1:14 PM Joel Sherrill wrote: > > I tried at one point to figure out how to script the changes when I ran into > them. > But it was easier to fix them by hand. If you have a simple script, it would > be good > to have a home for it. We could grow it then. > > Not accepting

Re: 80 or 79 characters limit?

I tried at one point to figure out how to script the changes when I ran into them. But it was easier to fix them by hand. If you have a simple script, it would be good to have a home for it. We could grow it then. Not accepting unicode should be checked for patches and should be in Coding Conventi

Re: 80 or 79 characters limit?

Hello Joel, On 05/11/2020 20:15, Joel Sherrill wrote: > > > On Thu, Nov 5, 2020, 1:12 PM Christian Mauderer > wrote: > > Hello Joel and Sebastian, > > On 05/11/2020 16:44, Joel Sherrill wrote: > > > > > > On Thu, Nov 5, 2020, 9:26 AM Sebastian Hu

Re: 80 or 79 characters limit?

On Thu, Nov 5, 2020, 1:12 PM Christian Mauderer wrote: > Hello Joel and Sebastian, > > On 05/11/2020 16:44, Joel Sherrill wrote: > > > > > > On Thu, Nov 5, 2020, 9:26 AM Sebastian Huber > > > > wrote: > > > > Hello, > > > > I review currently th

Re: 80 or 79 characters limit?

Hello Joel and Sebastian, On 05/11/2020 16:44, Joel Sherrill wrote: > > > On Thu, Nov 5, 2020, 9:26 AM Sebastian Huber > > wrote: > > Hello, > > I review currently the Coding Conventions. Should the 80 characters > limit be really a 79 ch

[PATCH 3/4] eng: Clarify "Source Documentation" section

--- eng/coding-conventions.rst | 27 +-- eng/coding-file-hdr.rst| 2 ++ 2 files changed, 19 insertions(+), 10 deletions(-) diff --git a/eng/coding-conventions.rst b/eng/coding-conventions.rst index e7a67ec..5dd8df5 100644 --- a/eng/coding-conventions.rst +++ b/eng/cod

[PATCH 2/4] eng: Add header file conventions

--- eng/coding-conventions.rst | 37 + eng/coding-doxygen.rst | 2 ++ eng/coding-file-hdr.rst| 2 ++ 3 files changed, 41 insertions(+) diff --git a/eng/coding-conventions.rst b/eng/coding-conventions.rst index b85d8fc..e7a67ec 100644 --- a/eng/coding-

[PATCH 1/4] eng: Remove "Generating a Tools Patch"

This section is probably some left over stuff from CVS times. The topic is already covered by the "Software Development (Git Users)" section. --- eng/coding-gen-patch.rst | 35 --- eng/coding.rst | 1 - 2 files changed, 36 deletions(-) delete mode 10064

[PATCH 0/4] Add header file conventions

This patch set adds header file conventions and clarifies some parts. Sebastian Huber (4): eng: Remove "Generating a Tools Patch" eng: Add header file conventions eng: Clarify "Source Documentation" section eng: Clarify "Coding Conventions" introduction eng/coding-conventions.rst | 74 ++

[PATCH 4/4] eng: Clarify "Coding Conventions" introduction

--- eng/coding-conventions.rst | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/eng/coding-conventions.rst b/eng/coding-conventions.rst index 5dd8df5..e34cd74 100644 --- a/eng/coding-conventions.rst +++ b/eng/coding-conventions.rst @@ -9,11 +9,11 @@ Coding Convention

Re: Out of tree builds with waf?

On 05/11/2020 18:27, Sebastian Huber wrote: On 05/11/2020 18:22, Sebastian Huber wrote: On 05/11/2020 18:16, Andrew Butterfield wrote:  I'm not a waf expert, but might this section in their book help? https://waf.io/book/#_fundamental_waf_commands

Re: Blockers for Cutover to Waf

On Thu, Nov 5, 2020 at 9:47 AM Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > On 05/11/2020 16:46, Joel Sherrill wrote: > > > For rtems-bsps at the top of the tree, that has to be fixed > https://lists.rtems.org/pipermail/devel/2020-November/063024.html >

Re: Out of tree builds with waf?

On 11/5/20 6:27 PM, Sebastian Huber wrote: > 2. Waf somehow remembers this configuration. You can call "./waf" to > build it. So, there must be some hidden state in the source tree. This > is not really an out of tree build. You cannot have multiple independent > build trees. When your build syste

Re: Out of tree builds with waf?

On 05/11/2020 18:22, Sebastian Huber wrote: On 05/11/2020 18:16, Andrew Butterfield wrote:  I'm not a waf expert, but might this section in their book help? https://waf.io/book/#_fundamental_waf_commands Can variables `top` and `out` in the

Re: Out of tree builds with waf?

On 05/11/2020 18:16, Andrew Butterfield wrote:  I'm not a waf expert, but might this section in their book help? https://waf.io/book/#_fundamental_waf_commands Can variables `top` and `out` in the example there be manipulated to do want you w

Re: Out of tree builds with waf?

Hi Sebastian, I'm not a waf expert, but might this section in their book help? https://waf.io/book/#_fundamental_waf_commands Can variables `top` and `out` in the example there be manipulated to do want you want? Regards, Andrew > On 5 Nov 2

Re: [PATCH] build: Place cache file in build directory

On Thu, Nov 5, 2020 at 10:13 AM Sebastian Huber wrote: > > On 05/11/2020 18:00, Gedare Bloom wrote: > > > ok I think. the commit message confused me since the c4che was in the > > 'build/' directory already, now you move to the directory in which the > > build happens. > > > > I guess this means i

Re: [PATCH] build: Place cache file in build directory

On 05/11/2020 18:00, Gedare Bloom wrote: ok I think. the commit message confused me since the c4che was in the 'build/' directory already, now you move to the directory in which the build happens. I guess this means if one builds in the source tree and doesn't specify --out, they will get c4che

Re: [PATCH 1/4] sparc: Move SPARC-specific macros to sparc.h

On Thu, Nov 5, 2020 at 8:09 AM Sebastian Huber wrote: > > Clarify Doxygen comments. Fix formatting. > > Update #4171. > --- > .../score/cpu/sparc/include/rtems/score/cpu.h | 21 > .../cpu/sparc/include/rtems/score/sparc.h | 32 ++- > 2 files changed, 31 insertion

Re: [PATCH] build: Place cache file in build directory

ok I think. the commit message confused me since the c4che was in the 'build/' directory already, now you move to the directory in which the build happens. I guess this means if one builds in the source tree and doesn't specify --out, they will get c4che in rtems.git source? This directory should

Re: Out of tree builds with waf?

On 05/11/2020 17:09, Joel Sherrill wrote: On Thu, Nov 5, 2020 at 10:04 AM Sebastian Huber > wrote: Hello, I tried to do an out of tree build with waf: ~/src/rtems/waf configure --rtems-config $PWD/config.ini --out $PWD/build --top

Re: [PATCH v4 0/1] Test for clock_nanosleep() with CLOCK_MONOTONIC option

On Thu, Nov 5, 2020 at 12:13 AM Gedare Bloom wrote: > i need to find time to look at this, and try it out. > > Does this compile? e.g., I don't see a definition of OPERATION_COUNT > Yes, the OPERATION_COUNT is defined in "timesys.h". > > On Wed, Oct 28, 2020 at 7:34 AM Utkarsh Rai > wrote: >

Re: Out of tree builds with waf?

On Thu, Nov 5, 2020 at 10:04 AM Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > Hello, > > I tried to do an out of tree build with waf: > > ~/src/rtems/waf configure --rtems-config $PWD/config.ini --out > $PWD/build --top $HOME/src/rtems > > This seems to work, however, I get a mess

Out of tree builds with waf?

Hello, I tried to do an out of tree build with waf: ~/src/rtems/waf configure --rtems-config $PWD/config.ini --out $PWD/build --top $HOME/src/rtems This seems to work, however, I get a message like this (CWD /home ...): ~/src/rtems/waf --out $PWD/build --top $HOME/src/rtems Waf: Entering dir

[PATCH] build: Place cache file in build directory

This improves support for the --out option. --- wscript | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/wscript b/wscript index 57ec6ff7f7..5f6958dbf3 100755 --- a/wscript +++ b/wscript @@ -1135,8 +1135,8 @@ def load_from_yaml(load, ctx, data_by_uid, base, path): def l

Re: Blockers for Cutover to Waf

On 05/11/2020 16:46, Joel Sherrill wrote: For rtems-bsps at the top of the tree, that has to be fixed https://lists.rtems.org/pipermail/devel/2020-November/063024.html -- embedded brains GmbH Sebastian HUBER Dornierstr. 4 821

Re: Blockers for Cutover to Waf

On Thu, Nov 5, 2020, 9:39 AM Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > > On 05/11/2020 16:35, Joel Sherrill wrote: > > > > > > On Thu, Nov 5, 2020 at 9:05 AM Sebastian Huber > > > > wrote: > > > > Hello Joel, > > > > On 28/10

Re: 80 or 79 characters limit?

On Thu, Nov 5, 2020, 9:26 AM Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > Hello, > > I review currently the Coding Conventions. Should the 80 characters > limit be really a 79 characters limit with the \n as the invisible 80th > character? > Yes. As old as this makes me feel, I

Re: Blockers for Cutover to Waf

On 05/11/2020 16:35, Joel Sherrill wrote: On Thu, Nov 5, 2020 at 9:05 AM Sebastian Huber > wrote: Hello Joel, On 28/10/2020 15:25, Joel Sherrill wrote: > Hi > > I didn't want to hijack the greth thread with this but there are

Re: Blockers for Cutover to Waf

On Thu, Nov 5, 2020 at 9:05 AM Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > Hello Joel, > > On 28/10/2020 15:25, Joel Sherrill wrote: > > Hi > > > > I didn't want to hijack the greth thread with this but there are open > > wafblocker issues which prevent the cutover to waf. > > >

80 or 79 characters limit?

Hello, I review currently the Coding Conventions. Should the 80 characters limit be really a 79 characters limit with the \n as the invisible 80th character? -- embedded brains GmbH Sebastian HUBER Dornierstr. 4 82178 Puchheim Germany email: sebastian.hu...@embedded-brains.de Phone: +49-89-18

Re: [PATCH v3 0/2] Add networking support for griscv bsp

Does anyone object to this patch? Otherwise I will go ahead and commit it... Jiri. On 11/1/20 4:46 PM, Jiri Gaisler wrote: > Third attempt. Needed to fix the waf build and add correct link address > for the griscv bsp. Tested with rtems-netdemos. > > Jiri Gaisler (2): > Add networking support f

Re: [PATCH 2/4] sparc: Add SPARC_IS_INTERRUPT_TRAP()

On 05/11/2020 16:09, Sebastian Huber wrote: + * @brief _trap is the real hardware vector number, synchronous trap number, or + * asynchronous trap number to check. I  already fixed the @brief -> @param typos. -- embedded brains GmbH Sebastian HUBER Dornierstr. 4 82178 Puchheim Germany email:

[PATCH 0/4] Reduce copy and paste in the SPARC port

This patch set just removes a bit of copy and paste in the SPARC port. Sebastian Huber (4): sparc: Move SPARC-specific macros to sparc.h sparc: Add SPARC_IS_INTERRUPT_TRAP() sparc: Add SPARC_INTERRUPT_TRAP_TO_SOURCE() sparc: Add SPARC_INTERRUPT_SOURCE_TO_TRAP() bsps/sparc/erc32/include/e

[PATCH 3/4] sparc: Add SPARC_INTERRUPT_TRAP_TO_SOURCE()

Update #4171. --- bsps/sparc/erc32/include/erc32.h | 2 +- bsps/sparc/erc32/start/setvec.c| 2 +- bsps/sparc/leon2/include/leon.h| 2 +- bsps/sparc/leon2/start/setvec.c| 2 +- bsps/sparc/leon3/include/leon.h

[PATCH 1/4] sparc: Move SPARC-specific macros to sparc.h

Clarify Doxygen comments. Fix formatting. Update #4171. --- .../score/cpu/sparc/include/rtems/score/cpu.h | 21 .../cpu/sparc/include/rtems/score/sparc.h | 32 ++- 2 files changed, 31 insertions(+), 22 deletions(-) diff --git a/cpukit/score/cpu/sparc/include/rte

[PATCH 4/4] sparc: Add SPARC_INTERRUPT_SOURCE_TO_TRAP()

Update #4171. --- bsps/sparc/erc32/include/erc32.h | 2 +- bsps/sparc/leon2/include/leon.h| 2 +- bsps/sparc/leon3/include/leon.h| 2 +- cpukit/score/cpu/sparc/include/rtems/score/sparc.h | 9 + 4 files changed, 12 insertions(+), 3

[PATCH 2/4] sparc: Add SPARC_IS_INTERRUPT_TRAP()

Update #4171. --- bsps/sparc/erc32/include/erc32.h | 4 +--- bsps/sparc/erc32/start/setvec.c| 9 +++-- bsps/sparc/leon2/include/leon.h| 4 +--- bsps/sparc/leon2/start/setvec.c| 9 +++-- bsps/sparc/leon3/inclu

Re: Blockers for Cutover to Waf

Hello Joel, On 28/10/2020 15:25, Joel Sherrill wrote: Hi I didn't want to hijack the greth thread with this but there are open wafblocker issues which prevent the cutover to waf. https://devel.rtems.org/query?status=accepted&status=assigned&status=new&status=reopened&keywords=~wafblocker&gro