Re: [PATCH] display/disp_hcms29xx fix string turncation warning

2020-09-06 Thread Sebastian Huber
On 03/09/2020 16:46, Aschref Ben-Thabet wrote: From: Aschref Ben Thabet strncpy Please use the strncpy() style for functions in commit messages and comments. is unsafe if the terminating NULL There are NULL pointers and NUL characters, see https://www.man7.org/linux/man-pages/man7/ascii.7

Re: [PATCH v2] testsuits/dl10 : Prototype missing

2020-09-06 Thread Sebastian Huber
On 31/08/2020 12:37, Aschref Ben-Thabet wrote: From: Aschref Ben Thabet Add a prototype for the function rtems_main_o5 to avoid the prototype missing warning. Please write it like this: Add a prototype for the function rtems_main_o5() to avoid the prototype missing warning. --- testsuit

New coding style for new files?

2020-09-06 Thread Sebastian Huber
Hello, I think we waste too much time to address coding style issues on newly contributed code, for example GSoC. I don't know a source code formatting tool which supports the RTEMS coding style and I think it is not worth the time to write and maintain such a tool specifically for RTEMS. Why

Re: Introducing the Strong APA Scheduler

2020-09-06 Thread Sebastian Huber
On 03/09/2020 17:10, Richi Dubey wrote: Any views on this? Sorry for the delay. Did you run the test suite with this scheduler as the default and check how many tests pass? diff --git a/cpukit/include/rtems/confdefs/scheduler.h b/cpukit/include/rtems/confdefs/scheduler.h index 9305fc2d90.

Re: BSP Test Results

2020-09-06 Thread Chris Johns
On 7/9/20 2:16 pm, Joel Sherrill wrote: > > > On Sun, Sep 6, 2020, 9:55 PM Chris Johns > wrote: > > Hello, > > I would like to discuss BSP Test results early in the release cycle in > the hope > we avoid the last minute issues we encountered with RTEMS 5 a

Re: BSP Test Results

2020-09-06 Thread Joel Sherrill
On Sun, Sep 6, 2020, 9:55 PM Chris Johns wrote: > Hello, > > I would like to discuss BSP Test results early in the release cycle in the > hope > we avoid the last minute issues we encountered with RTEMS 5 and the > "expected" > failure state ticket. > > I would like to update this section ... > >

BSP Test Results

2020-09-06 Thread Chris Johns
Hello, I would like to discuss BSP Test results early in the release cycle in the hope we avoid the last minute issues we encountered with RTEMS 5 and the "expected" failure state ticket. I would like to update this section ... https://docs.rtems.org/branches/master/user/testing/tests.html#expec

Re: Tftp patch to rtems-tools breaks compilation (on ubuntu 18.04 x64)

2020-09-06 Thread Chris Johns
On 7/9/20 10:14 am, Chris Johns wrote: > On 7/9/20 5:01 am, Jiri Gaisler wrote: >> source not found: 'rt/tftpy/__init__.py' in bld(target='', idx=3, >> tg_idx_count=42, meths=['feature_py', 'process_rule', 'process_source'], >> install_path='${PREFIX}/share/rtems/tester', _name='', >> source=['r

Re: Tftp patch to rtems-tools breaks compilation (on ubuntu 18.04 x64)

2020-09-06 Thread Chris Johns
On 7/9/20 5:01 am, Jiri Gaisler wrote: > source not found: 'rt/tftpy/__init__.py' in bld(target='', idx=3, > tg_idx_count=42, meths=['feature_py', 'process_rule', 'process_source'], > install_path='${PREFIX}/share/rtems/tester', _name='', > source=['rt/tftpy/__init__.py', 'rt/tftpy/TftpClient.py

Re: More RISC-V Failures on Master

2020-09-06 Thread Joel Sherrill
On Sun, Sep 6, 2020 at 3:03 PM Joel Sherrill wrote: > > > On Sun, Sep 6, 2020 at 1:27 PM Hesham Almatary < > hesham.almat...@cl.cam.ac.uk> wrote: > >> I sent a patch to fix that earlier but it didn’t make it upstream. Please >> feel free to push it >> >> >> https://lists.rtems.org/pipermail/devel

Re: More RISC-V Failures on Master

2020-09-06 Thread Joel Sherrill
On Sun, Sep 6, 2020 at 1:27 PM Hesham Almatary wrote: > I sent a patch to fix that earlier but it didn’t make it upstream. Please > feel free to push it > > > https://lists.rtems.org/pipermail/devel/2020-May/059773.html > Is this only needed on the master? > > On Sun, Sep 6, 2020 at 7:57 PM Joe

Tftp patch to rtems-tools breaks compilation (on ubuntu 18.04 x64)

2020-09-06 Thread Jiri Gaisler
jiri@office:~/ibm/src/rtems/rtems-tools$ ./waf configure --prefix=/opt/rtems/6 Setting top to   : /home/jiri/ibm/src/rtems/rtems-tools Setting out to   : /home/jiri/ibm/src/rtems/rtems-tools/build Version  : 6.eb36081

Re: dl06 fails to build for RISC-V (griscv bsp)

2020-09-06 Thread Jiri Gaisler
I re-applied your patch and dl06 builds again, but the dl06.exe program fails. I have updated the ticket: https://devel.rtems.org/ticket/4069#no2 On 9/6/20 10:12 AM, Hesham Almatary wrote: > That's the same as [1]. I've seen that error before and (thought I) > fixed it [2], but not sure what ha

Re: More RISC-V Failures on Master

2020-09-06 Thread Hesham Almatary
I sent a patch to fix that earlier but it didn’t make it upstream. Please feel free to push it https://lists.rtems.org/pipermail/devel/2020-May/059773.html On Sun, Sep 6, 2020 at 7:57 PM Joel Sherrill wrote: > Hi > > I see a duplicate symbol error on RISC-V BSPs which must not trip the > dyna

More RISC-V Failures on Master

2020-09-06 Thread Joel Sherrill
Hi I see a duplicate symbol error on RISC-V BSPs which must not trip the dynamic loading section 0 issue. This is the error on multiple RISC-V BSPs with the list below the message: /home/joel/rtems-cron-6/tools/6/lib/gcc/riscv-rtems6/10.2.1/../../../../riscv-rtems6/bin/ld: ./../../lib/libbsp/ris

Re: dl06 fails to build for RISC-V (griscv bsp)

2020-09-06 Thread Eshan Dhawan
The issue here is due to some changes in Newlib. Which caused error in both riscv and arm. The error in ARM is fixed. But I don’t know about Riscv. > On 06-Sep-2020, at 2:43 PM, Hesham Almatary > wrote: > > That's the same as [1]. I've seen that error before and (thought I) > fixed it [2], but

Re: dl06 fails to build for RISC-V (griscv bsp)

2020-09-06 Thread Hesham Almatary
Actually my commit is the latest, so please ignore the last reply. On Sun, 6 Sep 2020 at 09:18, Hesham Almatary wrote: > > I did a git blame, looks like that commit broke it [1]; my fix used to > "continue" if a sym belongs to section 0, but now it returns "false". > > [1] > https://github.com/R

Re: dl06 fails to build for RISC-V (griscv bsp)

2020-09-06 Thread Hesham Almatary
I did a git blame, looks like that commit broke it [1]; my fix used to "continue" if a sym belongs to section 0, but now it returns "false". [1] https://github.com/RTEMS/rtems-tools/commit/ec419a05ee52869a7d5b8712ea8e7a7d74fde096 On Sun, 6 Sep 2020 at 09:12, Hesham Almatary wrote: > > That's th

Re: dl06 fails to build for RISC-V (griscv bsp)

2020-09-06 Thread Hesham Almatary
That's the same as [1]. I've seen that error before and (thought I) fixed it [2], but not sure what has changed since then. [1] https://lists.rtems.org/pipermail/devel/2020-August/061717.html [2] https://github.com/RTEMS/rtems-tools/commit/e6e610d262940b7651157597b6b1406aa806b4d1 On Sun, 6 Sep 2

Re: dl06 fails to build for RISC-V (griscv bsp)

2020-09-06 Thread Chris Johns
On 6/9/20 6:32 am, Jiri Gaisler wrote: > I have updated both RTEMS and RSB to git head, and dl06 now fails to build: > > riscv-rtems6-g++ -march=rv32imafd -mabi=ilp32d -O2 -g -ffunction-sections > -fdata-sections -Wall  -Wl,--gc-sections  -march=rv32imafd -mabi=ilp32d  > -B./../../lib/libbsp