Re: [PATCH 0/1] Adding aio.h to newlib

2020-04-24 Thread Gedare Bloom
OK thanks. My preference is to sit on these 2 patches until after we release rtems5. On Thu, Apr 23, 2020 at 11:21 PM Eshan Dhawan wrote: > > For testing, I followed the instruction in the blog written by @Vaibhav Gupta > last year for applying a patch to newlib > (the blog can be read here: >

Re: [PATCH] Removes build time warning for all the bsps using libtests/dl10 test

2020-04-24 Thread Gedare Bloom
Whenever you fix a warning something is unused by deleting that something, you should first make sure that something isn't supposed to be used. Because that might also be the problem. Check if these 2 functions maybe should be tested, or does dlsym/dlclose get tested elsewhere? On Fri, Apr 24, 202

Re: [PATCH] Removes build time warning for all smp-disabled bsps

2020-04-24 Thread Gedare Bloom
Please generate this patch as -v2 and resend to the mailing list. I'm not sure, but I don't see your patch emails coming through, only your copy-pasted versions where you prepend some additional information. You may want to double-check your git-send-email settings and make sure it is succeeding. Y

[PATCH] Removes build time warning for all the bsps using libtests/dl10 test

2020-04-24 Thread Richi Dubey
Hey, Can someone please check if this patch is correct? The warnings were: log/sparc-leon3.log:../../../../../../rtems/c/src/../../testsuites/libtests/dl10/dl-load.c:109:12: warning: 'dl_call' defined but not used [-Wunused-function] log/sparc-leon3.log:../../../../../../rtems/c/src/../../testsu

Re: [PATCH] Removes build time warning for all smp-disabled bsps

2020-04-24 Thread Richi Dubey
Dear Dr. Bloom, Thanks for your suggestion. Yes, indeed this looks a little bad. Please find the below attached new patch for the same. I have rebuilt the leon3 bsp with this change and the build process was successful without any errors. Also, I have added another patch which I had some doubts o