Re: [PATCH v3] tests for fenv.h functions

2020-03-04 Thread Eshan Dhawan
If you want I would set the case in that manner. On Thu, Mar 5, 2020 at 12:46 PM Eshan Dhawan wrote: > > > On Thu, Mar 5, 2020 at 4:37 AM Gedare Bloom wrote: > >> On Wed, Mar 4, 2020 at 11:12 AM Eshan dhawan >> wrote: >> > >> > --- >> > testsuites/psxtests/psxfenv01/init.c | 72 ++

Re: [PATCH 4/4] Add print statement similar to the original mkimage.

2020-03-04 Thread Amar Takhar
On 2020-03-04 19:43 -0700, Gedare Bloom wrote: > Reviewing on my phone: I see added blank lines, try to avoid unnecessary > whitespace/format changes with functional changes in same commit. Although we > haven't settled in a style, none of the proposed ones use more than 2 blank > lines between glo

Re: [PATCH 2/4] Convert optparse to argparse.

2020-03-04 Thread Amar Takhar
On 2020-03-04 19:37 -0700, Gedare Bloom wrote: > Quick note sort copyright lines??earlier years below later years. Whoops, I know this already I'll fix it thanks. Amar. ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/deve

Re: [PATCH 4/4] Add print statement similar to the original mkimage.

2020-03-04 Thread Gedare Bloom
Reviewing on my phone: I see added blank lines, try to avoid unnecessary whitespace/format changes with functional changes in same commit. Although we haven't settled in a style, none of the proposed ones use more than 2 blank lines between global definitions. On Wed, Mar 4, 2020, 4:10 PM Amar Tak

Re: [PATCH 2/4] Convert optparse to argparse.

2020-03-04 Thread Gedare Bloom
Quick note sort copyright lines earlier years below later years. On Wed, Mar 4, 2020, 4:09 PM Amar Takhar wrote: > * Fix exceptions and print exception message. > * Also add myself to copyright. > --- > misc/tools/mkimage.py | 42 ++ > 1 file changed, 2

Re: [PATCH] Bump RSB to the latest rtems-tools to get mkimage.py

2020-03-04 Thread Amar Takhar
On 2020-03-04 18:02 -0600, Joel Sherrill wrote: > I think this is OK.?? > > I will bump the newlib hash as soon as my patch to newlib is merged. Great, thanks! Amar. ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel

Re: [PATCH] Bump RSB to the latest rtems-tools to get mkimage.py

2020-03-04 Thread Joel Sherrill
I think this is OK. I will bump the newlib hash as soon as my patch to newlib is merged. --joel On Wed, Mar 4, 2020 at 6:01 PM Amar Takhar wrote: > --- > rtems/config/tools/rtems-tools-5-1.cfg | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/rtems/config/tools/rtem

[PATCH] Bump RSB to the latest rtems-tools to get mkimage.py

2020-03-04 Thread Amar Takhar
--- rtems/config/tools/rtems-tools-5-1.cfg | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/rtems/config/tools/rtems-tools-5-1.cfg b/rtems/config/tools/rtems-tools-5-1.cfg index da22b4c..0c67901 100644 --- a/rtems/config/tools/rtems-tools-5-1.cfg +++ b/rtems/config/tools/rt

Re: [PATCH 1/4] Remove EOL whitespace.

2020-03-04 Thread Chris Johns
I am ok for these to be pushed. Thank you for adding this command. It is a big help for hosts that are not Linux. Please consider a change to update the RSB's tool commit reference and checksum as approved. The file is ... https://git.rtems.org/rtems-source-builder/tree/rtems/config/tools/rtems-t

[PATCH 1/4] Remove EOL whitespace.

2020-03-04 Thread Amar Takhar
--- misc/tools/mkimage.py | 42 +- 1 file changed, 21 insertions(+), 21 deletions(-) diff --git a/misc/tools/mkimage.py b/misc/tools/mkimage.py index 39a12a0..2b1524c 100755 --- a/misc/tools/mkimage.py +++ b/misc/tools/mkimage.py @@ -2,28 +2,28 @@ # A qu

[PATCH 2/4] Convert optparse to argparse.

2020-03-04 Thread Amar Takhar
* Fix exceptions and print exception message. * Also add myself to copyright. --- misc/tools/mkimage.py | 42 ++ 1 file changed, 22 insertions(+), 20 deletions(-) diff --git a/misc/tools/mkimage.py b/misc/tools/mkimage.py index 2b1524c..0845ee4 100755 ---

[PATCH 4/4] Add print statement similar to the original mkimage.

2020-03-04 Thread Amar Takhar
This is limited to Python 2.6+ --- misc/tools/mkimage.py | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/misc/tools/mkimage.py b/misc/tools/mkimage.py index 38ed11e..fd75f0a 100755 --- a/misc/tools/mkimage.py +++ b/misc/tools/mkimage.py @@ -27,6 +27,8 @@ # A

[PATCH 3/4] Fix to work under Pyhon 2 and Python 3.

2020-03-04 Thread Amar Takhar
Also changed 'python2' to 'python' in the shebang. --- misc/tools/mkimage.py | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/misc/tools/mkimage.py b/misc/tools/mkimage.py index 0845ee4..38ed11e 100755 --- a/misc/tools/mkimage.py +++ b/misc/tools/mkimage.py @@

Re: [PATCH v3] tests for fenv.h functions

2020-03-04 Thread Gedare Bloom
On Wed, Mar 4, 2020 at 11:12 AM Eshan dhawan wrote: > > --- > testsuites/psxtests/psxfenv01/init.c | 72 ++-- > 1 file changed, 68 insertions(+), 4 deletions(-) > > diff --git a/testsuites/psxtests/psxfenv01/init.c > b/testsuites/psxtests/psxfenv01/init.c > index cdb0fa59

Re: RTEMS Release Notes Generator - GSoC Project

2020-03-04 Thread Chris Johns
On 5/3/20 2:59 am, Denil Verghese wrote: > Thanks, I'll check it out. Great > On Wed, 4 Mar, 2020, 7:54 AM Chris Johns, > wrote: > > On 4/3/20 1:04 pm, Denil Verghese wrote: > > I've read the ticket page at https://devel.rtems.org/ticket/3314, but > it was >

[PATCH] i386/fenv.c: Include fenv.c implementation shared with x86_64, not stub

2020-03-04 Thread Joel Sherrill
--- newlib/libm/machine/i386/fenv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/newlib/libm/machine/i386/fenv.c b/newlib/libm/machine/i386/fenv.c index 8cbee77..1a97f56 100644 --- a/newlib/libm/machine/i386/fenv.c +++ b/newlib/libm/machine/i386/fenv.c @@ -4,4 +4,4 @@ * (c

[PATCH] Fix i386 fenv support

2020-03-04 Thread Joel Sherrill
In removing the symbolic links, I accidentally ended up with the i386 not having an fenv.h implementation. All the files linked to the stub. This patch addresses this. --joel Joel Sherrill (1): i386/fenv.c: Include fenv.c implementation shared with x86_64, not stub newlib/libm/machine/i3

[PATCH v3] tests for fenv.h functions

2020-03-04 Thread Eshan dhawan
--- testsuites/psxtests/psxfenv01/init.c | 72 ++-- 1 file changed, 68 insertions(+), 4 deletions(-) diff --git a/testsuites/psxtests/psxfenv01/init.c b/testsuites/psxtests/psxfenv01/init.c index cdb0fa596e..40c29e4fac 100644 --- a/testsuites/psxtests/psxfenv01/init.c +++

Re: [PATCH v2 1/4] added fesetexeptflag() test to the psxfenv test

2020-03-04 Thread Eshan Dhawan
This is an old patch > On 04-Mar-2020, at 10:11 PM, Gedare Bloom wrote: > > On Tue, Mar 3, 2020 at 12:50 PM Eshan dhawan wrote: >> >> --- >> testsuites/psxtests/psxfenv01/init.c | 36 >> 1 file changed, 31 insertions(+), 5 deletions(-) >> >> diff --git a/testsui

Re: [PATCH v2 4/4] test for fenv.h functions

2020-03-04 Thread Gedare Bloom
On Tue, Mar 3, 2020 at 12:50 PM Eshan dhawan wrote: > > --- > testsuites/psxtests/psxfenv01/init.c | 75 +--- > 1 file changed, 46 insertions(+), 29 deletions(-) > > diff --git a/testsuites/psxtests/psxfenv01/init.c > b/testsuites/psxtests/psxfenv01/init.c > index 4339139

Re: [PATCH v2 2/4] added test for fegetexeptflag and fesetexeptflag

2020-03-04 Thread Gedare Bloom
I see you fixed some of the problems in this patch from the previous patch. Please "squash" the two patches together. Read about git interactive rebase (fixup or squash options) to do this. You should not include in one patch things that are broken and that you fix in another patch in the same se

Re: [PATCH v2 1/4] added fesetexeptflag() test to the psxfenv test

2020-03-04 Thread Gedare Bloom
On Tue, Mar 3, 2020 at 12:50 PM Eshan dhawan wrote: > > --- > testsuites/psxtests/psxfenv01/init.c | 36 > 1 file changed, 31 insertions(+), 5 deletions(-) > > diff --git a/testsuites/psxtests/psxfenv01/init.c > b/testsuites/psxtests/psxfenv01/init.c > index cdb0fa59

Re: RTEMS Release Notes Generator - GSoC Project

2020-03-04 Thread Gedare Bloom
On Wed, Mar 4, 2020 at 8:59 AM Denil Verghese wrote: > > Thanks, I'll check it out. > > On Wed, 4 Mar, 2020, 7:54 AM Chris Johns, wrote: >> >> On 4/3/20 1:04 pm, Denil Verghese wrote: >> > I've read the ticket page at https://devel.rtems.org/ticket/3314, but it >> > was >> > last modified a coup

Re: Introducing myself and HelloWorld completion.

2020-03-04 Thread Gedare Bloom
On Wed, Mar 4, 2020 at 12:41 AM Sebastian Huber wrote: > > On 04/03/2020 06:28, Gedare Bloom wrote: > > On Tue, Mar 3, 2020 at 6:02 PM Denil Verghese wrote: > >> Hi, > >>> > >>> Great. Those are two quite distinct projects. The "Improve the SMP > >>> Scheduler" will require strong C programming s

Re: [PATCH 1/2] Add a pure Python clone of mkimage written by Craig Barker.

2020-03-04 Thread Gedare Bloom
On Wed, Mar 4, 2020 at 8:39 AM Amar Takhar wrote: > > On 2020-03-04 20:02 +1100, Chris Johns wrote: > > > > I am wondering how a user runs just the mkimake.py file once install. The > > rtems-tools repo normally packages a command in a wrapper that has has > > `/usr/bin/env python` and so $PATH et

Re: RTEMS Release Notes Generator - GSoC Project

2020-03-04 Thread Denil Verghese
Thanks, I'll check it out. On Wed, 4 Mar, 2020, 7:54 AM Chris Johns, wrote: > On 4/3/20 1:04 pm, Denil Verghese wrote: > > I've read the ticket page at https://devel.rtems.org/ticket/3314, but > it was > > last modified a couple of years ago. I would like to know if there are > any > > changes o

Re: [PATCH 1/2] Add a pure Python clone of mkimage written by Craig Barker.

2020-03-04 Thread Amar Takhar
On 2020-03-04 20:02 +1100, Chris Johns wrote: > > I am wondering how a user runs just the mkimake.py file once install. The > rtems-tools repo normally packages a command in a wrapper that has has > `/usr/bin/env python` and so $PATH etc works. I added a python2 shebang in the 2nd commit it can b

Re: Device Tree Blob for Beaglebone Black?

2020-03-04 Thread Christian Mauderer
On 04/03/2020 07:07, Sebastian Huber wrote: > On 04/03/2020 05:55, Chris Johns wrote: >>> I think for Boards that normally run a Linux it is a sane approach to >>> just replace the Linux Kernel with a RTEMS binary and otherwise keep the >>> boot process with for example U-Boot. Everything else is a

Re: Device Tree Blob for Beaglebone Black?

2020-03-04 Thread Christian Mauderer
Hello Chris, On 04/03/2020 05:55, Chris Johns wrote: > Sorry about delay in getting back to this. I have been focused on getting the > release into something close to what we want for RC1. No problem. The release is relevant for all of us. > > On 28/2/20 9:48 pm, Christian Mauderer wrote: >> He

Re: Waf Build System Status in RTEMS?

2020-03-04 Thread Hesham Almatary
On Wed, 4 Mar 2020 at 08:55, Sebastian Huber wrote: > > On 25/02/2020 12:54, Sebastian Huber wrote: > > On 25/02/2020 11:00, Hesham Almatary wrote: > >> On Mon, 24 Feb 2020 at 22:50, Chris Johns wrote: > >>> On 21/2/20 11:11 pm, Sebastian Huber wrote: > On 21/02/2020 12:26, Hesham Almatary w

Re: [PATCH 1/2] Add a pure Python clone of mkimage written by Craig Barker.

2020-03-04 Thread Chris Johns
On 4/3/20 4:58 pm, Sebastian Huber wrote: > On 04/03/2020 02:46, Amar Takhar wrote: >> I emailed Craig Barker to ask if he would release his mkimage Python rewrite >> as 2BSD.  He graciously accepted and you can see his work here: >> >>    https://github.com/cmbarker83/pythonmkimage >> >> This is a

Re: Waf Build System Status in RTEMS?

2020-03-04 Thread Sebastian Huber
On 25/02/2020 12:54, Sebastian Huber wrote: On 25/02/2020 11:00, Hesham Almatary wrote: On Mon, 24 Feb 2020 at 22:50, Chris Johns  wrote: On 21/2/20 11:11 pm, Sebastian Huber wrote: On 21/02/2020 12:26, Hesham Almatary wrote: On Fri, 21 Feb 2020 at 11:07, Sebastian Huber    wrote: Hello Hesh