Re: [PATCH v2] Raspberrypi: updated the console interface.

On 28/12/2019 20:03, Niteesh wrote: > I will start working on a patch that uses FDT. Instead of merging this > I create a patch v3 that uses FDT. Shall I remove some files, I will be > heavily using > the imx and other FDT based drivers as a reference. You can remove everything that is no longer u

Re: [PATCH v2] Raspberrypi: updated the console interface.

I will start working on a patch that uses FDT. Instead of merging this I create a patch v3 that uses FDT. Shall I remove some files, I will be heavily using the imx and other FDT based drivers as a reference. On Sun, Dec 29, 2019 at 12:27 AM Christian Mauderer wrote: > On 28/12/2019 19:48, Nitee

Re: [PATCH v2] Raspberrypi: updated the console interface.

On 28/12/2019 19:48, Niteesh wrote: > Is bsp_console_select legacy? And the new way will be by linking > the correct serial device to /dev/console in console_initialization, right? > If so, shall I add one? The function is only called from legacy-console.c. So yes: This function can be removed. Th

Re: [PATCH v2] Raspberrypi: updated the console interface.

On 28/12/2019 19:20, Niteesh wrote: > I am sorry if this question sounds silly, but how can I access the > output_char_fb if it > is marked as static in console-select.c, currently the fb context is in > console-config.c > Should I move the BSP_select_function to console-config? for shall I > remov

Re: [PATCH v2] Raspberrypi: updated the console interface.

Is bsp_console_select legacy? And the new way will be by linking the correct serial device to /dev/console in console_initialization, right? If so, shall I add one? On Sat, Dec 28, 2019 at 11:50 PM Niteesh wrote: > I am sorry if this question sounds silly, but how can I access the > output_char_

Re: [PATCH v2] Raspberrypi: updated the console interface.

I am sorry if this question sounds silly, but how can I access the output_char_fb if it is marked as static in console-select.c, currently the fb context is in console-config.c Should I move the BSP_select_function to console-config? for shall I remove the static qualifier from the function? Curre

Re: [PATCH v2] Raspberrypi: updated the console interface.

On Sat, Dec 28, 2019 at 11:12 PM Christian Mauderer wrote: > On 28/12/2019 17:22, Niteesh wrote: > > I think you misunderstood, I was talking about the casting in the > > rtems_termios_device_handler > > Yes, I misunderstood you there. > > > const rtems_termios_device_handler fbcons_fns = > > { >

Error while building the rtems-libbsd

Hi, While building the rtems-libbsd as described here I was able to successfully configure the waf file as:- waf configure --prefix="/home/ur10/sandbox/rtems/5" --rtems-bsps=arm/beagleboneblack --

Re: [PATCH v2] Raspberrypi: updated the console interface.

On 28/12/2019 17:22, Niteesh wrote: > I think you misunderstood, I was talking about the casting in the > rtems_termios_device_handler Yes, I misunderstood you there. > const rtems_termios_device_handler fbcons_fns = > { >   .first_open = fbcons_open, >   .last_close = fbcons_close, >   .poll_rea

Re: [PATCH v2] Raspberrypi: updated the console interface.

I think you misunderstood, I was talking about the casting in the rtems_termios_device_handler const rtems_termios_device_handler fbcons_fns = { .first_open = fbcons_open, .last_close = fbcons_close, .poll_read = fbcons_inbyte_nonblocking_polled, .write = (void (*)(rtems_termios_device_cont

Re: [PATCH v2] Raspberrypi: updated the console interface.

On 28/12/2019 14:10, G S Niteesh wrote: > The patch updates the older console interface used by the BSP, > to newer one. It also replaces the custom usart(PL011) driver > with arm-pl011. The fb function's signatures where also changed > to accommodate with interface update. > Update #3034 > --- >

Re: [PATCH] Raspberrypi: updated the console interface.

On 28/12/2019 13:41, Niteesh wrote: > On Sat, Dec 28, 2019 at 3:20 PM Christian Mauderer > wrote: > > Missed your question further below in my first mail. > > On 28/12/2019 10:45, Christian Mauderer wrote: > > On 28/12/2019 09:38, Niteesh wrote: > >> I

[PATCH v2] Raspberrypi: updated the console interface.

The patch updates the older console interface used by the BSP, to newer one. It also replaces the custom usart(PL011) driver with arm-pl011. The fb function's signatures where also changed to accommodate with interface update. Update #3034 --- bsps/arm/raspberrypi/console/console-config.c | 62 ++

Re: [PATCH] Raspberrypi: updated the console interface.

On Sat, Dec 28, 2019 at 3:20 PM Christian Mauderer wrote: > Missed your question further below in my first mail. > > On 28/12/2019 10:45, Christian Mauderer wrote: > > On 28/12/2019 09:38, Niteesh wrote: > >> I didn't get any of these warnings, which command did you use? > > > > Just the usual ma

Re: [PATCH] Raspberrypi: updated the console interface.

And I think you can add an "Update #3034" to your commit message: https://devel.rtems.org/ticket/3034 It's a bit hidden but the old driver uses "rtems_termios_open" via the legacy-console.c. You removed that from the build for raspberry. On 28/12/2019 10:50, Christian Mauderer wrote: > Missed yo

Re: Raspberrypi3: Mini UART driver

On 28/12/2019 07:12, Niteesh wrote: > > > On Sat, 28 Dec, 2019, 3:51 AM Christian Mauderer, > wrote: > > On 27/12/2019 19:06, Niteesh wrote: > > Is there something else that I could work on? I am interested in > taking > > part  > > GSOC of 2020. A

Re: [PATCH] Raspberrypi: updated the console interface.

Missed your question further below in my first mail. On 28/12/2019 10:45, Christian Mauderer wrote: > On 28/12/2019 09:38, Niteesh wrote: >> I didn't get any of these warnings, which command did you use? > > Just the usual make in the build directory. I configured with the > following line: > >

Re: [PATCH] Raspberrypi: updated the console interface.

On 28/12/2019 09:38, Niteesh wrote: > I didn't get any of these warnings, which command did you use? Just the usual make in the build directory. I configured with the following line: /home/christian/rtems/rtems-bbb/build/..//libs/rtems/configure --target=arm-rtems5 --prefix=/home/christian/rtems/

Re: [PATCH] Raspberrypi: updated the console interface.

I didn't get any of these warnings, which command did you use? On Sat, Dec 28, 2019 at 3:48 AM Christian Mauderer wrote: > Hello, > > git complained about some whitespaces when applying the patch: > > > git am \[PATCH\]\ Raspberrypi:\ updated\ the\ console\ interface..eml > Applying