[PATCH v3] user: Document patch review process

2019-10-01 Thread Sebastian Huber
--- v2: * Added ticket comments to checklist for patches. * Added checklist for patches step to figure: http://www.plantuml.com/plantuml/uml/dL71Yjim4BthAnwcXuJYXRscXwRG7dhOiEosXq8kMdiSgskDtD4u8NzVUrH8sa0BFGYacVVUwBtPPlMYKnoSivjpcmyYdW-4Sve4JR_SCmBlsJF8vpCqGUWOw0JFxPwRr9CGAqQlJOzC4YY_MuJ6SPZHFSq

[PATCH v2] user: Document patch review process

2019-10-01 Thread Sebastian Huber
--- v2: * Added ticket comments to checklist for patches. * Added checklist for patches step to figure: http://www.plantuml.com/plantuml/uml/dL71Yjim4BthAnwcXuJYXRscXwRG7dhOiEosXq8kMdiSgskDtD4u8NzVUrH8sa0BFGYacVVUwBtPPlMYKnoSivjpcmyYdW-4Sve4JR_SCmBlsJF8vpCqGUWOw0JFxPwRr9CGAqQlJOzC4YY_MuJ6SPZHFSq

[PATCH 1/2] libtest: Add more action events

2019-10-01 Thread Sebastian Huber
This allows more control over the initialization and finalization run. Update #3199. --- cpukit/include/t.h | 6 -- cpukit/libtest/t-test-hash-sha256.c | 4 ++-- cpukit/libtest/t-test-rtems-fds.c | 2 +- cpukit/libtest/t-test-rtems-heap.c | 2 +- cpukit/libtest/t-test-

[PATCH 2/2] ttest01: Check init/final run output

2019-10-01 Thread Sebastian Huber
Update #3199. --- testsuites/libtests/ttest01/init.c | 85 ++ 1 file changed, 85 insertions(+) diff --git a/testsuites/libtests/ttest01/init.c b/testsuites/libtests/ttest01/init.c index cb4ad95829..44ffadf112 100644 --- a/testsuites/libtests/ttest01/init.c +++

Re: [PATCH v2 3/3] ttest01: New test

2019-10-01 Thread Sebastian Huber
On 01/10/2019 23:40, Gedare Bloom wrote: +/* + * SPDX-License-Identifier: BSD-2-Clause + * SPDX-License-Identifier: CC-BY-SA-4.0 + * + * Copyright (C) 2018, 2019 embedded brains GmbH + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provide

Re: [PATCH 2/2] barrier: Remove unfinished sentence

2019-10-01 Thread Joel Sherrill
On Tue, Oct 1, 2019, 5:04 PM Gedare Bloom wrote: > On Tue, Oct 1, 2019 at 11:09 AM Martin Erik Werner > wrote: > > > > Remove the unfinished sentence > > "Since a barrier is, by definition, never immediately [...]" > > and jump directly to > > "The task may wait [forever or for a timeout]" > > i

Re: [PATCH 1/2] barrier: Remove leftover semaphore remnants

2019-10-01 Thread Joel Sherrill
On Tue, Oct 1, 2019, 5:07 PM Gedare Bloom wrote: > On Tue, Oct 1, 2019 at 3:53 PM Gedare Bloom wrote: > > > > On Wed, Sep 4, 2019 at 3:36 PM Martin Erik Werner > > wrote: > > > > > > Remove various incorrect references to "lock" and "obtain" and to an > > > option set which is not part of the b

Re: [PATCH 1/2] barrier: Remove leftover semaphore remnants

2019-10-01 Thread Gedare Bloom
On Tue, Oct 1, 2019 at 3:53 PM Gedare Bloom wrote: > > On Wed, Sep 4, 2019 at 3:36 PM Martin Erik Werner > wrote: > > > > Remove various incorrect references to "lock" and "obtain" and to an > > option set which is not part of the barrier interface. > > > > It looks like the barrier documentation

Re: [PATCH 2/2] barrier: Remove unfinished sentence

2019-10-01 Thread Gedare Bloom
On Tue, Oct 1, 2019 at 11:09 AM Martin Erik Werner wrote: > > Remove the unfinished sentence > "Since a barrier is, by definition, never immediately [...]" > and jump directly to > "The task may wait [forever or for a timeout]" > instead. > > I cannot figure out what the unfinished sentence is sup

Re: [PATCH 1/2] barrier: Remove leftover semaphore remnants

2019-10-01 Thread Gedare Bloom
On Wed, Sep 4, 2019 at 3:36 PM Martin Erik Werner wrote: > > Remove various incorrect references to "lock" and "obtain" and to an > option set which is not part of the barrier interface. > > It looks like the barrier documentation was started based on a copy of > the semaphore documentation and th

Re: [PATCH v2 3/3] ttest01: New test

2019-10-01 Thread Gedare Bloom
On Fri, Mar 22, 2019 at 3:20 AM Sebastian Huber wrote: > > This is an example test using the RTEMS Test Framework. It tests also > the framework itself. > > Add T_FILE_NAME command line define to get rid of the full file path. > This is important to reduce the read-only data of test files and mak

[Resend] [PATCH 0/2] rtems-doc barrier fixes

2019-10-01 Thread Martin Erik Werner
Hi, I'm re-sending this patch set since I received no reply previously (2019-09-04). Martin Erik Werner (2): barrier: Remove leftover semaphore remnants barrier: Remove unfinished sentence c-user/barrier_manager.rst | 45 ++--- 1 file changed, 10 inse

[PATCH 2/2] barrier: Remove unfinished sentence

2019-10-01 Thread Martin Erik Werner
Remove the unfinished sentence "Since a barrier is, by definition, never immediately [...]" and jump directly to "The task may wait [forever or for a timeout]" instead. I cannot figure out what the unfinished sentence is supposed to be - "released"? "passed"? --- c-user/barrier_manager.rst | 7 ++

[PATCH 1/2] barrier: Remove leftover semaphore remnants

2019-10-01 Thread Martin Erik Werner
Remove various incorrect references to "lock" and "obtain" and to an option set which is not part of the barrier interface. It looks like the barrier documentation was started based on a copy of the semaphore documentation and these things are surviving remnants. Also remove an unfinished sentenc

[PATCH 3/3] ttest01: Add test outputs all test cases

2019-10-01 Thread Sebastian Huber
From: Mikail Yayla --- testsuites/libtests/ttest01/test-assert.c | 21 + testsuites/libtests/ttest01/test-checks.c | 2503 + testsuites/libtests/ttest01/test-destructor.c |7 + testsuites/libtests/ttest01/test-eno.c| 20 + testsuites/libtests/ttest

[PATCH 2/3] ttest01: Add more test cases

2019-10-01 Thread Sebastian Huber
Update #3199. --- testsuites/libtests/Makefile.am | 15 + testsuites/libtests/ttest01/init.c| 54 +- testsuites/libtests/ttest01/test-assert.c | 90 + testsuites/libtests/ttest01/test-checks.c | 2914 + testsuites/libtests/ttest01/tes

[PATCH 1/3] libtest: Do all output in test runner

2019-10-01 Thread Sebastian Huber
This ensures that lines are output atomically if they are produced by different other contexts, e.g. interrupts, other processors, other threads. Update #3199. --- cpukit/include/t.h | 2 + cpukit/libtest/t-test.c| 138 ++--- testsuite

[PATCH 1/3] score: Remove superfluous timecounter members

2019-10-01 Thread Sebastian Huber
--- cpukit/include/sys/timetc.h | 4 +++- cpukit/score/src/kern_tc.c| 10 +++--- testsuites/sptests/sptimecounter01/init.c | 4 ++-- 3 files changed, 12 insertions(+), 6 deletions(-) diff --git a/cpukit/include/sys/timetc.h b/cpukit/include/sys/timetc.h index 3

[PATCH 3/3] score: Install timecounter according to quality

2019-10-01 Thread Sebastian Huber
This makes it possible to install higher quality timecounter in plug-and-play systems and helps to override the clock driver provided timecounter in some test scenarios. --- cpukit/score/src/kern_tc.c| 2 + testsuites/sptests/sptimecounter01/init.c | 101 +++--

[PATCH 2/3] score: Remove strange timecounter init step

2019-10-01 Thread Sebastian Huber
The double call of the timecounter get method was added to FreeBSD in 2002 without a comment. It is not clear why this is needed. --- cpukit/score/src/kern_tc.c| 2 +- testsuites/sptests/sptimecounter01/init.c | 12 ++-- 2 files changed, 7 insertions(+), 7 deletions(-) d

Re: [PATCH] user: Document patch review process

2019-10-01 Thread Sebastian Huber
On 01/10/2019 09:22, Chris Johns wrote: On 1/10/19 3:50 pm, Sebastian Huber wrote: On 01/10/2019 01:40, Chris Johns wrote: On 30/9/19 10:45 pm, Sebastian Huber wrote: [...] +* The patch builds.  All RTEMS tests link with this patch. + +* The patch does not introduce new compiler warnings.

[PATCH] dosfs: Fix format with media block sizes > 512

2019-10-01 Thread Sebastian Huber
--- cpukit/libfs/src/dosfs/msdos_format.c | 93 +-- 1 file changed, 46 insertions(+), 47 deletions(-) diff --git a/cpukit/libfs/src/dosfs/msdos_format.c b/cpukit/libfs/src/dosfs/msdos_format.c index 42f1d74575..326040f004 100644 --- a/cpukit/libfs/src/dosfs/msdos_

Re: [PATCH] user: Document patch review process

2019-10-01 Thread Chris Johns
On 1/10/19 3:50 pm, Sebastian Huber wrote: > On 01/10/2019 01:40, Chris Johns wrote: >> On 30/9/19 10:45 pm, Sebastian Huber wrote: >>> --- >>>   images/user/patch-review.png  | Bin 0 -> 57130 bytes >>>   images/user/patch-review.puml |  44 +++ >>>   user/support/contrib.rst