[PATCH 3/4] bsp/xilinx-zynqmp: Stub out Xilinx MPSoC BSP

2019-04-05 Thread Jeff Kubascik
From: Jeff Kubascik Source files were copied from xilinx-zynq. --- bsps/arm/xilinx-zynqmp/README | 13 ++ bsps/arm/xilinx-zynqmp/config/xilinx_zynq.inc | 10 ++ .../xilinx-zynqmp/console/console-config.c| 62 bsps/arm/xilinx-zynqmp/headers.am | 15 ++

[PATCH 4/4] bsp/xilinx-zynqmp: Implement Ultra96 target

2019-04-05 Thread Jeff Kubascik
From: Jeff Kubascik Modifications to get xilinx-zynqmp BSP working on an Ultra96 board. --- bsps/arm/xilinx-zynqmp/README | 43 -- .../{xilinx_zynq.inc => xilinx_zynqmp.inc}| 2 +- .../config/xilinx_zynqmp_ultra96.cfg | 1 + .../xilinx-zynqmp/console/console

[PATCH 0/4] Xilinx Zynq UltraScale+ MPSoC BSP

2019-04-05 Thread Jeff Kubascik
From: Jeff Kubascik This set of patches creates a new BSP layer for the Xilinx Zynq UltraScale+ MPSoC. The first two patches move the zynq-uart driver into a common directory, so that both the xilinx-zynq and xilinx-zynqmp BSPs can use it. The third patch copies the xilinx-zynq BSP layer to xil

[PATCH 2/4] bsp/zynq-uart: Move Zynq UART driver to shared directory

2019-04-05 Thread Jeff Kubascik
From: Jeff Kubascik This driver will be shared with the xilinx-zynqmp BSP. --- bsps/arm/{xilinx-zynq => }/include/bsp/zynq-uart-regs.h | 0 bsps/arm/{xilinx-zynq => }/include/bsp/zynq-uart.h | 0 bsps/arm/{xilinx-zynq/console => shared/serial}/zynq-uart.c | 0 bsps/arm/xilinx-zynq/h

[PATCH 1/4] bsp/zynq-uart: Remove zynq_uart_instances from header

2019-04-05 Thread Jeff Kubascik
From: Jeff Kubascik This variable is BSP specific and should be removed from the driver header file. --- bsps/arm/xilinx-zynq/console/debug-console.c | 2 ++ bsps/arm/xilinx-zynq/include/bsp/zynq-uart.h | 4 +--- bsps/arm/xilinx-zynq/start/bspreset.c| 2 ++ 3 files changed, 5 insertions(

Doxygen Files Issues

2019-04-05 Thread Joel Sherrill
Hi Poking around at the generated Doxygen, it looks like the Files> tab has a lot of structure but content seems to be missing in many of the categories. Is this from not processing C files? --joel ___ devel mailing list devel@rtems.org http://lists.rte

Doxygen Related Pages Issues

2019-04-05 Thread Joel Sherrill
Hi In poking at the generated RTEMS Doxygen, I think the Related Pages needs attention https://docs.rtems.org/doxygen/branches/master/pages.html The first 2/3 of what's listed is categorized wrong to show up here: SAM V71 Xplained Ultra - Board "SAM V71 Xplained Ultra - Board informations" "

Re: [PATCH] Remove superfluous run-time check

2019-04-05 Thread Joel Sherrill
Are you sure it can't be NULL when POSIX is disabled? The historical case where it was NULL was when you disabled an API. If it truly can't be NULL now, it would be good to see comments that explain why it can't be NULL. On Fri, Apr 5, 2019 at 3:00 AM Sebastian Huber < sebastian.hu...@embedded-br

[PATCH] Remove superfluous run-time check

2019-04-05 Thread Sebastian Huber
The _Objects_Information_table[ the_api ] is never NULL for a valid API index. --- cpukit/posix/src/killinfo.c | 8 +--- cpukit/score/src/threaditerate.c | 5 + 2 files changed, 2 insertions(+), 11 deletions(-) diff --git a/cpukit/posix/src/killinfo.c b/cpukit/posix/src/killinfo.c in

Re: Doxygen @param and [in], [out] or [in,out]?

2019-04-05 Thread Sebastian Huber
On 13/03/2019 07:55, Sebastian Huber wrote: On 28/02/2019 15:52, Sebastian Huber wrote: Hello, we agreed to use @param for function parameter documentation: https://docs.rtems.org/branches/master/eng/coding-doxygen.html#doxygen-best-practices Do we want to use [in], [out] or [in,out] as we

Re: Add const Keyword to some function parameters in chainimpl.h

2019-04-05 Thread Sebastian Huber
On 05/04/2019 08:51, Andreas wrote: Hi there, while reviewing the doxygen documentation in this file I found some instances where I think the function parameters should be made constant. Bellow my suggested changes: commit 9fc61307be4f21039b7cd4553099e29e5fd5e456 (HEAD) Author: Andreas D

[PATCH 2/3] rtems: Add rtems_scheduler_get_processor()

2019-04-05 Thread Sebastian Huber
Add rtems_scheduler_get_processor() as a replacement for rtems_get_current_processor(). The rtems_get_current_processor() is a bit orphaned. Adopt it by the Scheduler Manager. This is in line with the glibc sched_getcpu() function. Deprecate rtems_get_current_processor(). Update #3731. --- bsps/

[PATCH 1/2] c-user: Document rtems_scheduler_get_processor()

2019-04-05 Thread Sebastian Huber
Close #3731. --- c-user/scheduling_concepts.rst| 31 c-user/symmetric_multiprocessing_services.rst | 35 --- 2 files changed, 31 insertions(+), 35 deletions(-) diff --git a/c-user/scheduling_concepts.rst b/c-user/scheduling_concepts

[PATCH 1/3] score: Add RTEMS_CONST

2019-04-05 Thread Sebastian Huber
Close #3734. --- cpukit/include/rtems/score/basedefs.h | 11 +++ 1 file changed, 11 insertions(+) diff --git a/cpukit/include/rtems/score/basedefs.h b/cpukit/include/rtems/score/basedefs.h index 770865bb80..8babc0a448 100644 --- a/cpukit/include/rtems/score/basedefs.h +++ b/cpukit/includ

[PATCH 3/3] rtems: Add rtems_scheduler_get_processor_maximum()

2019-04-05 Thread Sebastian Huber
Add rtems_scheduler_get_processor_maximum() as a replacement for rtems_get_processor_count(). The rtems_get_processor_count() is a bit orphaned. Adopt it by the Scheduler Manager. The count is also misleading, since the processor set may have gaps and the actual count of online processors may be le

[PATCH 2/2] c-user: rtems_scheduler_get_processor_maximum()

2019-04-05 Thread Sebastian Huber
Close #3732. --- c-user/scheduling_concepts.rst| 36 ++ c-user/symmetric_multiprocessing_services.rst | 43 --- 2 files changed, 36 insertions(+), 43 deletions(-) diff --git a/c-user/scheduling_concepts.rst b/c-user/scheduling_concepts.r