Re: Inlined code

On 06/08/2018 16:12, Christian Mauderer wrote: > Am 06.08.2018 um 07:31 schrieb Chris Johns: >> On 06/08/2018 10:51, Chris Johns wrote: >>> On 05/08/2018 19:39, Christian Mauderer wrote: Am 05.08.2018 um 04:00 schrieb Chris Johns: > Hi, > > I have been working on migrating covoar i

Re: [PATCH] rfs: Remove erroneous call of rtems_disk_release()

Hello Chris, this needs a back port to 4.11 and 4.10. -- Sebastian Huber, embedded brains GmbH Address : Dornierstr. 4, D-82178 Puchheim, Germany Phone : +49 89 189 47 41-16 Fax : +49 89 189 47 41-09 E-Mail : sebastian.hu...@embedded-brains.de PGP : Public key available on request.

[PATCH] rfs: Remove erroneous call of rtems_disk_release()

The function rtems_rfs_buffer_sync() erroneously calls rtems_disk_release(). This screws up the reference counting of the disk. Update #3484. --- cpukit/libfs/src/rfs/rtems-rfs-buffer.c | 1 - 1 file changed, 1 deletion(-) diff --git a/cpukit/libfs/src/rfs/rtems-rfs-buffer.c b/cpukit/libfs/src/

Re: Inlined code

Am 06.08.2018 um 07:31 schrieb Chris Johns: > On 06/08/2018 10:51, Chris Johns wrote: >> On 05/08/2018 19:39, Christian Mauderer wrote: >>> Am 05.08.2018 um 04:00 schrieb Chris Johns: Hi, I have been working on migrating covoar in the rtems-tools repo to DWARF. The goal is

Re: [PATCH] libbsd.txt: Update version info and manpage links.

On 06/08/18 07:44, Christian Mauderer wrote: The information is clearly outdated. This patch updates it to the latest release. Looks good. Please check in. -- Sebastian Huber, embedded brains GmbH Address : Dornierstr. 4, D-82178 Puchheim, Germany Phone : +49 89 189 47 41-16 Fax : +49 8

Re: Inlined code

On 06/08/2018 15:30, Sebastian Huber wrote: > Hello Chris, > > this looks like a very interesting tool. The justification for an inline > function must be done case by case. I agree. I think a workable pattern will appear and my hope is this tool can be taught what is OK and what is not. I hope

[PATCH] libbsd.txt: Update version info and manpage links.

The information is clearly outdated. This patch updates it to the latest release. --- libbsd.txt | 50 -- 1 file changed, 28 insertions(+), 22 deletions(-) diff --git a/libbsd.txt b/libbsd.txt index c7a90f64..7945b6d1 100644 --- a/libbsd.txt +++ b/l

Re: Inlined code

On 06/08/2018 10:51, Chris Johns wrote: > On 05/08/2018 19:39, Christian Mauderer wrote: >> Am 05.08.2018 um 04:00 schrieb Chris Johns: >>> Hi, >>> >>> I have been working on migrating covoar in the rtems-tools repo to DWARF. >>> The >>> goal is remove objdump parsing and to get accurate details a

Re: Inlined code

Hello Chris, this looks like a very interesting tool. The justification for an inline function must be done case by case. On 05/08/18 04:00, Chris Johns wrote: inlined repeats : 19172 16 __sprint_r This is a small function. GCC decided that it is worth inlining. With -O2 GCC doesn't ca

Re: Inlined code

On 05/08/2018 19:39, Christian Mauderer wrote: > Am 05.08.2018 um 04:00 schrieb Chris Johns: >> Hi, >> >> I have been working on migrating covoar in the rtems-tools repo to DWARF. The >> goal is remove objdump parsing and to get accurate details about the >> functions >> being covered. This is an

[PATCH 4/5] linkers/exeinfo: Add an inlines report and DWARF data dump.

--- linkers/rtems-exeinfo.cpp | 133 -- 1 file changed, 130 insertions(+), 3 deletions(-) diff --git a/linkers/rtems-exeinfo.cpp b/linkers/rtems-exeinfo.cpp index 4fc5f00..f42cba1 100644 --- a/linkers/rtems-exeinfo.cpp +++ b/linkers/rtems-exeinfo.cpp @@

[PATCH 5/5] tester/covoar: Integrate DWARF function data.

Use DAWRF function data to create the executable coverage maps. Integrate the existing objdump processing with this data. - Refactor CoverageMapBase to have the address ranges and address info as separate objects. Move the to address info into a vector. Add support for multiple address range

[PATCH 2/5] rtemstoolkit/elf-symbols: Add the symbol types as an enum.

This can be used by applications to filter the symbols by type. --- rtemstoolkit/rld-symbols.h | 21 + 1 file changed, 21 insertions(+) diff --git a/rtemstoolkit/rld-symbols.h b/rtemstoolkit/rld-symbols.h index 28d3cab..c3035c4 100644 --- a/rtemstoolkit/rld-symbols.h +++ b/rte

[PATCH] DWARF and Coverage Integration

Hello, This patch series includes all my changes so covoar can use DWARF derived function data when creating the coverage maps. Using DWARF data means there are now non-continous ranges and CoverageMapBase has been updated to cleanly handle ranges. DWARF data also gives us more detail about the

[PATCH 3/5] rtemstoolkit/dwarf: C++ object relates fixes and a dump report.

- Various C++ object fixes that improve stability where data from libdwarf is moving between object instances. - Functions now provide better detail with inlined functions picking up attributes from an abstrtact DIE. - Dump to a provide stream not stdout. --- rtemstoolkit/rld-dwarf.cpp | 504 +

[PATCH 1/5] rtemstoolkit: Various coverity related fixes.

--- rtemstoolkit/rld-elf.cpp | 1 + rtemstoolkit/rld-process.cpp | 21 ++--- rtemstoolkit/rld-rtems.cpp | 1 - 3 files changed, 19 insertions(+), 4 deletions(-) diff --git a/rtemstoolkit/rld-elf.cpp b/rtemstoolkit/rld-elf.cpp index ace3967..231f2bf 100644 --- a/rtemstoolki

Re: Version of FreeBSD for libbsd

On Sun, Aug 5, 2018, 3:25 PM Christian Mauderer wrote: > Am 05.08.2018 um 19:21 schrieb Joel Sherrill: > > > > > > On Sun, Aug 5, 2018, 8:59 AM Christian Mauderer > > wrote: > > > > Am 03.08.2018 um 19:30 schrieb Joel Sherrill: > > > Hi > > > > > > libb

Re: [PATCH v2] Coverage: Add support to generate separate reports for each symbol-set

ping :) On 3 August 2018 at 03:15, Vijay Kumar Banerjee wrote: > Hello, > > If you find some time, please do a final review of this patch and provide > suggestions if it's not mergeable yet :) > > There are only three days left, I seek some advice on the wrapup work on > coverage > analysis . Th

Re: Version of FreeBSD for libbsd

Am 05.08.2018 um 19:21 schrieb Joel Sherrill: > > > On Sun, Aug 5, 2018, 8:59 AM Christian Mauderer > wrote: > > Am 03.08.2018 um 19:30 schrieb Joel Sherrill: > > Hi > > > > libbsd.txt says this is based on FreeBSD 9.2 but I thought it > > had been

Re: Version of FreeBSD for libbsd

On Sun, Aug 5, 2018, 8:59 AM Christian Mauderer wrote: > Am 03.08.2018 um 19:30 schrieb Joel Sherrill: > > Hi > > > > libbsd.txt says this is based on FreeBSD 9.2 but I thought it > > had been updated past that. > > > > Also how could I have figured this out otherwise? > > > > If it matters, ther

Re: Version of FreeBSD for libbsd

Am 03.08.2018 um 19:30 schrieb Joel Sherrill: > Hi > > libbsd.txt says this is based on FreeBSD 9.2 but I thought it > had been updated past that. > > Also how could I have figured this out otherwise? > > If it matters, there are also man pages references to FreeBSD 9.2. > > And is the Changes

Re: Inlined code

Am 05.08.2018 um 04:00 schrieb Chris Johns: > Hi, > > I have been working on migrating covoar in the rtems-tools repo to DWARF. The > goal is remove objdump parsing and to get accurate details about the functions > being covered. This is an unfunded task. > > The work has resulted in a close exam