Re: [PATCH 2/4] covoar: Use DWARF to map addresses to source files and lines.

2018-05-05 Thread Chris Johns
On 6/5/18 9:49 am, Chris Johns wrote: On 6/5/18 7:54 am, Vijay Kumar Banerjee wrote: On 6 May 2018 at 03:05, Chris Johns mailto:chr...@rtems.org>> wrote: Could you please check covoar’s wscript has the libdwarf path added? the path to elftoolchain/libdwarf is not added in covoar Thanks

Re: [PATCH 2/4] covoar: Use DWARF to map addresses to source files and lines.

2018-05-05 Thread Chris Johns
On 6/5/18 7:54 am, Vijay Kumar Banerjee wrote: > On 6 May 2018 at 03:05, Chris Johns > > wrote: > > Could you please check covoar’s wscript has the libdwarf path added? > > the path to elftoolchain/libdwarf is not added in covoar  > Thanks. I am on FreeBSD and it u

Re: [PATCH 2/4] covoar: Use DWARF to map addresses to source files and lines.

2018-05-05 Thread Vijay Kumar Banerjee
On 6 May 2018 at 03:05, Chris Johns wrote: > > On 6 May 2018, at 7:04 am, Vijay Kumar Banerjee > wrote: > > > On 6 May 2018 at 02:25, Cillian O'Donnell wrote: > >> >> >> On 5 May 2018 at 21:12, Chris Johns wrote: >> >>> >>> >>> > On 6 May 2018, at 2:44 am, Joel Sherrill wrote: >>> > >>> > Loo

Re: [PATCH 2/4] covoar: Use DWARF to map addresses to source files and lines.

2018-05-05 Thread Chris Johns
> On 6 May 2018, at 7:04 am, Vijay Kumar Banerjee > wrote: > > >> On 6 May 2018 at 02:25, Cillian O'Donnell wrote: >> >> >>> On 5 May 2018 at 21:12, Chris Johns wrote: >>> >>> >>> > On 6 May 2018, at 2:44 am, Joel Sherrill wrote: >>> > >>> > Looks similar to Cillian's failure. Chris wi

Re: [PATCH 2/4] covoar: Use DWARF to map addresses to source files and lines.

2018-05-05 Thread Vijay Kumar Banerjee
On 6 May 2018 at 02:25, Cillian O'Donnell wrote: > > > On 5 May 2018 at 21:12, Chris Johns wrote: > >> >> >> > On 6 May 2018, at 2:44 am, Joel Sherrill wrote: >> > >> > Looks similar to Cillian's failure. Chris will have to show me where >> libdwarf comes from. It needs to be supplied with RTEM

Re: [PATCH 2/4] covoar: Use DWARF to map addresses to source files and lines.

2018-05-05 Thread Cillian O'Donnell
On 5 May 2018 at 21:12, Chris Johns wrote: > > > > On 6 May 2018, at 2:44 am, Joel Sherrill wrote: > > > > Looks similar to Cillian's failure. Chris will have to show me where > libdwarf comes from. It needs to be supplied with RTEMS tools for > consistency. > > You need to apply the patches aga

Re: [PATCH 2/4] covoar: Use DWARF to map addresses to source files and lines.

2018-05-05 Thread Chris Johns
> On 6 May 2018, at 2:44 am, Joel Sherrill wrote: > > Looks similar to Cillian's failure. Chris will have to show me where libdwarf > comes from. It needs to be supplied with RTEMS tools for consistency. You need to apply the patches against master. I added libdwarf to master the other day.

Re: [PATCH 2/4] covoar: Use DWARF to map addresses to source files and lines.

2018-05-05 Thread Joel Sherrill
Looks similar to Cillian's failure. Chris will have to show me where libdwarf comes from. It needs to be supplied with RTEMS tools for consistency. On Sat, May 5, 2018, 11:20 AM Vijay Kumar Banerjee wrote: > In file included from ../rtemstoolkit/rld-dwarf.h:29:0, > from ../teste

Re: [PATCH 2/4] covoar: Use DWARF to map addresses to source files and lines.

2018-05-05 Thread Vijay Kumar Banerjee
In file included from ../rtemstoolkit/rld-dwarf.h:29:0, from ../tester/covoar/ExecutableInfo.h:14, from ../tester/covoar/DesiredSymbols.h:17, from ../tester/covoar/app_common.h:11, from ../tester/covoar/app_common.cc:40: ../rtemsto

Re: [PATCH 2/4] covoar: Use DWARF to map addresses to source files and lines.

2018-05-05 Thread Joel Sherrill
On Sat, May 5, 2018, 10:57 AM Vijay Kumar Banerjee wrote: > Hello, > > I'm getting this build failure after applying this patch > > --- > Build failed > -> task in 'ccovoar' failed with exit status 1: > {task 140086064254560: cxx app_common.cc -> app_common.cc.1.o} > ['/usr/bin/g++', '-std=c++11

Re: [PATCH 2/4] covoar: Use DWARF to map addresses to source files and lines.

2018-05-05 Thread Vijay Kumar Banerjee
Hello, I'm getting this build failure after applying this patch --- Build failed -> task in 'ccovoar' failed with exit status 1: {task 140086064254560: cxx app_common.cc -> app_common.cc.1.o} ['/usr/bin/g++', '-std=c++11', '-O2', '-g', '-Itester/covoar', '-I../tester/covoar', '-Irtemstoolkit', '

Re: [PATCH] Add DWARF support to rtemstoolkit and use it in covoar

2018-05-05 Thread Cillian O'Donnell
Hi Chris, Getting some build errors here. It complains about dwarf.h and libdwarf.h so theres 2 packages that I can get them from but both end up producing some problems. 'Elf' has a previous declaration in one and missing typedef for the other. Is there a particular version of these libraries tha

Re: [PATCH] Add DWARF support to rtemstoolkit and use it in covoar

2018-05-05 Thread Joel Sherrill
I am unable to test this this weekend and maybe not into next week. It all looks good but hopefully Cillian and Vijay can test it quickly. I expect this should speed up covoar runs noticeably. On Sat, May 5, 2018, 3:41 AM Chris Johns wrote: > Hi > > The patch series adds a DWARF framework to th

Re: [PATCH 4/4] covoar: Control the RLD verbose level from the -v option.

2018-05-05 Thread Joel Sherrill
Seems obvious. Push it. On Sat, May 5, 2018, 3:41 AM Chris Johns wrote: > --- > tester/covoar/covoar.cc | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/tester/covoar/covoar.cc b/tester/covoar/covoar.cc > index 09c86c2..5bed98f 100644 > --- a/tester/covoar/covoar.cc >

[PATCH 3/4] covoar: Refactor DesiredSymbols.cc to C++11.

2018-05-05 Thread Chris Johns
--- tester/covoar/DesiredSymbols.cc | 499 +--- 1 file changed, 210 insertions(+), 289 deletions(-) diff --git a/tester/covoar/DesiredSymbols.cc b/tester/covoar/DesiredSymbols.cc index 79ee78d..550ffc1 100644 --- a/tester/covoar/DesiredSymbols.cc +++ b/tester/c

[PATCH 4/4] covoar: Control the RLD verbose level from the -v option.

2018-05-05 Thread Chris Johns
--- tester/covoar/covoar.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tester/covoar/covoar.cc b/tester/covoar/covoar.cc index 09c86c2..5bed98f 100644 --- a/tester/covoar/covoar.cc +++ b/tester/covoar/covoar.cc @@ -227,7 +227,8 @@ int main( case 'S': symbolSet

[PATCH] Add DWARF support to rtemstoolkit and use it in covoar

2018-05-05 Thread Chris Johns
Hi The patch series adds a DWARF framework to the rtemstoolkit to access the source file and line given an address in an executable. This allows us to remove exec'ing addr2line. The patches build and the source line details are loaded from the DWARF debug info. I however do not have any coverage

[PATCH 2/4] covoar: Use DWARF to map addresses to source files and lines.

2018-05-05 Thread Chris Johns
--- tester/covoar/DesiredSymbols.cc | 122 ++-- tester/covoar/ExecutableInfo.cc | 80 +- tester/covoar/ExecutableInfo.h | 41 +++--- tester/covoar/covoar.cc | 2 +- tester/covoar/wscript | 2 +- 5 files ch

[PATCH 1/4] rtemstoolkit: Add libdwarf C++ interface.

2018-05-05 Thread Chris Johns
Provide a C++ interface to libdwarf to: - Manage DWARF debug data - Manage CU - Manage DIE - Handle CU line addresses - Handle CU source files Update #3417 --- rtemstoolkit/rld-dwarf-types.h | 57 +++ rtemstoolkit/rld-dwarf.cpp | 840 + rtemstoolk