[PATCH 12/12] pc386/include/edid.h: Fix macro name to use _ not -

2018-03-15 Thread Joel Sherrill
Closes #3349. --- bsps/i386/pc386/include/edid.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/bsps/i386/pc386/include/edid.h b/bsps/i386/pc386/include/edid.h index 836294d..1653087 100644 --- a/bsps/i386/pc386/include/edid.h +++ b/bsps/i386/pc386/include/edid.h @@ -376,8

[PATCH 05/12] lm32_evr/include/bsp.h: Remove definition of BSP_DIRTY_MEMORY to eliminate warning

2018-03-15 Thread Joel Sherrill
--- bsps/lm32/lm32_evr/include/bsp.h | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/bsps/lm32/lm32_evr/include/bsp.h b/bsps/lm32/lm32_evr/include/bsp.h index 7c3ac84..4f6c9ee 100644 --- a/bsps/lm32/lm32_evr/include/bsp.h +++ b/bsps/lm32/lm32_evr/include/bsp.h @@ -39

[PATCH 10/12] mvme5500/include/bsp/VMEConfig.h: Remove spaces after \ and remove tabs

2018-03-15 Thread Joel Sherrill
--- bsps/powerpc/mvme5500/include/bsp/VMEConfig.h | 30 +-- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/bsps/powerpc/mvme5500/include/bsp/VMEConfig.h b/bsps/powerpc/mvme5500/include/bsp/VMEConfig.h index ecc5789..a5b43df 100644 --- a/bsps/powerpc/mvme55

[PATCH 09/12] bsp/arm-a8core-start.h: Add void return type to fix warning

2018-03-15 Thread Joel Sherrill
--- bsps/arm/include/bsp/arm-a8core-start.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/bsps/arm/include/bsp/arm-a8core-start.h b/bsps/arm/include/bsp/arm-a8core-start.h index 416f282..08311b4 100644 --- a/bsps/arm/include/bsp/arm-a8core-start.h +++ b/bsps/arm/include/

[PATCH 11/12] beatnik/include/bsp.h: Remove extra quotes in macros

2018-03-15 Thread Joel Sherrill
Closes #3348. --- bsps/powerpc/beatnik/include/bsp.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/bsps/powerpc/beatnik/include/bsp.h b/bsps/powerpc/beatnik/include/bsp.h index e980f1a..2ed827e 100644 --- a/bsps/powerpc/beatnik/include/bsp.h +++ b/bsps/powerpc/beatni

[PATCH 08/12] rtems/bfin/bf533.h: Eliminate redefinition warning and add sanity check

2018-03-15 Thread Joel Sherrill
Closes #3346. --- cpukit/score/cpu/bfin/include/rtems/bfin/bf533.h | 9 + 1 file changed, 9 insertions(+) diff --git a/cpukit/score/cpu/bfin/include/rtems/bfin/bf533.h b/cpukit/score/cpu/bfin/include/rtems/bfin/bf533.h index 682aad4..2b2f97c 100644 --- a/cpukit/score/cpu/bfin/include/rte

[PATCH 07/12] mvme3100/include/bsp.h: Remove extra quotes in macros

2018-03-15 Thread Joel Sherrill
Closes #3345. --- bsps/powerpc/mvme3100/include/bsp.h | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/bsps/powerpc/mvme3100/include/bsp.h b/bsps/powerpc/mvme3100/include/bsp.h index 3fbfcb3..d078d08 100644 --- a/bsps/powerpc/mvme3100/include/bsp.h +++ b/bsps/power

[PATCH 03/12] bsps/arm/gdbarmsim/include/bsp.h: Fix warning

2018-03-15 Thread Joel Sherrill
--- bsps/arm/gdbarmsim/include/bsp.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/bsps/arm/gdbarmsim/include/bsp.h b/bsps/arm/gdbarmsim/include/bsp.h index 798fa95..8811d5a 100644 --- a/bsps/arm/gdbarmsim/include/bsp.h +++ b/bsps/arm/gdbarmsim/include/bsp.h @@ -47,11 +47,

[PATCH 06/12] mcf5272.h: Fix duplicate defintions for INT3

2018-03-15 Thread Joel Sherrill
Closes #3344. --- bsps/m68k/include/mcf5272/mcf5272.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/bsps/m68k/include/mcf5272/mcf5272.h b/bsps/m68k/include/mcf5272/mcf5272.h index 37dae92..c1b5948 100644 --- a/bsps/m68k/include/mcf5272/mcf5272.h +++ b/bsps/m68k/include

[PATCH 04/12] bsps/arm/gdbarmsim/include/bsp.h: Fix warning

2018-03-15 Thread Joel Sherrill
--- bsps/arm/gdbarmsim/include/bsp.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/bsps/arm/gdbarmsim/include/bsp.h b/bsps/arm/gdbarmsim/include/bsp.h index 8811d5a..eaa06fc 100644 --- a/bsps/arm/gdbarmsim/include/bsp.h +++ b/bsps/arm/gdbarmsim/include/bsp.h @@ -57,9 +5

[PATCH 01/12] mcf5206elite/include/ds1307.h: Fix extra tokens at end of #endif warning

2018-03-15 Thread Joel Sherrill
--- bsps/m68k/mcf5206elite/include/ds1307.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bsps/m68k/mcf5206elite/include/ds1307.h b/bsps/m68k/mcf5206elite/include/ds1307.h index 8e5636a..ee7993c 100644 --- a/bsps/m68k/mcf5206elite/include/ds1307.h +++ b/bsps/m68k/mcf5206elit

[PATCH 02/12] bsps/sh/gensh1/include/bsp.h: Fix redefined warning

2018-03-15 Thread Joel Sherrill
--- bsps/sh/gensh1/include/bsp.h | 13 - 1 file changed, 13 deletions(-) diff --git a/bsps/sh/gensh1/include/bsp.h b/bsps/sh/gensh1/include/bsp.h index 2c0da4b..f3f7c02 100644 --- a/bsps/sh/gensh1/include/bsp.h +++ b/bsps/sh/gensh1/include/bsp.h @@ -56,19 +56,6 @@ extern void *CPU_Int

[PATCH 00/12] Warning Patches

2018-03-15 Thread Joel Sherrill
Hi You likely noticed the flurry of tickets for warnings. If I assigned one to you please fix it. I am fixing most of them. This is patch series makes a dent in the warnings and closes some tickets I filed. --joel Joel Sherrill (12): mcf5206elite/include/ds1307.h: Fix extra tokens at end of

Fwd: Blog post about gcc 8 usability improvements

2018-03-15 Thread Joel Sherrill
I doubt everyone will see this so am passing along. -- Forwarded message -- From: David Malcolm Date: Thu, Mar 15, 2018 at 12:54 PM Subject: Blog post about gcc 8 usability improvements To: g...@gcc.gnu.org Sorry for the shameless self-promotion, but I've written up the work I'v

Re: [PATCH] Added Getentropy() support to beagle BSP

2018-03-15 Thread Gedare Bloom
On Thu, Mar 15, 2018 at 7:00 AM, Udit agarwal wrote: > > > On Thu, Mar 15, 2018 at 2:38 PM, Sebastian Huber > wrote: >> >> On 15/03/18 09:20, Udit agarwal wrote: >>> >>> Also, will it be ok to keep atsam_trng_mutex even after user has finished >>> using getentropy() i.e when we don't use destroy(

Re: Improve coverage analysis toolset

2018-03-15 Thread Cillian O'Donnell
On 15 March 2018 at 12:26, Vijay Kumar Banerjee wrote: > It runs with a bunch of errors . I have attached the log file > Ok, I'm guessing you didn't set up Couverture-Qemu (special version of qemu designed for generating extra trace data for coverage analysis). That's what those errors are about

Re: Improve coverage analysis toolset

2018-03-15 Thread Vijay Kumar Banerjee
It runs with a bunch of errors . I have attached the log file -- vijay On 15 March 2018 at 16:58, Cillian O'Donnell wrote: > Looks good. If you run the samples without coverage is everything ok? > > So removing --coverage and tacking on /samples > > $HOME/development/rtems-tools/tester/rtems-t

Re: Improve coverage analysis toolset

2018-03-15 Thread Cillian O'Donnell
Looks good. If you run the samples without coverage is everything ok? So removing --coverage and tacking on /samples $HOME/development/rtems-tools/tester/rtems-test --rtems-bsp=leon3-qemu --log=log-leon3.log --rtems-tools=$HOME/development/rtems/5 --rtems-builddir=$HOME/development/rtems/kernel/l

Re: [PATCH] Added Getentropy() support to beagle BSP

2018-03-15 Thread Udit agarwal
On Thu, Mar 15, 2018 at 2:38 PM, Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > On 15/03/18 09:20, Udit agarwal wrote: > >> Also, will it be ok to keep atsam_trng_mutex even after user has finished >> using getentropy() i.e when we don't use destroy(&atsam_trng_mutex) at all? >> >

Re: Improve coverage analysis toolset

2018-03-15 Thread Vijay Kumar Banerjee
I have attached the output of the ls of that directory -- vijay On 15 March 2018 at 15:52, Cillian O'Donnell wrote: > > > On 15 March 2018 at 03:58, Vijay Kumar Banerjee > wrote: > >> >> hello , >> >> as told by Joel , I started this thread to further discuss the coverage >> analysis toolset .

Re: Improve coverage analysis toolset

2018-03-15 Thread Cillian O'Donnell
On 15 March 2018 at 03:58, Vijay Kumar Banerjee wrote: > > hello , > > as told by Joel , I started this thread to further discuss the coverage > analysis toolset . > > Current status is , I'm trying to builld and run rtems-test from the > coverage-merge branch of the previous GSoC student Cillian

Issues with Merging coverage with RTEMS Tester.

2018-03-15 Thread Cillian O'Donnell
Alright so last time we looked at this the major issues were: Covoars reliance on external tools that would cause portability issues. Those were nm (which I got rid of but the fix is still only on my github, I'll submit the patch when everything's rebased with current rtems-tools master and I can

Re: [PATCH] Added Getentropy() support to beagle BSP

2018-03-15 Thread Sebastian Huber
On 15/03/18 09:20, Udit agarwal wrote: Also, will it be ok to keep atsam_trng_mutex even after user has finished using getentropy() i.e when we don't use destroy(&atsam_trng_mutex) at all? Why do you want to destroy the mutex? -- Sebastian Huber, embedded brains GmbH Address : Dornierstr. 4,

Re: [PATCH] Added Getentropy() support to beagle BSP

2018-03-15 Thread Udit agarwal
On Thu, Mar 15, 2018 at 1:19 PM, Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > On 15/03/18 08:13, Udit agarwal wrote: > >> Oh yes, i think i misinterpreted your previous suggestion of surrounding >> the while loop by mutex, it should be the outer while loop. some thing like >> thi

[PATCH v2] if_atsam: Add checksum offload.

2018-03-15 Thread Christian Mauderer
--- rtemsbsd/sys/dev/atsam/if_atsam.c | 52 +-- 1 file changed, 44 insertions(+), 8 deletions(-) diff --git a/rtemsbsd/sys/dev/atsam/if_atsam.c b/rtemsbsd/sys/dev/atsam/if_atsam.c index 794937be..86e232ab 100644 --- a/rtemsbsd/sys/dev/atsam/if_atsam.c +++ b/rt

Re: [PATCH] Added Getentropy() support to beagle BSP

2018-03-15 Thread Sebastian Huber
On 15/03/18 08:13, Udit agarwal wrote: Oh yes, i think i misinterpreted your previous suggestion of surrounding the while loop by mutex, it should be the outer while loop. some thing like this?: while (n > 0) {         uint32_t random;         size_t copy;         rtems_mutex_lock(&atsam_trng_

Re: [PATCH] Added Getentropy() support to beagle BSP

2018-03-15 Thread Udit agarwal
On Thu, Mar 15, 2018 at 11:34 AM, Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > > > On 15/03/18 05:56, Udit agarwal wrote: > >> +/* TRNG Register */ >> + >> +/* RNG base address */ >> > > Is the module name TRNG or RNG? > It's TRNG. I'll correct this. > > +#define RNG_BASE 0x4831

Re: [PATCH] Added Getentropy() support to beagle BSP

2018-03-15 Thread Udit agarwal
On Thu, Mar 15, 2018 at 11:29 AM, Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > > > On 15/03/18 05:56, Udit agarwal wrote: > >> c/src/lib/libbsp/arm/atsam/startup/getentropy-trng.c | 6 ++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/c/src/lib/libbsp/arm/atsam/startu