Re: [PATCH 15/15] HiFive1: disable/enable interrupts during context switch

2017-08-17 Thread Gedare Bloom
On Thu, Aug 17, 2017 at 4:17 PM, Denis Obrezkov wrote: > 2017-08-17 22:07 GMT+02:00 Gedare Bloom : >> >> On Thu, Aug 17, 2017 at 1:48 PM, Denis Obrezkov >> wrote: >> > 2017-08-17 17:25 GMT+02:00 Gedare Bloom : >> >> >> >> On Wed, Aug 16, 2017 at 11:13 AM, Denis Obrezkov >> >> wrote: >> >> > ---

Re: [PATCH 15/15] HiFive1: disable/enable interrupts during context switch

2017-08-17 Thread Denis Obrezkov
2017-08-17 22:07 GMT+02:00 Gedare Bloom : > On Thu, Aug 17, 2017 at 1:48 PM, Denis Obrezkov > wrote: > > 2017-08-17 17:25 GMT+02:00 Gedare Bloom : > >> > >> On Wed, Aug 16, 2017 at 11:13 AM, Denis Obrezkov > >> wrote: > >> > --- > >> > cpukit/score/cpu/riscv32/riscv-context-switch.S | 12 ++

Re: [PATCH 15/15] HiFive1: disable/enable interrupts during context switch

2017-08-17 Thread Gedare Bloom
On Thu, Aug 17, 2017 at 1:48 PM, Denis Obrezkov wrote: > 2017-08-17 17:25 GMT+02:00 Gedare Bloom : >> >> On Wed, Aug 16, 2017 at 11:13 AM, Denis Obrezkov >> wrote: >> > --- >> > cpukit/score/cpu/riscv32/riscv-context-switch.S | 12 ++-- >> > 1 file changed, 10 insertions(+), 2 deletions(

Re: [PATCH 15/15] HiFive1: disable/enable interrupts during context switch

2017-08-17 Thread Denis Obrezkov
2017-08-17 17:25 GMT+02:00 Gedare Bloom : > On Wed, Aug 16, 2017 at 11:13 AM, Denis Obrezkov > wrote: > > --- > > cpukit/score/cpu/riscv32/riscv-context-switch.S | 12 ++-- > > 1 file changed, 10 insertions(+), 2 deletions(-) > > > > diff --git a/cpukit/score/cpu/riscv32/riscv-context-sw

Re: [PATCH 02/15] HiFive1: add linker file

2017-08-17 Thread Denis Obrezkov
2017-08-17 16:57 GMT+02:00 Gedare Bloom : > On Wed, Aug 16, 2017 at 11:12 AM, Denis Obrezkov > wrote: > > --- > > c/src/lib/libbsp/riscv32/hifive1/startup/linkcmds | 379 > ++ > > 1 file changed, 379 insertions(+) > > create mode 100644 c/src/lib/libbsp/riscv32/hifive1/start

Re: [PATCH 15/15] HiFive1: disable/enable interrupts during context switch

2017-08-17 Thread Gedare Bloom
On Wed, Aug 16, 2017 at 11:13 AM, Denis Obrezkov wrote: > --- > cpukit/score/cpu/riscv32/riscv-context-switch.S | 12 ++-- > 1 file changed, 10 insertions(+), 2 deletions(-) > > diff --git a/cpukit/score/cpu/riscv32/riscv-context-switch.S > b/cpukit/score/cpu/riscv32/riscv-context-switch

Re: [PATCH 3/7] Import strnstr.c from FreeBSD.

2017-08-17 Thread Aditya Upadhyay
Yes, I can. On 17 Aug 2017 8:32 p.m., "Gedare Bloom" wrote: > Aditya, > > Can you help Sichen to put the file in the right place in newlib and > add to the build? Either help him understand how to do it, or do it > with/for him? > > On Thu, Aug 17, 2017 at 10:58 AM, Aditya Upadhyay > wrote: > >

Re: [PATCH 12/15] HiFive1: add UART support

2017-08-17 Thread Gedare Bloom
Remove the extra blank lines, and consider adding some helper functions (for enable/disable UARTx, for example) On Wed, Aug 16, 2017 at 11:13 AM, Denis Obrezkov wrote: > --- > .../libbsp/riscv32/hifive1/console/fe310-uart.c| 215 > + > .../libbsp/riscv32/hifive1/include/

Re: [PATCH 11/15] HiFive1: set up oscillators

2017-08-17 Thread Gedare Bloom
On Wed, Aug 16, 2017 at 11:13 AM, Denis Obrezkov wrote: > --- > c/src/lib/libbsp/riscv32/hifive1/start/bspstart.c | 65 > +++ > 1 file changed, 65 insertions(+) > create mode 100644 c/src/lib/libbsp/riscv32/hifive1/start/bspstart.c > > diff --git a/c/src/lib/libbsp/riscv32/h

Re: [PATCH 10/15] HiFive1: add clock driver support

2017-08-17 Thread Gedare Bloom
On Wed, Aug 16, 2017 at 11:13 AM, Denis Obrezkov wrote: > --- > c/src/lib/libbsp/riscv32/hifive1/clock/clock.c | 67 > ++ > 1 file changed, 67 insertions(+) > create mode 100644 c/src/lib/libbsp/riscv32/hifive1/clock/clock.c > > diff --git a/c/src/lib/libbsp/riscv32/hifi

Re: [PATCH 08/15] HiFive1: add irq dispatching function

2017-08-17 Thread Gedare Bloom
On Wed, Aug 16, 2017 at 11:12 AM, Denis Obrezkov wrote: > --- > c/src/lib/libbsp/riscv32/hifive1/irq/irq.c | 90 > ++ > 1 file changed, 90 insertions(+) > create mode 100644 c/src/lib/libbsp/riscv32/hifive1/irq/irq.c > > diff --git a/c/src/lib/libbsp/riscv32/hifive1/

Re: [PATCH 07/15] HiFive1: add PRCI support files

2017-08-17 Thread Gedare Bloom
On Wed, Aug 16, 2017 at 11:12 AM, Denis Obrezkov wrote: > --- > c/src/lib/libbsp/riscv32/hifive1/include/prci.h | 74 > + > c/src/lib/libbsp/riscv32/hifive1/start/prci.c | 33 +++ > 2 files changed, 107 insertions(+) > create mode 100644 c/src/lib/libbsp/riscv3

Re: [PATCH 3/7] Import strnstr.c from FreeBSD.

2017-08-17 Thread Gedare Bloom
Aditya, Can you help Sichen to put the file in the right place in newlib and add to the build? Either help him understand how to do it, or do it with/for him? On Thu, Aug 17, 2017 at 10:58 AM, Aditya Upadhyay wrote: > Yes.. Definitely i will do. Sichen can directly send the patch for strnstr > t

Re: [PATCH 04/15] HiFive1: add start.S file with basic initialization

2017-08-17 Thread Gedare Bloom
On Wed, Aug 16, 2017 at 11:12 AM, Denis Obrezkov wrote: > --- > c/src/lib/libbsp/riscv32/hifive1/start/start.S | 290 > + > 1 file changed, 290 insertions(+) > create mode 100644 c/src/lib/libbsp/riscv32/hifive1/start/start.S > > diff --git a/c/src/lib/libbsp/riscv32/hif

Re: [PATCH 3/7] Import strnstr.c from FreeBSD.

2017-08-17 Thread Aditya Upadhyay
Yes.. Definitely i will do. Sichen can directly send the patch for strnstr to newlib ml. Thanks, Aditya Upadhyay On 17 Aug 2017 7:03 p.m., "Joel Sherrill" wrote: > > > On Aug 17, 2017 8:19 AM, "Gedare Bloom" wrote: > > On Wed, Aug 16, 2017 at 8:14 PM, Sichen Zhao <1473996...@qq.com> wrote: > >

Re: [PATCH 02/15] HiFive1: add linker file

2017-08-17 Thread Gedare Bloom
On Wed, Aug 16, 2017 at 11:12 AM, Denis Obrezkov wrote: > --- > c/src/lib/libbsp/riscv32/hifive1/startup/linkcmds | 379 > ++ > 1 file changed, 379 insertions(+) > create mode 100644 c/src/lib/libbsp/riscv32/hifive1/startup/linkcmds > > diff --git a/c/src/lib/libbsp/riscv32/

Re: [PATCH 01/15] Add build support files for HiFive1 BSP

2017-08-17 Thread Gedare Bloom
Generally you should add the build system files after you add the source files so that the rtems build isn't broken on this particular commit. This is helpful for git-bisect. So please re-arrange your commits so the build won't fail on any particular commit. On Wed, Aug 16, 2017 at 11:12 AM, Denis

Re: [PATCH 3/7] Import strnstr.c from FreeBSD.

2017-08-17 Thread Joel Sherrill
On Aug 17, 2017 8:19 AM, "Gedare Bloom" wrote: On Wed, Aug 16, 2017 at 8:14 PM, Sichen Zhao <1473996...@qq.com> wrote: > --- > freebsd/lib/libc/string/strnstr.c | 67 ++ + > 1 file changed, 67 insertions(+) > create mode 100644 freebsd/lib/libc/string/strnstr

Re: [PATCH 3/7] Import strnstr.c from FreeBSD.

2017-08-17 Thread Gedare Bloom
On Wed, Aug 16, 2017 at 8:14 PM, Sichen Zhao <1473996...@qq.com> wrote: > --- > freebsd/lib/libc/string/strnstr.c | 67 > +++ > 1 file changed, 67 insertions(+) > create mode 100644 freebsd/lib/libc/string/strnstr.c > > diff --git a/freebsd/lib/libc/string/str

Re: [PATCH 4/7] Port strnstr.c to FreeBSD.

2017-08-17 Thread Gedare Bloom
On Thu, Aug 17, 2017 at 4:12 AM, Christian Mauderer wrote: > Two points regarding patch 3 and 4: > > First the easy one: I expect that you need it for wpa_supplicant to > compile? In that case these two patches should be in front of 1 and 2. > > The second point is harder to resolve. I wouldn't ev

Re: [PATCH 7/7] Add wpa_spplicant_fork command in test suite media01

2017-08-17 Thread Christian Mauderer
I think you can integrate that one into Patch 6. Am 17.08.2017 um 03:33 schrieb Sichen Zhao: > --- > testsuite/media01/test_main.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/testsuite/media01/test_main.c b/testsuite/media01/test_main.c > index 5ca88fb..acc24f2 100

Re: [PATCH 6/7] Add wpa_supplicant_fork command.

2017-08-17 Thread Christian Mauderer
That's a great function for debugging but I'm not sure whether it would be good as a command available to all. There should be at least some big warning that it can't be started multiple times. In the ideal case, add a lock so that it can only be started once. A little more into the future, it mos

Re: [PATCH 4/7] Port strnstr.c to FreeBSD.

2017-08-17 Thread Christian Mauderer
Two points regarding patch 3 and 4: First the easy one: I expect that you need it for wpa_supplicant to compile? In that case these two patches should be in front of 1 and 2. The second point is harder to resolve. I wouldn't even be sure myself what to do here: strnstr seems to be a function prov

Re: [PATCH 2/7] Port wpa supplicant to RTEMS.

2017-08-17 Thread Christian Mauderer
Am 16.08.2017 um 18:10 schrieb Sichen Zhao: > Add wpa_supplicant lib support > and shell command support in RTEMS. > --- > builder.py | 1 + > freebsd/contrib/wpa/src/utils/os_unix.c | 10 +- > freebsd/contrib/wpa/wpa_supplicant/config.h | 4 +-

Re: [PATCH 1/7] Import wpa from FreeBSD

2017-08-17 Thread Christian Mauderer
Hello Sichen, I get a error: corrupt patch at line 47434 for the first patch. That is the following part. The problem seems to be the empty line. Regards Christian Am 16.08.2017 um 18:10 schrieb Sichen Zhao: > +#include "common/ieee802_11_defs.h" > +#include "wps/wps.h" > + > +/* P2P ASP Se