Re: [PATCH] cpukit: Fix __RTEMS_REVISION__ define

2017-05-02 Thread Sebastian Huber
On 03/05/17 08:17, Chris Johns wrote: On 3/5/17 3:40 pm, Sebastian Huber wrote: On 03/05/17 07:28, Chris Johns wrote: On 3/5/17 3:09 pm, Sebastian Huber wrote: On 02/05/17 23:30, Chris Johns wrote: On 2/5/17 6:20 pm, Sebastian Huber wrote: [...] If you want to add this test please extract the

Re: [PATCH] cpukit: Fix __RTEMS_REVISION__ define

2017-05-02 Thread Chris Johns
On 3/5/17 3:40 pm, Sebastian Huber wrote: > > On 03/05/17 07:28, Chris Johns wrote: >> On 3/5/17 3:09 pm, Sebastian Huber wrote: >>> On 02/05/17 23:30, Chris Johns wrote: On 2/5/17 6:20 pm, Sebastian Huber wrote: [...] > If you want to add this test please extract the version detai

Re: [PATCH] cpukit: Fix __RTEMS_REVISION__ define

2017-05-02 Thread Sebastian Huber
On 03/05/17 07:28, Chris Johns wrote: On 3/5/17 3:09 pm, Sebastian Huber wrote: On 02/05/17 23:30, Chris Johns wrote: On 2/5/17 6:20 pm, Sebastian Huber wrote: [...] If you want to add this test please extract the version details from the build system Can we trust the build system? Give

Re: [PATCH] cpukit: Fix __RTEMS_REVISION__ define

2017-05-02 Thread Chris Johns
On 3/5/17 3:09 pm, Sebastian Huber wrote: > On 02/05/17 23:30, Chris Johns wrote: >> On 2/5/17 6:20 pm, Sebastian Huber wrote: >>> + rtems_test_assert(__RTEMS_MAJOR__ == 4); >>> + rtems_test_assert(__RTEMS_MINOR__ == 11); >>> + rtems_test_assert(__RTEMS_REVISION__ == 99); >> Please do not push t

Re: GCC 7.1 Released

2017-05-02 Thread Sebastian Huber
On 03/05/17 03:33, Chris Johns wrote: On 3/5/17 3:04 am, Joel Sherrill wrote: > >Thoughts on upgrading the 4.12 tools? > Looks good with updated dependent packages for gcc and with binutils-2.28. There are no build failures for just the tests. Attached is the warnings report which looks good if

Re: [PATCH] cpukit: Fix __RTEMS_REVISION__ define

2017-05-02 Thread Sebastian Huber
On 02/05/17 23:30, Chris Johns wrote: On 2/5/17 6:20 pm, Sebastian Huber wrote: + rtems_test_assert(__RTEMS_MAJOR__ == 4); + rtems_test_assert(__RTEMS_MINOR__ == 11); + rtems_test_assert(__RTEMS_REVISION__ == 99); Please do not push this test like this, it breaks releases. The test will neve

Re: GCC 7.1 Released

2017-05-02 Thread Chris Johns
On 3/5/17 3:04 am, Joel Sherrill wrote: > > Thoughts on upgrading the 4.12 tools? > Looks good with updated dependent packages for gcc and with binutils-2.28. There are no build failures for just the tests. Attached is the warnings report which looks good if the networking warnings are ignored.

Re: [PATCH] cpukit: Fix __RTEMS_REVISION__ define

2017-05-02 Thread Chris Johns
On 2/5/17 6:20 pm, Sebastian Huber wrote: > + rtems_test_assert(__RTEMS_MAJOR__ == 4); > + rtems_test_assert(__RTEMS_MINOR__ == 11); > + rtems_test_assert(__RTEMS_REVISION__ == 99); Please do not push this test like this, it breaks releases. The test will never pass on a release. If you want t

GCC 7.1 Released

2017-05-02 Thread Joel Sherrill
Hi Thoughts on upgrading the 4.12 tools? --joel Forwarded Message Subject: GCC 7.1 Released Date: Tue, 2 May 2017 10:57:28 -0500 From: Jakub Jelinek Reply-To: Jakub Jelinek To: g...@gcc.gnu.org We are proud to announce the next, major release of the GNU Compiler Collection

Re: [PATCH 29/30] leon, greth: SMP support by using spin-lock protection

2017-05-02 Thread Daniel Hellstrom
On 2017-05-02 11:00, Sebastian Huber wrote: On 02/05/17 10:51, Daniel Hellstrom wrote: On 2017-05-02 10:27, Sebastian Huber wrote: On 02/05/17 10:16, Daniel Hellstrom wrote: On 2017-05-02 10:00, Sebastian Huber wrote: On 02/05/17 09:32, Daniel Hellstrom wrote: On 2017-05-02 07:48, Seba

Re: [PATCH 29/30] leon, greth: SMP support by using spin-lock protection

2017-05-02 Thread Sebastian Huber
On 02/05/17 10:51, Daniel Hellstrom wrote: On 2017-05-02 10:27, Sebastian Huber wrote: On 02/05/17 10:16, Daniel Hellstrom wrote: On 2017-05-02 10:00, Sebastian Huber wrote: On 02/05/17 09:32, Daniel Hellstrom wrote: On 2017-05-02 07:48, Sebastian Huber wrote: On 13/04/17 21:31, Danie

Re: [PATCH 29/30] leon, greth: SMP support by using spin-lock protection

2017-05-02 Thread Daniel Hellstrom
On 2017-05-02 10:27, Sebastian Huber wrote: On 02/05/17 10:16, Daniel Hellstrom wrote: On 2017-05-02 10:00, Sebastian Huber wrote: On 02/05/17 09:32, Daniel Hellstrom wrote: On 2017-05-02 07:48, Sebastian Huber wrote: On 13/04/17 21:31, Daniel Hellstrom wrote: --- c/src/lib/libbsp/spa

Re: [PATCH] cpukit: Fix __RTEMS_REVISION__ define

2017-05-02 Thread Daniel Hellstrom
Ok, good. I just was about to send my patch, but now I wont. Thanks! On 2017-05-02 10:20, Sebastian Huber wrote: --- cpukit/configure.ac| 2 +- testsuites/sptests/Makefile.am | 1 + testsuites/sptests/configure.ac| 1 + testsuit

Re: [PATCH 23/30] leon, ahbstat: Use RTEMS 4.12 SMP interrupt lock

2017-05-02 Thread Sebastian Huber
On 13/04/17 21:31, Daniel Hellstrom wrote: #include Please don't include internal header files, use instead. -- Sebastian Huber, embedded brains GmbH Address : Dornierstr. 4, D-82178 Puchheim, Germany Phone : +49 89 189 47 41-16 Fax : +49 89 189 47 41-09 E-Mail : sebastian.hu...@embe

Re: Warning Report on Master

2017-05-02 Thread Sebastian Huber
On 02/05/17 10:02, Daniel Hellstrom wrote: I started to look into the leon3 smp build recent problem and I think I located the problem with the version check. Since commit d420b679afc03f17d597193268e98966a0acd83d 2017-04-14 __RTEMS_REVISION__ was changed to __RTEMS_REVISION___ causing macros lo

Re: [PATCH 29/30] leon, greth: SMP support by using spin-lock protection

2017-05-02 Thread Sebastian Huber
On 02/05/17 10:16, Daniel Hellstrom wrote: On 2017-05-02 10:00, Sebastian Huber wrote: On 02/05/17 09:32, Daniel Hellstrom wrote: On 2017-05-02 07:48, Sebastian Huber wrote: On 13/04/17 21:31, Daniel Hellstrom wrote: --- c/src/lib/libbsp/sparc/shared/net/greth.c | 134 -

[PATCH] cpukit: Fix __RTEMS_REVISION__ define

2017-05-02 Thread Sebastian Huber
--- cpukit/configure.ac| 2 +- testsuites/sptests/Makefile.am | 1 + testsuites/sptests/configure.ac| 1 + testsuites/sptests/spversion01/Makefile.am | 19 + testsuites/sptests/spversion01/init.c | 53 +

Re: [PATCH 29/30] leon, greth: SMP support by using spin-lock protection

2017-05-02 Thread Daniel Hellstrom
On 2017-05-02 10:00, Sebastian Huber wrote: On 02/05/17 09:32, Daniel Hellstrom wrote: On 2017-05-02 07:48, Sebastian Huber wrote: On 13/04/17 21:31, Daniel Hellstrom wrote: --- c/src/lib/libbsp/sparc/shared/net/greth.c | 134 -- 1 file changed, 71 insertions

Re: Warning Report on Master

2017-05-02 Thread Daniel Hellstrom
Hi Chris, I started to look into the leon3 smp build recent problem and I think I located the problem with the version check. Since commit d420b679afc03f17d597193268e98966a0acd83d 2017-04-14 __RTEMS_REVISION__ was changed to __RTEMS_REVISION___ causing macros looking at __RTEMS_REVISION__ to

Re: [PATCH 29/30] leon, greth: SMP support by using spin-lock protection

2017-05-02 Thread Sebastian Huber
On 02/05/17 09:32, Daniel Hellstrom wrote: On 2017-05-02 07:48, Sebastian Huber wrote: On 13/04/17 21:31, Daniel Hellstrom wrote: --- c/src/lib/libbsp/sparc/shared/net/greth.c | 134 -- 1 file changed, 71 insertions(+), 63 deletions(-) diff --git a/c/src/lib/

Re: [PATCH 29/30] leon, greth: SMP support by using spin-lock protection

2017-05-02 Thread Daniel Hellstrom
On 2017-05-02 07:48, Sebastian Huber wrote: On 13/04/17 21:31, Daniel Hellstrom wrote: --- c/src/lib/libbsp/sparc/shared/net/greth.c | 134 -- 1 file changed, 71 insertions(+), 63 deletions(-) diff --git a/c/src/lib/libbsp/sparc/shared/net/greth.c b/c/src/lib