Re: [PATCH v2 4/4] posix/src/mutexinit.c: Reorder to make priority a scoped variable

2017-04-26 Thread Joel Sherrill
On Wed, Apr 26, 2017 at 9:02 PM, Gedare Bloom wrote: > I might rather see the switch refactored to an if-then block, since it > has quite a bit of structure to it now. > > How about it includes all cases? --joel > On Wed, Apr 26, 2017 at 4:42 PM, Joel Sherrill wrote: > > --- > > cpukit/posix

Re: [PATCH v2 4/4] posix/src/mutexinit.c: Reorder to make priority a scoped variable

2017-04-26 Thread Gedare Bloom
I might rather see the switch refactored to an if-then block, since it has quite a bit of structure to it now. On Wed, Apr 26, 2017 at 4:42 PM, Joel Sherrill wrote: > --- > cpukit/posix/src/mutexinit.c | 41 +++-- > 1 file changed, 19 insertions(+), 22 deletio

Tier-1 build failures.

2017-04-26 Thread Chris Johns
Hello, A tier-1 build with the default `all` build profile has the following failures. Chris ^ Profile Time 6:46:12.960811 + warnings:10330 exes:49227 objs:241648 libs:6668 Failures: 1 smp-debug i386/pc686 build /opt/work/chris/rtems/kernel/rtems.git/c\

[PATCH v2 3/4] virtex5/startup/dummy_console.c: Use and for many of the prototypes

2017-04-26 Thread Joel Sherrill
--- .../libbsp/powerpc/virtex5/startup/dummy_console.c | 22 ++ 1 file changed, 2 insertions(+), 20 deletions(-) diff --git a/c/src/lib/libbsp/powerpc/virtex5/startup/dummy_console.c b/c/src/lib/libbsp/powerpc/virtex5/startup/dummy_console.c index e62a9f0..8a35eb9 100644 ---

[PATCH v2 4/4] posix/src/mutexinit.c: Reorder to make priority a scoped variable

2017-04-26 Thread Joel Sherrill
--- cpukit/posix/src/mutexinit.c | 41 +++-- 1 file changed, 19 insertions(+), 22 deletions(-) diff --git a/cpukit/posix/src/mutexinit.c b/cpukit/posix/src/mutexinit.c index 47e0bcb..cdbba11 100644 --- a/cpukit/posix/src/mutexinit.c +++ b/cpukit/posix/src/mutex

[PATCH v2 2/4] dhrystone/dhry_1.c: Move assignment to before start of timer

2017-04-26 Thread Joel Sherrill
--- testsuites/benchmarks/dhrystone/dhry_1.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/testsuites/benchmarks/dhrystone/dhry_1.c b/testsuites/benchmarks/dhrystone/dhry_1.c index 9b64d3a..3ad2e7f 100644 --- a/testsuites/benchmarks/dhrystone/dhry_1.c +++ b/testsu

[PATCH v2 1/4] virtex4/startup/dummy_console.c: Use and for many of the prototypes

2017-04-26 Thread Joel Sherrill
--- .../libbsp/powerpc/virtex4/startup/dummy_console.c| 19 ++- 1 file changed, 2 insertions(+), 17 deletions(-) diff --git a/c/src/lib/libbsp/powerpc/virtex4/startup/dummy_console.c b/c/src/lib/libbsp/powerpc/virtex4/startup/dummy_console.c index e62a9f0..6ff24b2 100644 ---

Re: [rtems commit] posix/src/mutexinit.c: Fix used before initialized warning

2017-04-26 Thread Joel Sherrill
On Tue, Apr 25, 2017 at 7:59 PM, Joel Sherrill wrote: > > > On Tue, Apr 25, 2017 at 7:25 PM, Gedare Bloom wrote: > >> On Tue, Apr 25, 2017 at 7:14 PM, Joel Sherrill wrote: >> > Module:rtems >> > Branch:master >> > Commit:6601684f74f0ea1ec44fb52ec75d52215af11f5f >> > Changeset: http:

Re: [rtems commit] virtex5/startup/dummy_console.c: Fix no prototype warning

2017-04-26 Thread Joel Sherrill
Turns out that BSP_output_char is prototyped in . I suspect that it may be prototyped in many BSPs. Also the virtex4 and virtex5 had their own prototypes for the console driver entry points. Those are in . I will commit a fix to get ~7 prototypes from headers. --joel On Tue, Apr 25, 2017 at 8:5