Re: [PATCH] Update:Change format specifiers to fix 4 warnings.

2017-04-06 Thread Joel Sherrill
I filed a ticket (https://devel.rtems.org/ticket/2983) so we can fine tune the proposal and track it. --joel On Thu, Apr 6, 2017 at 5:39 PM, Joel Sherrill wrote: > > > On Thu, Apr 6, 2017 at 5:37 PM, Gedare Bloom wrote: > >> On Thu, Apr 6, 2017 at 6:30 PM, Joel Sherrill wrote: >> > Following

Re: [PATCH] Update:Change format specifiers to fix 4 warnings.

2017-04-06 Thread Joel Sherrill
On Thu, Apr 6, 2017 at 5:37 PM, Gedare Bloom wrote: > On Thu, Apr 6, 2017 at 6:30 PM, Joel Sherrill wrote: > > Following up on my own post. You can avoid some casts. > > This is also an example of how pulling a thread can lead > > somewhere more complicated. :) > > > > %z should work portably fo

Re: [PATCH] Update:Change format specifiers to fix 4 warnings.

2017-04-06 Thread Gedare Bloom
On Thu, Apr 6, 2017 at 6:30 PM, Joel Sherrill wrote: > Following up on my own post. You can avoid some casts. > This is also an example of how pulling a thread can lead > somewhere more complicated. :) > > %z should work portably for size_t and should avoid a cast. > > libdl already has this in li

Re: [PATCH] Update:Change format specifiers to fix 4 warnings.

2017-04-06 Thread Joel Sherrill
Following up on my own post. You can avoid some casts. This is also an example of how pulling a thread can lead somewhere more complicated. :) %z should work portably for size_t and should avoid a cast. libdl already has this in libdl/rtl-shell.c which tries to provide a C99 inttypes.h like const

Re: [PATCH] Update:Change format specifiers to fix 4 warnings.

2017-04-06 Thread Joel Sherrill
Thanks. I am rebuilding all my tools so am not in a position to start a test of this until in the morning. I am not saying your patch is wrong. But speaking from experience, the answer to portable warning free printf() formats is often inttypes.h. Especially if some have system types or are like

[PATCH] Update:Change format specifiers to fix 4 warnings.

2017-04-06 Thread Cillian O'Donnell
2 of the warnings cropped up on further testing of other BSPs. Sorry, should of been more careful. Also git send-email format. --- cpukit/libdl/rtl-obj-cache.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/cpukit/libdl/rtl-obj-cache.c b/cpukit/libdl/rtl-ob

Re: [PATCH] libdl/rtl-obj-cache.c: Change format specifiers to fix warnings

2017-04-06 Thread Gedare Bloom
Hello Cillian, Please send patches preferably with the git-send-email command. It takes a bit of work to configure it properly. There are instructions on our wiki for gmail: https://devel.rtems.org/wiki/Developer/Git/Users#SubmittingaPatch On Thu, Apr 6, 2017 at 11:51 AM, Cillian O'Donnell wrote

[PATCH] libdl/rtl-obj-cache.c: Change format specifiers to fix warnings

2017-04-06 Thread Cillian O'Donnell
This get rid of 4 warnings. Tested on m68k-gen68340(32 bit) and sparc64-niagara(64 bit). Let me know if this is ok. diff --git a/cpukit/libdl/rtl-obj-cache.c b/cpukit/libdl/rtl-obj-cache.c index a4676cf..912689d 100644 --- a/cpukit/libdl/rtl-obj-cache.c +++ b/cpukit/libdl/rtl-obj-cache.c @@ -78,11

RE: [PATCH 1/7] Adding stty command files from FREEBSD tree

2017-04-06 Thread Kirspel, Kevin
Yes. I rebased last night. Kevin Kirspel Electrical Engineer - Sr. Staff Idexx Roswell 235 Hembree Park Drive Roswell GA 30076 Tel: (770)-510- ext. 81642 Direct: (770)-688-1642 Fax: (770)-510-4445 -Original Message- From: Sebastian Huber [mailto:sebastian.hu...@embedded-brains.de] S