Re: Code review for Raspberry Pi USB driver

2016-06-24 Thread Deval Shah
On Friday 24 June 2016, Pavel Pisa wrote: > Hello Deval Shah and others, > > On Friday 24 of June 2016 10:45:34 Deval Shah wrote: > > Hello all, > > > > I have successfully ported the bcm283x_dwcotg driver for the Raspberry > Pi. > > Changes are shown in the commit > > > > https://github.com/deva

Re: [PATCH 1/4] cpukit: Add and use Watchdog_Discipline.

2016-06-24 Thread Gedare Bloom
Thanks. I'm on vacation for 2 weeks. I will revisit this when I get back and provide updated patches when done. On Fri, Jun 24, 2016 at 2:07 AM, Sebastian Huber wrote: > Hello Gedare, > > I am happy in general, but I have some concerns. I would definitely not > change the Classic API level ticks

Re: Mailbox RPi patch and rtems_cache_* probably broken on RPi

2016-06-24 Thread Pavel Pisa
Hello Gedare, On Thursday 23 of June 2016 17:44:13 Gedare Bloom wrote: > This could explain a number of problems reported by students trying to > get their RPi peripherals working. The cache manager has never been a > robust and complete implementation. I think it must be carefully > looked at acr

Re: Mailbox RPi patch and rtems_cache_* probably broken on RPi

2016-06-24 Thread Pavel Pisa
Hello Sebastian, On Friday 24 of June 2016 12:49:38 Sebastian Huber wrote: > We have two tests for the cache manager spcache01 and smpcache01. It is > not easy to write a proper test for the cache manager, so these tests > are far from being perfect, however they check the common cases. Every > BS

Re: [PATCH] Adding functionalities to Mailbox RPi

2016-06-24 Thread Gedare Bloom
On Mon, Jun 20, 2016 at 5:17 PM, Mudit Jain wrote: > From: muditj > > Added functions for retrieving firmware revision, > board model and board revision. > --- > c/src/lib/libbsp/arm/raspberrypi/include/vc.h | 19 +++ > c/src/lib/libbsp/arm/raspberrypi/misc/vc.c | 60 >

Re: PCIe on QorIQ?

2016-06-24 Thread Sebastian Huber
The QorIQ RTEMS users I know use all a home grown PCI infrastructure. For RTEMS I would port the stuff from the latest FreeBSD and add it to libbsd. On 23/06/16 22:25, Joel Sherrill wrote: Hi Has anyone used PCIe on a QorIQ reference board or any other QorIQ board? What functionality is miss

Re: Mailbox RPi patch and rtems_cache_* probably broken on RPi

2016-06-24 Thread Sebastian Huber
On 23/06/16 17:44, Gedare Bloom wrote: This could explain a number of problems reported by students trying to get their RPi peripherals working. The cache manager has never been a robust and complete implementation. I think it must be carefully looked at across targets (easier when we delete obso

Re: [PATCH] Adding functionalities to Mailbox RPi

2016-06-24 Thread Pavel Pisa
Hello Mudit and Gedare, On Friday 24 of June 2016 12:02:36 Mudit Jain wrote: > Hi Gedare, > > When I use uncrustify, it makes a lot of changes to the previous code as > well. We can have another patch over this for the cosmetic changes. > > I myself, did have doubts regarding the empty struct and

Re: [PATCH] Adding functionalities to Mailbox RPi

2016-06-24 Thread Mudit Jain
Hi Gedare, When I use uncrustify, it makes a lot of changes to the previous code as well. We can have another patch over this for the cosmetic changes. I myself, did have doubts regarding the empty struct and having two structs that are basically identical, however previously it was implemented i

[PATCH 3/3] score: Change Priority_Control to 64-bit

2016-06-24 Thread Sebastian Huber
A 32-bit Priority_Control limits the uptime to 49 days with a 1ms clock tick in case the EDF scheduler is used. Increase it to 64-bit to enable proper operation of the EDF scheduler, Close 2173. --- cpukit/posix/include/rtems/posix/priorityimpl.h | 9 - cpukit/posix/src/killinfo

[PATCH 1/3] testsuites: Increase invalid priority values

2016-06-24 Thread Sebastian Huber
Increase the invalid priority values to support test runs with alternative schedulers offering a significant higher maximum priority value, e.g. EDF. --- testsuites/psxtests/psx05/init.c| 2 +- testsuites/sptests/sp30/init.c | 2 +- testsuites/sptests/sptask_err04/init.c | 2 +-

[PATCH 2/3] score: Silence integer conversion warnings

2016-06-24 Thread Sebastian Huber
--- cpukit/score/include/rtems/score/prioritybitmapimpl.h | 3 ++- cpukit/score/include/rtems/score/schedulerimpl.h | 2 +- cpukit/score/include/rtems/score/timestamp.h | 2 +- cpukit/score/include/rtems/score/watchdogimpl.h | 2 +- 4 files changed, 5 insertions(+), 4 deletions

Change Priority_Control to 64-bit for proper EDF support

2016-06-24 Thread Sebastian Huber
A 32-bit Priority_Control limits the uptime to 49 days with a 1ms clock tick in case the EDF scheduler is used. Increase it to 64-bit to enable proper operation of the EDF scheduler, I temporarily changed confdefs.h to use the EDF scheduler as default. All tests passed using the EDF scheduler as

Re: Code review for Raspberry Pi USB driver

2016-06-24 Thread Pavel Pisa
Hello Deval Shah and others, On Friday 24 of June 2016 10:45:34 Deval Shah wrote: > Hello all, > > I have successfully ported the bcm283x_dwcotg driver for the Raspberry Pi. > Changes are shown in the commit > > https://github.com/deval-maker/rtems-libbsd/commit/fd650f7ded413a0d891b5395 >abb0c8768

[PATCH 27/27] libnetworking: Add rtems_socket.h

2016-06-24 Thread Christian Mauderer
From: Christian Mauderer --- cpukit/libfs/src/nfsclient/src/rpcio.c| 1 + cpukit/libnetworking/Makefile.am | 1 + cpukit/libnetworking/kern/uipc_socket.c | 1 + cpukit/libnetworking/preinstall.am| 4 cpukit/libnetworking/rtems/rtems_socket.h | 28 +

[PATCH 10/27] libnetworking: Import current netinet/in.h

2016-06-24 Thread Christian Mauderer
From: Christian Mauderer Import the netinet/in.h from current FreeBSD. This allows to build some current software (e.g. libressl). --- cpukit/libnetworking/netinet/in.h | 477 +++--- 1 file changed, 344 insertions(+), 133 deletions(-) diff --git a/cpukit/libnetwo

[PATCH 03/27] testsuite: Add test for getnameinfo().

2016-06-24 Thread Christian Mauderer
From: Christian Mauderer --- testsuites/libtests/Makefile.am | 1 + testsuites/libtests/configure.ac | 1 + testsuites/libtests/networking01/Makefile.am | 22 +++ testsuites/libtests/networking01/init.c | 161 ++ testsuit

[PATCH 22/27] libnetworking: Clean up problems with htonl(), ...

2016-06-24 Thread Christian Mauderer
From: Christian Mauderer These functions are defined in . This lead to some problems because they are defined in too. --- cpukit/libnetworking/arpa/nameser_compat.h | 2 +- cpukit/libnetworking/rtems/mkrootfs.c | 2 +- cpukit/libnetworking/rtems/mkrootfs.h |

[PATCH 01/27] libnetworking: Add prototype for getnameinfo().

2016-06-24 Thread Christian Mauderer
From: Christian Mauderer Copy the prototype and necessary defines for getnameinfo() from current FreeBSD. --- cpukit/libnetworking/netdb.h | 47 1 file changed, 47 insertions(+) diff --git a/cpukit/libnetworking/netdb.h b/cpukit/libnetworking/netdb.h

[PATCH 08/27] libnetworking: Update gethostent_r API.

2016-06-24 Thread Christian Mauderer
From: Christian Mauderer Linux and FreeBSD use a common API now. Adapt the RTEMS one to provide the same one. --- cpukit/libnetworking/libc/gethostbyht.c | 52 --- cpukit/libnetworking/libc/gethostnamadr.c | 7 - 2 files changed, 46 insertions(+), 13 deletions(

[PATCH 07/27] libnetworking: Add *__h_errno() instead of h_errno.

2016-06-24 Thread Christian Mauderer
From: Christian Mauderer --- cpukit/libnetworking/libc/gethostbydns.c | 1 - cpukit/libnetworking/libc/getnetbydns.c | 2 -- cpukit/libnetworking/libc/herror.c | 8 +++- cpukit/libnetworking/resolv.h| 9 - 4 files changed, 7 insertions(+), 13 deletions(-) diff --g

[PATCH 12/27] libnetworking: Import current netinet6/in6.h

2016-06-24 Thread Christian Mauderer
From: Christian Mauderer Import the netinet6/in6.h from current FreeBSD. This allows to build some current software (e.g. libressl). --- cpukit/libnetworking/Makefile.am| 6 + cpukit/libnetworking/netinet6/in6.h | 745 cpukit/libnetworking/preinstall.am

[PATCH 06/27] libnetworking: Add _getXbyYname/addr and _set/endXYent functions.

2016-06-24 Thread Christian Mauderer
From: Christian Mauderer --- cpukit/libnetworking/Makefile.am | 1 + cpukit/libnetworking/libc/gethostbydns.c | 1 + cpukit/libnetworking/libc/gethostbyht.c | 1 + cpukit/libnetworking/libc/gethostbynis.c | 1 + cpukit/libnetworking/libc/gethostnamadr.c | 1 + cpukit/libnetwork

[PATCH 23/27] libnetworking: Add NTOHL, ... to rtems_bsdnet_internal.h.

2016-06-24 Thread Christian Mauderer
From: Christian Mauderer --- cpukit/libnetworking/rtems/rtems_bsdnet_internal.h | 5 + 1 file changed, 5 insertions(+) diff --git a/cpukit/libnetworking/rtems/rtems_bsdnet_internal.h b/cpukit/libnetworking/rtems/rtems_bsdnet_internal.h index 7237b91..10a1f62 100644 --- a/cpukit/libnetworki

[PATCH 20/27] libnetworking: Import current arpa/inet.h

2016-06-24 Thread Christian Mauderer
From: Christian Mauderer Import the arpa/inet.h from current FreeBSD. Necessary due to changes in in.h. --- cpukit/libnetworking/arpa/inet.h | 50 ++-- 1 file changed, 43 insertions(+), 7 deletions(-) diff --git a/cpukit/libnetworking/arpa/inet.h b/cpukit/lib

[PATCH 26/27] libnetworking: Add machine/_align.h.

2016-06-24 Thread Christian Mauderer
From: Christian Mauderer This is necessary for new sys/socket.h. --- cpukit/libnetworking/Makefile.am | 3 ++- cpukit/libnetworking/machine/_align.h | 21 + cpukit/libnetworking/preinstall.am| 4 3 files changed, 27 insertions(+), 1 deletion(-) create mode 10

[PATCH 17/27] libnetworking: Add ip_fw_chk_t and ip_fw_ctl_t.

2016-06-24 Thread Christian Mauderer
From: Christian Mauderer Add the types and pointers for firewall. --- cpukit/libnetworking/netinet/ip_fw.c | 1 + cpukit/libnetworking/netinet/ip_input.c | 1 + cpukit/libnetworking/netinet/ip_output.c | 1 + cpukit/libnetworking/netinet/raw_ip.c | 1 + cpukit/libnetw

[PATCH 15/27] libnetworking: satosin is now provided by in.h.

2016-06-24 Thread Christian Mauderer
From: Christian Mauderer --- cpukit/libnetworking/netinet/in_rmx.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/cpukit/libnetworking/netinet/in_rmx.c b/cpukit/libnetworking/netinet/in_rmx.c index ed45045..848332e 100644 --- a/cpukit/libnetworking/netinet/in_rmx.c +++ b/cpukit/libnetwork

[PATCH 13/27] libnetworking: Add prototype for in_cksum.

2016-06-24 Thread Christian Mauderer
From: Christian Mauderer --- cpukit/libnetworking/Makefile.am | 1 + cpukit/libnetworking/netinet/igmp.c | 1 + cpukit/libnetworking/netinet/in_cksum_sparc.h | 1 + cpukit/libnetworking/netinet/ip_icmp.c| 1 + cpukit/libnetworking/netinet/tcp_input.c | 1

[PATCH 25/27] libnetworking: Import current sys/socket.h

2016-06-24 Thread Christian Mauderer
From: Christian Mauderer Import the sys/socket.h from current FreeBSD. This allows to build some current software (e.g. libressl). --- cpukit/libnetworking/sys/socket.h | 452 +++--- 1 file changed, 368 insertions(+), 84 deletions(-) diff --git a/cpukit/libnetwor

[PATCH 11/27] libnetworking: Import sys/_sockaddr_storage.h

2016-06-24 Thread Christian Mauderer
From: Christian Mauderer Import the sys/_sockaddr_storage.h from current FreeBSD. Necessary for updated in.h. --- cpukit/libnetworking/Makefile.am | 3 +- cpukit/libnetworking/preinstall.am | 4 +++ cpukit/libnetworking/sys/_sockaddr_storage.h | 54 +++

[PATCH 24/27] libnetworking: Include rtems_netdb.h for _map_v4v6... prototypes.

2016-06-24 Thread Christian Mauderer
From: Christian Mauderer --- cpukit/libnetworking/libc/map_v4v6.c | 1 + 1 file changed, 1 insertion(+) diff --git a/cpukit/libnetworking/libc/map_v4v6.c b/cpukit/libnetworking/libc/map_v4v6.c index 0b13285..66287d4 100644 --- a/cpukit/libnetworking/libc/map_v4v6.c +++ b/cpukit/libnetworking/l

[PATCH 14/27] libnetworking: Add IPPORT_USERRESERVED.

2016-06-24 Thread Christian Mauderer
From: Christian Mauderer --- cpukit/libnetworking/netinet/in_pcb.c | 1 + cpukit/libnetworking/rtems/rtems_netinet_in.h | 6 ++ 2 files changed, 7 insertions(+) diff --git a/cpukit/libnetworking/netinet/in_pcb.c b/cpukit/libnetworking/netinet/in_pcb.c index c41e634..1cd9c92 100644

[PATCH 18/27] libnetworking: Add ip_nat_... (IP NAT hooks.

2016-06-24 Thread Christian Mauderer
From: Christian Mauderer --- cpukit/libnetworking/rtems/rtems_netinet_in.h | 8 1 file changed, 8 insertions(+) diff --git a/cpukit/libnetworking/rtems/rtems_netinet_in.h b/cpukit/libnetworking/rtems/rtems_netinet_in.h index 3940d92..477cd99 100644 --- a/cpukit/libnetworking/rtems/rte

[PATCH 09/27] libnetworking: Match gethostbyname_r with prototype.

2016-06-24 Thread Christian Mauderer
From: Christian Mauderer --- cpukit/libnetworking/libc/gethostnamadr.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/cpukit/libnetworking/libc/gethostnamadr.c b/cpukit/libnetworking/libc/gethostnamadr.c index a718820..cf0a12d 100644 --- a/cpukit/libnetworking/libc/ge

[PATCH 19/27] libnetworking: Add IP_NAT option for get/setsockopt.

2016-06-24 Thread Christian Mauderer
From: Christian Mauderer --- cpukit/libnetworking/rtems/rtems_netinet_in.h | 8 1 file changed, 8 insertions(+) diff --git a/cpukit/libnetworking/rtems/rtems_netinet_in.h b/cpukit/libnetworking/rtems/rtems_netinet_in.h index 477cd99..c2da532 100644 --- a/cpukit/libnetworking/rtems/rte

[PATCH 04/27] libcsupport: Add dummy for setgroups().

2016-06-24 Thread Christian Mauderer
From: Christian Mauderer The dummy for setgroups() allows applications using it to build (for example civetweb webserver). --- cpukit/libcsupport/Makefile.am | 2 +- cpukit/libcsupport/src/setgroups.c | 26 testsuites/psxtests/psxhdrs/Makefile.am

[PATCH 21/27] libnetworking: Remove BSD hack from arpa/inet.h.

2016-06-24 Thread Christian Mauderer
From: Christian Mauderer --- cpukit/libnetworking/arpa/inet.h | 21 - 1 file changed, 21 deletions(-) diff --git a/cpukit/libnetworking/arpa/inet.h b/cpukit/libnetworking/arpa/inet.h index d71c927..91e3a82 100644 --- a/cpukit/libnetworking/arpa/inet.h +++ b/cpukit/libnetwork

[PATCH 05/27] libnetworking: Import current netdb.h

2016-06-24 Thread Christian Mauderer
From: Christian Mauderer Import the netdb.h from current FreeBSD. This allows to build some current software (e.g. libressl). --- cpukit/libnetworking/netdb.h | 162 ++- 1 file changed, 113 insertions(+), 49 deletions(-) diff --git a/cpukit/libnetworking/

[PATCH 02/27] libnetworking: Add minimal getnameinfo().

2016-06-24 Thread Christian Mauderer
From: Christian Mauderer This implementation just falls back to giving a string representation of the IP. It supports IPv4 only. --- cpukit/libnetworking/Makefile.am| 2 +- cpukit/libnetworking/libc/getnameinfo.c | 61 + 2 files changed, 62 insertions(+),

Update some network headers and add minimal getnameinfo and setgroups

2016-06-24 Thread Christian Mauderer
The first four patches add a minimal getnameinfo and a dummy for setgroups. This allows some applications to build (e.g. civetweb). I already sent these patches a few weeks ago. The new version only contains a bugfix. The original patches are here: https://lists.rtems.org/pipermail/devel/2016-May/0

[PATCH 16/27] libnetworking: Add deprecated IPCTL_RTxxx defines.'

2016-06-24 Thread Christian Mauderer
From: Christian Mauderer --- cpukit/libnetworking/netinet/in_rmx.c | 1 + cpukit/libnetworking/rtems/rtems_netinet_in.h | 5 + 2 files changed, 6 insertions(+) diff --git a/cpukit/libnetworking/netinet/in_rmx.c b/cpukit/libnetworking/netinet/in_rmx.c index 848332e..f825cdc 100644 -

Re: [PATCH] Subject: Add original BBBIO PWM driver to BBB BSP

2016-06-24 Thread punit vara
I have added registers definitions to am335x.h those are used in BBBIO. Mainly I added so that we can know this much of register right now BBBIO is using and I will add more definitions in second commit so that we can track that new changes required that definitions. If you say I will only add BBBI