Re: [PATCH 7/7] Add pthread_condattr_getclock() and pthread_condattr_setclock()

2016-06-14 Thread Sebastian Huber
On 14/06/16 17:05, Joel Sherrill wrote: +int pthread_condattr_getclock( + const pthread_condattr_t *__restrict attr, + clockid_t*__restrict clock +) +{ + if ( !attr ) { +return EINVAL; + } https://devel.rtems.org/wiki/Developer/Coding/Conventions "Use NULL for the nul

Re: [rtems commit] bsp/qoriq: Increase reserved size for FDT

2016-06-14 Thread Sebastian Huber
On 15/06/16 03:06, Chris Johns wrote: On 13/06/2016 21:42, Sebastian Huber wrote: +RTEMS_BSPOPTS_SET([BSP_FDT_BLOB_SIZE_MAX],[qoriq_t*],[262144]) That must be a massive FDT blob and must contain many many thousands of entries or there are a number of large strings embedded. Is there really

Re: [rtems commit] bsp/qoriq: Increase reserved size for FDT

2016-06-14 Thread Chris Johns
On 13/06/2016 21:42, Sebastian Huber wrote: +RTEMS_BSPOPTS_SET([BSP_FDT_BLOB_SIZE_MAX],[qoriq_t*],[262144]) That must be a massive FDT blob and must contain many many thousands of entries or there are a number of large strings embedded. Is there really blobs over 128K? Chris ___

[PATCH 1/7] mvme147s/shmsupp/getcfg.c: Fix warning

2016-06-14 Thread Joel Sherrill
--- c/src/lib/libbsp/m68k/mvme147s/shmsupp/getcfg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/c/src/lib/libbsp/m68k/mvme147s/shmsupp/getcfg.c b/c/src/lib/libbsp/m68k/mvme147s/shmsupp/getcfg.c index 3e93c1a..c549a9f 100644 --- a/c/src/lib/libbsp/m68k/mvme147s/shmsupp/getc

[PATCH 6/7] mptests/mp03/task1.c: Make method static to fix warning

2016-06-14 Thread Joel Sherrill
--- testsuites/mptests/mp03/task1.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/testsuites/mptests/mp03/task1.c b/testsuites/mptests/mp03/task1.c index 1e55912..5fdda4d 100644 --- a/testsuites/mptests/mp03/task1.c +++ b/testsuites/mptests/mp03/task1.c @@ -13,7 +13,7 @@ #

[PATCH 4/7] libchip/shmdr/send.c: Fix warning and clean up

2016-06-14 Thread Joel Sherrill
--- c/src/libchip/shmdr/send.c | 36 +--- 1 file changed, 21 insertions(+), 15 deletions(-) diff --git a/c/src/libchip/shmdr/send.c b/c/src/libchip/shmdr/send.c index 8f7a422..c3ac7d5 100644 --- a/c/src/libchip/shmdr/send.c +++ b/c/src/libchip/shmdr/send.c @@ -1,17

[PATCH 7/7] Add pthread_condattr_getclock() and pthread_condattr_setclock()

2016-06-14 Thread Joel Sherrill
--- cpukit/posix/Makefile.am| 4 +- cpukit/posix/src/condattrgetclock.c | 39 +++ cpukit/posix/src/condattrsetclock.c | 45 testsuites/psxtests/Makefile.am | 2 +- testsuites/psxtests/configure.ac| 1 + testsu

[PATCH 2/7] mvme147s/shmsupp/mpisr.c: Fix warnings and clean up

2016-06-14 Thread Joel Sherrill
--- c/src/lib/libbsp/m68k/mvme147s/shmsupp/mpisr.c | 22 ++ 1 file changed, 10 insertions(+), 12 deletions(-) diff --git a/c/src/lib/libbsp/m68k/mvme147s/shmsupp/mpisr.c b/c/src/lib/libbsp/m68k/mvme147s/shmsupp/mpisr.c index cbef4bc..0669538 100644 --- a/c/src/lib/libbsp/m68k

[PATCH 5/7] samples/base_mp/apptask.c: Fix warning and clean up

2016-06-14 Thread Joel Sherrill
--- testsuites/samples/base_mp/apptask.c | 23 +++ 1 file changed, 11 insertions(+), 12 deletions(-) diff --git a/testsuites/samples/base_mp/apptask.c b/testsuites/samples/base_mp/apptask.c index 1414549..e54e08a 100644 --- a/testsuites/samples/base_mp/apptask.c +++ b/testsui

[PATCH 3/7] libchip/shmdr/poll.c: Fix warning and clean up

2016-06-14 Thread Joel Sherrill
--- c/src/libchip/shmdr/poll.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/c/src/libchip/shmdr/poll.c b/c/src/libchip/shmdr/poll.c index 6ebd6e2..39eab7d 100644 --- a/c/src/libchip/shmdr/poll.c +++ b/c/src/libchip/shmdr/poll.c @@ -1,8 +1,11 @@ +/** + * @file +

Re: [PATCH] pc386: Add virtio network driver

2016-06-14 Thread Joel Sherrill
Does the virtio.h file need to be in the BSP or is it independent and can move to shared? I am glad to see this code being BSP and architecture independent. :) On Tue, Jun 14, 2016 at 9:37 AM, Gedare Bloom wrote: > Or maybe just the RTEMS_COMPILER_MEMORY_BARRIER()? > > On Tue, Jun 14, 2016 at 1

Re: [PATCH] pc386: Add virtio network driver

2016-06-14 Thread Gedare Bloom
Does _CPU_atomic_Fence() work for you? It is defined in cpukit/score/cpu/*/rtems/score/cpuatomic.h On Sat, Jun 11, 2016 at 3:12 AM, Jinhyun wrote: > Hi All, > > Thanks for your comments and suggestions. For a better decision, we like to > give a bit of background of our patch. > > Initially, we g

Re: [PATCH] pc386: Add virtio network driver

2016-06-14 Thread Gedare Bloom
Or maybe just the RTEMS_COMPILER_MEMORY_BARRIER()? On Tue, Jun 14, 2016 at 10:37 AM, Gedare Bloom wrote: > Does _CPU_atomic_Fence() work for you? It is defined in > cpukit/score/cpu/*/rtems/score/cpuatomic.h > > On Sat, Jun 11, 2016 at 3:12 AM, Jinhyun wrote: >> Hi All, >> >> Thanks for your com

Re: libbsd: Argument list too long

2016-06-14 Thread Sebastian Huber
On 14/06/16 09:39, Chris Johns wrote: On 14/06/2016 16:27, Sebastian Huber wrote: On 13/06/16 09:25, Sebastian Huber wrote: I created a waf ticket for this: https://github.com/waf-project/waf/issues/1756 There exists a workaround for this problem. Should we add the "waf" script equipped wi

Re: libbsd: Argument list too long

2016-06-14 Thread Chris Johns
On 14/06/2016 16:27, Sebastian Huber wrote: On 13/06/16 09:25, Sebastian Huber wrote: I created a waf ticket for this: https://github.com/waf-project/waf/issues/1756 There exists a workaround for this problem. Should we add the "waf" script equipped with this workaround to the libbsd? We s