Re: [PATCH v2] rtems: Fix no protocol mutex release

2016-06-03 Thread Chris Johns
On 03/06/2016 23:44, Sebastian Huber wrote: On 03/06/16 15:40, Joel Sherrill wrote: My concern is that this will break existing programs that used them for condition synchronization. These applications are broken since you can obtain the RTEMS_BINARY_SEMAPHORE recursively. Did you check if

Re: [PATCH] mghttpd: Add RTEMS printer support

2016-06-03 Thread Chris Johns
On 3/06/2016 10:58 PM, Sebastian Huber wrote: --- cpukit/include/rtems/print.h | 4 ++-- cpukit/mghttpd/mongoose.c| 12 cpukit/mghttpd/mongoose.h| 4 OK to push. Chris ___ devel mailing list devel@rtems.org http://lists.rt

Re: Driver complaint to SD Host Controller Specification 3.0

2016-06-03 Thread Chris Johns
On 3/06/2016 10:20 PM, Sebastian Huber wrote: On 03/06/16 13:20, Mudit Jain wrote: In the latest commit I have followed the FreeBSD port guidelines given libbsd.txt using the tools to port the code. Sorry for being pedantic, but please follow the guidelines exactly: I will add we have to be

Re: Driver complaint to SD Host Controller Specification 3.0

2016-06-03 Thread Mudit Jain
Hi, Apologies regarding that. Some of the lines that showed '-' were because changes were committed on the old changes which were not right. However, I have created a new branch where the commits are much cleaner. https://github.com/spark1729/rtems-libbsd/commits/RPI_SD On Fri, Jun 3, 2016 at

Re: [PATCH] shell: Add rtems_shell_wait_for_explicit_input()

2016-06-03 Thread Gedare Bloom
On Fri, Jun 3, 2016 at 4:05 AM, Sebastian Huber wrote: > From: Alexander Krutwig > > --- > cpukit/libmisc/shell/shell-wait-for-input.c | 26 ++ > cpukit/libmisc/shell/shell.h| 18 ++ > 2 files changed, 40 insertions(+), 4 deletions(-) > > d

Re: [PATCH v2] rtems: Fix no protocol mutex release

2016-06-03 Thread Sebastian Huber
On 03/06/16 15:40, Joel Sherrill wrote: My concern is that this will break existing programs that used them for condition synchronization. These applications are broken since you can obtain the RTEMS_BINARY_SEMAPHORE recursively. This just requires us to be vigilant to answer questions whe

Re: [PATCH v2] rtems: Fix no protocol mutex release

2016-06-03 Thread Joel Sherrill
My concern is that this will break existing programs that used them for condition synchronization. This just requires us to be vigilant to answer questions when things break. On Fri, Jun 3, 2016 at 8:37 AM, Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > The Classic binary semapho

[PATCH v2] rtems: Fix no protocol mutex release

2016-06-03 Thread Sebastian Huber
The Classic binary semaphores without a locking protocol (RTEMS_BINARY_SEMAPHORE) could be released by everyone, e.g. in contrast to the POSIX mutexes (all variants) or the Classic binary semphores with priority inheritance or ceiling there was no owner check in the release path. This behaviour wa

Re: [PATCH] rtems: Fix no protocol mutex release

2016-06-03 Thread Sebastian Huber
On 03/06/16 15:24, Joel Sherrill wrote: Binary semaphores with no protocol can be used for condition synchronization. This was described way back by Dijkstra. Usually the binary semaphore starts locked, a thread will then block upon an attempt to lock it. An ISO or other thread can release or f

Re: [PATCH] rtems: Fix no protocol mutex release

2016-06-03 Thread Joel Sherrill
Binary semaphores with no protocol can be used for condition synchronization. This was described way back by Dijkstra. Usually the binary semaphore starts locked, a thread will then block upon an attempt to lock it. An ISO or other thread can release or flush to announce the condition. This is a n

Re: [PATCH] rtems: Fix no protocol mutex release

2016-06-03 Thread Gedare Bloom
This changes undocumented behavior. It might be good to add a note to the (new) doc that only a lock owner is allowed to release. I guess the only plausible reason one would want the other behavior is for some kind of deadlock detection and "recovery", but I can't see that working correctly in the

Re: [PATCH] rtems: Fix no protocol mutex release

2016-06-03 Thread Sebastian Huber
On 03/06/16 15:06, Gedare Bloom wrote: This changes undocumented behavior. It might be good to add a note to the (new) doc that only a lock owner is allowed to release. I guess the only plausible reason one would want the other behavior is for some kind of deadlock detection and "recovery", but I

[PATCH] mghttpd: Add RTEMS printer support

2016-06-03 Thread Sebastian Huber
--- cpukit/include/rtems/print.h | 4 ++-- cpukit/mghttpd/mongoose.c| 12 cpukit/mghttpd/mongoose.h| 4 3 files changed, 18 insertions(+), 2 deletions(-) diff --git a/cpukit/include/rtems/print.h b/cpukit/include/rtems/print.h index 5268e8c..91c4515 100644 --- a/cpukit

Re: Driver complaint to SD Host Controller Specification 3.0

2016-06-03 Thread Sebastian Huber
On 03/06/16 13:20, Mudit Jain wrote: In the latest commit I have followed the FreeBSD port guidelines given libbsd.txt using the tools to port the code. Sorry for being pedantic, but please follow the guidelines exactly: "Only add lines. If your patch contains lines starting with a '-', then

Re: Driver complaint to SD Host Controller Specification 3.0

2016-06-03 Thread Mudit Jain
Hi, Yes Sebastian, that change was not required. I have rebased, removing that change and have pushed the same. Link Andre, as per your feedback, I have removed the ofw bus. In the latest commit I have followed the FreeBSD port guid

Re: Errors while building USB DWC OTG driver

2016-06-03 Thread Jan Sommer
Am 2016-06-03 11:37, schrieb Deval Shah: [...] Now for the debugging what are the methods with qemu? As in how to get step by step analysis of the running program ? If you run qemu with the options -s -S it will break at the beginning of the program and allow a gdb connection. You can then

Re: Errors while building USB DWC OTG driver

2016-06-03 Thread Sebastian Huber
Hello Deval, sorry, I don't have time to look at this at the moment. -- Sebastian Huber, embedded brains GmbH Address : Dornierstr. 4, D-82178 Puchheim, Germany Phone : +49 89 189 47 41-16 Fax : +49 89 189 47 41-09 E-Mail : sebastian.hu...@embedded-brains.de PGP : Public key availabl

Re: Errors while building USB DWC OTG driver

2016-06-03 Thread Deval Shah
Also, I compiled the same build for arm/realview_pbx_a9_qemu. And when I try this on qemu using this command #qemu-system-arm -no-reboot -nographic -M realview-pbx-a9 -m 256M -net none -kernel sleep01.exe pulseaudio: set_sink_input_volume() failed pulseaudio: Reason: Invalid argument pulseaudio:

Re: Errors while building USB DWC OTG driver

2016-06-03 Thread Deval Shah
Hello, I was going through last years mailing list for debugging the issue. I found this https://lists.rtems.org/pipermail/devel/2015-June/011741.html. Can someone explain how to get the linker map file ? On Wed, Jun 1, 2016 at 11:01 AM, Sebastian Huber < sebastian.hu...@embedded-brains.de> wrot

[PATCH] shell: Add rtems_shell_wait_for_explicit_input()

2016-06-03 Thread Sebastian Huber
From: Alexander Krutwig --- cpukit/libmisc/shell/shell-wait-for-input.c | 26 ++ cpukit/libmisc/shell/shell.h| 18 ++ 2 files changed, 40 insertions(+), 4 deletions(-) diff --git a/cpukit/libmisc/shell/shell-wait-for-input.c b/cpukit/libm

Re: [PATCH v2] libmisc/untar: Support directory create and overwrites. Share the common code.

2016-06-03 Thread Sebastian Huber
Looks good, thanks for adding the rtems_printf(). -- Sebastian Huber, embedded brains GmbH Address : Dornierstr. 4, D-82178 Puchheim, Germany Phone : +49 89 189 47 41-16 Fax : +49 89 189 47 41-09 E-Mail : sebastian.hu...@embedded-brains.de PGP : Public key available on request. Diese