Re: [PATCH] fat: Fix for invalid cluster sizes

ok On Thu, May 19, 2016 at 5:55 AM, Sebastian Huber wrote: > A cluster size > 32KiB resulted in an infinite loop in > fat_init_volume_info() due to an integer overflow. > > Close #2717. > --- > cpukit/libfs/src/dosfs/fat.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git

Re: Qemu System Error

Hi Joel, I was trying to run the ticker.exe on RTEMS 4.12. Regards, Habeeb On Fri, May 20, 2016 at 12:53 PM, Joel Sherrill wrote: > What application and what's the RTEMS configuration? > > The error code is internal and there is an enumeration for them. Check > that list for what happened. Loo

Re: Qemu System Error

What application and what's the RTEMS configuration? The error code is internal and there is an enumeration for them. Check that list for what happened. Looks like something isn't quite right in the application configuration. Y On Fri, May 20, 2016 at 11:41 AM, Olufowobi, Habeeb < habeeb.olufow.

Re: Qemu System Error

I was able to get qemu to work using RSB build. I tried to use the lm4f120 BSP but I got the error message below. Any Idea on how I can fix this? Also, I will like to know if this error is related to the patches in the BSP directory as I am using a newer version of qemu checkout by RSB. (gdb) bt #

Re: [PATCH 03/15] posix: Add and use _POSIX_Get_object_body()

Will doxygen pick up comments for macros? if so, the new "function" should be documented properly. On Fri, May 20, 2016 at 9:33 AM, Sebastian Huber wrote: > --- > cpukit/posix/include/rtems/posix/posixapi.h | 29 +++ > cpukit/posix/src/condget.c | 43 +---

Re: SMP Support Next Steps

Great work. After the lock split is done, we should try to get updated coverage reports to identify gaps in the test suite. On Fri, May 20, 2016 at 10:26 AM, Sebastian Huber wrote: > Hello, > > the Giant lock elimination is now done. > > The next step is to split up the CORE mutex implementation

Re: [PATCH 15/15] Replace *_Get_interrupt_disable() with *_Get()

OK On Fri, May 20, 2016 at 9:33 AM, Sebastian Huber wrote: > Uniformly use *_Get() to get an object by identifier with a lock > context. > --- > cpukit/posix/include/rtems/posix/muteximpl.h | 2 +- > cpukit/posix/src/cancel.c | 2 +- > cpukit/posix/src/mutexdestroy

Re: [PATCH 04/15] posix: Remove dead code and shrink comment

I think it is fine. The OmniORB had a problem with the dead code in place. On 20/05/16 16:05, Gedare Bloom wrote: Calling out to Sambeet to note that this patch is removing a comment about OmniORB that may be relevant to his work this summer. On Fri, May 20, 2016 at 9:33 AM, Sebastian Huber wr

SMP Support Next Steps

Hello, the Giant lock elimination is now done. The next step is to split up the CORE mutex implementation into different parts to simplify the business logic (e.g. mutex (ceiling and inheritance), recursive mutex (ceiling and inheritance) , binary semaphore (FIFO and priority), simple binary

Re: [PATCH 03/15] posix: Add and use _POSIX_Get_object_body()

On 20/05/16 16:04, Gedare Bloom wrote: Will doxygen pick up comments for macros? if so, the new "function" should be documented properly. Yes, Doxygen would pick up comments for macros. I will fix this. -- Sebastian Huber, embedded brains GmbH Address : Dornierstr. 4, D-82178 Puchheim, Germ

Re: [PATCH 13/32] score: Split _Thread_Restart()

Clarify the distinction between Thread_Do_self_restart() and Thread_Restart_self(). Probably want comments to indicate the difference. On Wed, May 18, 2016 at 5:20 AM, Sebastian Huber wrote: > Rename _Thread_Restart_self() into _Thread_Do_self_restart(). Split > _Thread_Restart() into _Thread_Re

[PATCH 13/15] score: Delete unused _Objects_Get_isr_disable()

Delete now unused Objects_Locations. --- cpukit/score/Makefile.am | 2 +- cpukit/score/include/rtems/score/objectimpl.h | 42 cpukit/score/src/objectgetisr.c | 55 --- 3 files changed, 1 insertion(+), 98 deletions(-)

[PATCH 06/15] score: Add const to _RBTree_Find_inline()

--- cpukit/score/include/rtems/score/rbtree.h | 26 ++ 1 file changed, 18 insertions(+), 8 deletions(-) diff --git a/cpukit/score/include/rtems/score/rbtree.h b/cpukit/score/include/rtems/score/rbtree.h index 1833483..dd56f1b 100644 --- a/cpukit/score/include/rtems/score/

[PATCH 10/15] rtems: Remove location from _Partition_Get()

Use _Objects_Get_local() for _Partition_Get() to get rid of the location parameter. Move remote object handling to partition MPCI support. --- cpukit/rtems/include/rtems/rtems/partimpl.h | 10 ++--- cpukit/rtems/include/rtems/rtems/partmp.h | 25 +++ cpukit/rtems/src/partdelete.c

Re: [PATCH 32/32] score: Remove the Giant lock

Hello Gedare, On 20/05/16 01:04, Gedare Bloom wrote: Nice work. Just a few small nits mostly related to doc. thanks for the review. I sent the next patch set, which contains some cleanup to simplify things. The next step is to split up the CORE mutex implementation into different parts to s

[PATCH 12/15] rtems: _Semaphore_Get_interrupt_disable()

Use _Objects_Get_local() for _Semaphore_Get_interrupt_disable() to get rid of the location parameter. Move remote object handling to semaphore MPCI support. --- cpukit/rtems/include/rtems/rtems/semimpl.h | 21 +-- cpukit/rtems/include/rtems/rtems/semmp.h | 24 ++-- cpukit/rtems/src/semdelete.

[PATCH 05/15] score: Delete unused _Objects_Get_local_object()

--- cpukit/score/include/rtems/score/objectimpl.h | 27 --- 1 file changed, 27 deletions(-) diff --git a/cpukit/score/include/rtems/score/objectimpl.h b/cpukit/score/include/rtems/score/objectimpl.h index 4049bdc..52b6ab3 100644 --- a/cpukit/score/include/rtems/score/obje

[PATCH 15/15] Replace *_Get_interrupt_disable() with *_Get()

Uniformly use *_Get() to get an object by identifier with a lock context. --- cpukit/posix/include/rtems/posix/muteximpl.h | 2 +- cpukit/posix/src/cancel.c | 2 +- cpukit/posix/src/mutexdestroy.c | 2 +- cpukit/posix/src/mutexget.c

[PATCH 11/15] rtems: _Message_queue_Get_interrupt_disable()

Use _Objects_Get_local() for _Message_queue_Get_interrupt_disable() to get rid of the location parameter. Move remote object handling to message queue MPCI support. --- cpukit/rtems/include/rtems/rtems/messageimpl.h | 8 +- cpukit/rtems/include/rtems/rtems/msgmp.h | 69 +---

[PATCH 04/15] posix: Remove dead code and shrink comment

--- cpukit/posix/src/mutexinit.c | 38 +++--- 1 file changed, 3 insertions(+), 35 deletions(-) diff --git a/cpukit/posix/src/mutexinit.c b/cpukit/posix/src/mutexinit.c index 1888699..8de76d0 100644 --- a/cpukit/posix/src/mutexinit.c +++ b/cpukit/posix/src/mutexinit

[PATCH 14/15] score: Rename _Objects_Get_local()

Rename _Objects_Get_local() into _Objects_Get(). Confusions with the previous _Objects_Get() function are avoided since the Objects_Locations parameter is gone. --- cpukit/posix/include/rtems/posix/barrierimpl.h | 2 +- cpukit/posix/include/rtems/posix/mqueueimpl.h| 2 +- cpukit/posix/inclu

[PATCH 01/15] score: Add per scheduler instance maximum priority

The priority values are only valid within a scheduler instance. Thus, the maximum priority value must be defined per scheduler instance. The first scheduler instance defines PRIORITY_MAXIMUM. This implies that RTEMS_MAXIMUM_PRIORITY and POSIX_SCHEDULER_MAXIMUM_PRIORITY are only valid for threads

[PATCH 02/15] score: Use _RBTree_Insert_inline()

Use _RBTree_Insert_inline() for priority thread queues. Update #2556. --- cpukit/score/include/rtems/score/threadqimpl.h | 15 -- cpukit/score/src/threadq.c | 21 --- cpukit/score/src/threadqops.c | 28 -- 3

[PATCH 03/15] posix: Add and use _POSIX_Get_object_body()

--- cpukit/posix/include/rtems/posix/posixapi.h | 29 +++ cpukit/posix/src/condget.c | 43 +-- cpukit/posix/src/mutexget.c | 45 + cpukit/posix/src/prwlockinit.c | 44 +

[PATCH 08/15] mpci: Simplify _Objects_MP_Is_remote()

--- cpukit/score/include/rtems/score/objectmp.h | 20 ++-- cpukit/score/include/rtems/score/threadmp.h | 2 +- cpukit/score/src/objectgetisr.c | 8 +--- cpukit/score/src/objectmp.c | 12 4 files changed, 20 insertions(+), 22 deletions(

[PATCH 09/15] mpci: Delete unused region support

--- cpukit/rtems/src/region.c | 12 1 file changed, 12 deletions(-) diff --git a/cpukit/rtems/src/region.c b/cpukit/rtems/src/region.c index 65933f9..892c680 100644 --- a/cpukit/rtems/src/region.c +++ b/cpukit/rtems/src/region.c @@ -51,18 +51,6 @@ static void _Region_Manager_initiali

[PATCH 07/15] posix: Add const to _POSIX_Keys_Key_value_find()

--- cpukit/posix/include/rtems/posix/keyimpl.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cpukit/posix/include/rtems/posix/keyimpl.h b/cpukit/posix/include/rtems/posix/keyimpl.h index 833e652..1148123 100644 --- a/cpukit/posix/include/rtems/posix/keyimpl.h +++ b/cpuki

Re: [PATCH 7/7] arm/raspberrypi: add cmdline support for rpi bsp.

These all look fine to push. go ahead On Thu, May 19, 2016 at 7:16 AM, wrote: > From: Pavel Pisa > > --- > c/src/lib/libbsp/arm/raspberrypi/Makefile.am | 1 + > c/src/lib/libbsp/arm/raspberrypi/include/bsp.h | 6 +++ > c/src/lib/libbsp/arm/raspberrypi/startup/cmdline.c | 47 >