Re: [PATCH 04/15] score: Add node adjust to _RBTree_Find_inline()

2016-04-05 Thread Gedare Bloom
I don't understand the name "adjust"? I think of adjusting as something that would cause a change or modify, which is not the case here. I don't have any great replacement, but I guess I might suggest "dereference"? On Tue, Apr 5, 2016 at 9:09 AM, Sebastian Huber wrote: > --- > cpukit/posix/incl

Re: [PATCH 04/15] score: Add node adjust to _RBTree_Find_inline()

2016-04-05 Thread Sebastian Huber
Maybe "map"? - Gedare Bloom schrieb: > On Tue, Apr 5, 2016 at 11:35 AM, Sebastian Huber > wrote: > > > > - Gedare Bloom schrieb: > >> I don't understand the name "adjust"? I think of adjusting as > >> something that would cause a change or modify, which is not the case > >> here. I don'

Error while building arm/realview_pbx_a9_qemu BSP

2016-04-05 Thread Deval Shah
Hello, I am trying to build arm/realview_pbx_a9_qemu with waf. ( https://git.rtems.org/rtems-libbsd/tree/README.waf ) In the last step, it shows the *following error:* Build failed -> task in 'bsd' failed (exit status 1): *A part error trace: * /home/gadgetman/development/rtems/rtems-libbsd/rt

Re: [PATCH 04/15] score: Add node adjust to _RBTree_Find_inline()

2016-04-05 Thread Sebastian Huber
- Gedare Bloom schrieb: > I don't understand the name "adjust"? I think of adjusting as > something that would cause a change or modify, which is not the case > here. I don't have any great replacement, but I guess I might suggest > "dereference"? You may adjust the pointer value, e.g. node

Re: [PATCH 06/15] score: Use red-black tree for active global objects

2016-04-05 Thread Sebastian Huber
- Gedare Bloom schrieb: > Generally ok. I have a question and comment. > > Would it make sense to unify the object management and use an rbtree > in the uni/smp cases too? You mean for Object_Control objects? No, this would be a performance problem I guess if you do a tree lookup each time

Re: [PATCH] cpukit: pppd: fix compile warning

2016-04-05 Thread Gedare Bloom
This should be fine. I don't know, does pppd have an active maintainer? On Tue, Apr 5, 2016 at 8:45 AM, Peng Fan wrote: > rcsid is defined, but not used. So discard it. > > Signed-off-by: Peng Fan > --- > cpukit/pppd/auth.c | 4 > cpukit/pppd/ccp.c | 4 > cpukit/pppd/chap.c

[PATCH 10/15] score: Delete _Chain_Prepend_with_empty_check()

2016-04-05 Thread Sebastian Huber
This function is not used in the score. Update #2555. --- cpukit/sapi/include/rtems/chain.h| 10 --- cpukit/sapi/src/chainprotected.c | 4 +-- cpukit/score/Makefile.am | 2 +- cpukit/score/include/rtems/score/chainimpl.h | 19 cpukit/

[PATCH 11/15] score: Delete _Chain_Get_with_empty_check()

2016-04-05 Thread Sebastian Huber
This function is not used in the score. Update #2555. --- cpukit/sapi/include/rtems/chain.h| 10 --- cpukit/sapi/src/chainprotected.c | 4 --- cpukit/score/Makefile.am | 1 - cpukit/score/include/rtems/score/chainimpl.h | 25 cpuk

[PATCH 15/15] score: Delete _Chain_Append()

2016-04-05 Thread Sebastian Huber
This function is not used in the score. Update #2555. --- cpukit/sapi/include/rtems/chain.h| 10 -- cpukit/sapi/src/chainprotected.c | 4 --- cpukit/score/Makefile.am | 2 +- cpukit/score/include/rtems/score/chainimpl.h | 13 --- cpukit/score/

[PATCH 13/15] score: Delete _Chain_Extract()

2016-04-05 Thread Sebastian Huber
This function is not used in the score. Update #2555. --- cpukit/sapi/include/rtems/chain.h| 9 --- cpukit/sapi/src/chainprotected.c | 4 ++-- cpukit/score/Makefile.am | 2 +- cpukit/score/include/rtems/score/chainimpl.h | 15 cpukit

[PATCH 12/15] score: Delete _Chain_Insert()

2016-04-05 Thread Sebastian Huber
This function is not used in the score. Update #2555. --- cpukit/sapi/include/rtems/chain.h| 10 -- cpukit/sapi/src/chainprotected.c | 4 +++ cpukit/score/Makefile.am | 2 +- cpukit/score/include/rtems/score/chainimpl.h | 21 --- cpukit/sc

[PATCH 04/15] score: Add node adjust to _RBTree_Find_inline()

2016-04-05 Thread Sebastian Huber
--- cpukit/posix/include/rtems/posix/keyimpl.h | 14 ++ cpukit/posix/src/keygetspecific.c | 15 ++- cpukit/posix/src/keysetspecific.c | 29 + cpukit/score/include/rtems/score/rbtree.h | 12 4 files changed, 37 inse

[PATCH 07/15] rtems: Avoid Giant lock for partitions

2016-04-05 Thread Sebastian Huber
Use an ISR lock to protect the partition state changes. Update #2555. --- cpukit/rtems/include/rtems/rtems/part.h | 3 ++ cpukit/rtems/include/rtems/rtems/partimpl.h | 73 ++--- cpukit/rtems/src/partcreate.c | 15 +++--- cpukit/rtems/src/partdelete.c

[PATCH 05/15] score: Use red-black tree for active MP proxies

2016-04-05 Thread Sebastian Huber
Update #2555. --- cpukit/score/include/rtems/score/thread.h | 6 +- cpukit/score/include/rtems/score/threadmp.h | 29 + cpukit/score/src/threadmp.c | 162 +--- testsuites/sptests/spsize/size.c| 5 - 4 files changed, 106 insertions(+),

[PATCH 02/15] posix: Make _POSIX_signals_Check_signal() static

2016-04-05 Thread Sebastian Huber
--- cpukit/posix/Makefile.am | 2 +- cpukit/posix/include/rtems/posix/psignalimpl.h | 9 -- cpukit/posix/src/psignal.c | 74 cpukit/posix/src/psignalchecksignal.c | 113 - 4 files changed, 75 insertion

[PATCH 09/15] score: Delete _Chain_Append_with_empty_check()

2016-04-05 Thread Sebastian Huber
This function is not used in the score. Update #2555. --- cpukit/sapi/include/rtems/chain.h| 10 --- cpukit/sapi/src/chainprotected.c | 4 +-- cpukit/score/Makefile.am | 2 +- cpukit/score/include/rtems/score/chainimpl.h | 19 cpukit/

[PATCH 06/15] score: Use red-black tree for active global objects

2016-04-05 Thread Sebastian Huber
Use a red-black tree to lookup active global objects by identifier or name. Update #2555. --- cpukit/sapi/include/confdefs.h | 9 - cpukit/score/include/rtems/score/object.h | 46 ++- cpukit/score/include/rtems/score/objectimpl.h | 16 +- cpukit/score/include/rtems/score

[PATCH 08/15] score: Delete _Chain_Prepend()

2016-04-05 Thread Sebastian Huber
This function is not used in the score. Update #2555. --- cpukit/sapi/Makefile.am | 2 +- cpukit/sapi/include/rtems/chain.h| 10 -- cpukit/sapi/src/chainprotected.c | 139 +++ cpukit/sapi/src/chainsmp.c | 13

[PATCH 03/15] posix: Fix _POSIX_signals_Check_signal()

2016-04-05 Thread Sebastian Huber
Do not save and restore the thread wait information. This is superfluous and may overwrite thread wait information updates due to interrupts leading to system corruption. --- cpukit/posix/src/psignal.c | 31 +++ 1 file changed, 11 insertions(+), 20 deletions(-) diff -

[PATCH 14/15] score: Delete _Chain_Get()

2016-04-05 Thread Sebastian Huber
This function is not used in the score. Update #2555. --- cpukit/sapi/include/rtems/chain.h| 9 --- cpukit/sapi/src/chainprotected.c | 4 --- cpukit/score/Makefile.am | 1 - cpukit/score/include/rtems/score/chainimpl.h | 16 cpukit/s

[PATCH 01/15] posix: Use proper lock for signals

2016-04-05 Thread Sebastian Huber
--- cpukit/posix/src/killinfo.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/cpukit/posix/src/killinfo.c b/cpukit/posix/src/killinfo.c index a29a8e6..7a70539 100644 --- a/cpukit/posix/src/killinfo.c +++ b/cpukit/posix/src/killinfo.c @@ -75,6 +75,7 @@ int killin

[PATCH] score: Delete Thread_Wait_information::id

2016-04-05 Thread Sebastian Huber
This field was only by the monitor in non-multiprocessing configurations. Add new field Thread_Wait_information::remote_id in multiprocessing configurations and use it for the remote procedure call thread queue. Add _Thread_Wait_get_id() to obtain the object identifier for debug and system inform

[PATCH] cpukit: pppd: fix compile warning

2016-04-05 Thread Peng Fan
rcsid is defined, but not used. So discard it. Signed-off-by: Peng Fan --- cpukit/pppd/auth.c | 4 cpukit/pppd/ccp.c | 4 cpukit/pppd/chap.c | 4 cpukit/pppd/demand.c| 4 cpukit/pppd/fsm.c | 4 cpukit/pppd/ipcp.c | 4 cpukit/pppd/lcp.c