Re: [PATCH] [RTEMS] Update RTEMS thread model

2015-09-02 Thread Sebastian Huber
On 02/09/15 16:58, Martin Galvan wrote: On 02/09/2015 15:00, Sebastian Huber wrote: I deleted the test tree. It will take a couple of days before I create a new one. I think it makes more sense if you run the tests yourself, so that you can debug them. I use the realview_pbx_a9_qemu BSP for th

Re: [PATCH] [RTEMS] Update RTEMS thread model

2015-09-02 Thread Sebastian Huber
Committed: https://gcc.gnu.org/viewcvs/gcc?view=revision&revision=227428 -- Sebastian Huber, embedded brains GmbH Address : Dornierstr. 4, D-82178 Puchheim, Germany Phone : +49 89 189 47 41-16 Fax : +49 89 189 47 41-09 E-Mail : sebastian.hu...@embedded-brains.de PGP : Public key avai

[PATCH v2 2/5] tools/cpu/nios2/memory.c: Fix uninitialized use of variable memory

2015-09-02 Thread Martin Galvan
Updates #2405. --- tools/cpu/nios2/memory.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/tools/cpu/nios2/memory.c b/tools/cpu/nios2/memory.c index cd88b8b..cb1ea7f 100644 --- a/tools/cpu/nios2/memory.c +++ b/tools/cpu/nios2/memory.c @@ -18,7 +18,8 @@ memory_desc *find_m

[PATCH v2 1/5] various .h files: Add missing C++ extern wrappers

2015-09-02 Thread Martin Galvan
Updates #2405. --- c/src/lib/libbsp/shared/umon/umon.h | 4 cpukit/posix/include/rtems/posix/ptimer.h| 5 - cpukit/rtems/include/rtems/rtems/dpmemimpl.h | 6 +- 3 files changed, 13 insertions(+), 2 deletions(-) diff --git a/c/src/lib/libbsp/shared/umon/umon.h b/c/src/li

[PATCH v2 3/5] tools/cpu/nios2/ptf.c: Fix leak of memory pointed to by new_prefix

2015-09-02 Thread Martin Galvan
Updates #2405. --- tools/cpu/nios2/ptf.c | 24 ++-- 1 file changed, 14 insertions(+), 10 deletions(-) diff --git a/tools/cpu/nios2/ptf.c b/tools/cpu/nios2/ptf.c index 7a31c11..07d6183 100644 --- a/tools/cpu/nios2/ptf.c +++ b/tools/cpu/nios2/ptf.c @@ -567,17 +567,21 @@ void ptf

[PATCH v2 4/5] cpukit/libmisc/dumpbuf/dumpbuf.c: Fix undefined behavior for sprintf()

2015-09-02 Thread Martin Galvan
I also used the 'n' versions of the string functions, #define'd magic numbers and added a few comments. Updates #2405. --- cpukit/libmisc/dumpbuf/dumpbuf.c | 121 --- 1 file changed, 75 insertions(+), 46 deletions(-) diff --git a/cpukit/libmisc/dumpbuf/dumpbuf

[PATCH v2 5/5] cpukit/libnetworking/rtems/rtems_dhcp.c: Fix leak on realloc failure for dhcp_hostname.

2015-09-02 Thread Martin Galvan
Closes #2405. --- cpukit/libnetworking/rtems/rtems_dhcp.c | 18 +- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/cpukit/libnetworking/rtems/rtems_dhcp.c b/cpukit/libnetworking/rtems/rtems_dhcp.c index c938ee0..87be238 100644 --- a/cpukit/libnetworking/rtems/rtems_

Re: [PATCH] [RTEMS] Update RTEMS thread model

2015-09-02 Thread Martin Galvan
On Wed, Sep 2, 2015 at 12:01 PM, Daniel Gutson wrote: > > El 2/9/2015 11:58, "Martin Galvan" > escribió: >> >> On 02/09/2015 15:00, Sebastian Huber wrote: >> > I deleted the test tree. It will take a couple of days before I create a >> > new one. I think it makes more sense if you run the tests y

Re: [PATCH] [RTEMS] Update RTEMS thread model

2015-09-02 Thread Daniel Gutson
El 2/9/2015 11:58, "Martin Galvan" escribió: > > On 02/09/2015 15:00, Sebastian Huber wrote: > > I deleted the test tree. It will take a couple of days before I create a > > new one. I think it makes more sense if you run the tests yourself, so > > that you can debug them. I use the realview_pbx_a

Re: [PATCH] [RTEMS] Update RTEMS thread model

2015-09-02 Thread Martin Galvan
On 02/09/2015 15:00, Sebastian Huber wrote: > I deleted the test tree. It will take a couple of days before I create a > new one. I think it makes more sense if you run the tests yourself, so > that you can debug them. I use the realview_pbx_a9_qemu BSP for this, > since it is very easy to debug

Re: building RTEMS 4.11 leon3 with floating point support?

2015-09-02 Thread Gedare Bloom
On Wed, Sep 2, 2015 at 10:29 AM, Daniel Gutson wrote: > > El 2/9/2015 11:14, "Joel Sherrill" escribió: >> >> >> >> On 8/31/2015 5:47 AM, Cudmore, Alan P. (GSFC-5820) wrote: >>> >>> Having a floating point configuration of the BSP makes sense. I was able >>> to rebuild the BSP with the hardware fl

Re: building RTEMS 4.11 leon3 with floating point support?

2015-09-02 Thread Cudmore, Alan P. (GSFC-5820)
I have not analyzed it to determine what floating point code is being generated. As soon as we try to FTP to the board, it generates an FP trap on GRMON. When I enabled the floating point context support on the FTP task, it does not crash. But I agree, it is worth trying to figure out where the

Re: building RTEMS 4.11 leon3 with floating point support?

2015-09-02 Thread Daniel Gutson
El 2/9/2015 11:14, "Joel Sherrill" escribió: > > > > On 8/31/2015 5:47 AM, Cudmore, Alan P. (GSFC-5820) wrote: >> >> Having a floating point configuration of the BSP makes sense. I was able >> to rebuild the BSP with the hardware floating point compiler option and it >> works. >> >> I did get a fl

Re: [PATCH] Fix CppCheck errors

2015-09-02 Thread Joel Sherrill
On 9/2/2015 8:43 AM, Martin Galvan wrote: On Wed, Sep 2, 2015 at 10:39 AM, Gedare Bloom wrote: Joel, Coordinate your patch/fixes with this patch. (I do prefer the separate patches that Joel gave. Small atomic commits are better.) Gedare I thought he'd seen this e-mail :) I agree that small

Re: building RTEMS 4.11 leon3 with floating point support?

2015-09-02 Thread Joel Sherrill
On 8/31/2015 5:47 AM, Cudmore, Alan P. (GSFC-5820) wrote: Having a floating point configuration of the BSP makes sense. I was able to rebuild the BSP with the hardware floating point compiler option and it works. I did get a floating point exception in the FTP task and had to change the FTP ta

Re: [PATCH] Fix CppCheck errors

2015-09-02 Thread Martin Galvan
On Wed, Sep 2, 2015 at 10:39 AM, Gedare Bloom wrote: > Joel, > Coordinate your patch/fixes with this patch. (I do prefer the separate > patches that Joel gave. Small atomic commits are better.) > Gedare I thought he'd seen this e-mail :) I agree that small atomic commits are better. However, the

Re: [PATCH 3/4] tools/cpu/nios2/ptf.c: Fix leak of memory pointed to by new_prefix

2015-09-02 Thread Gedare Bloom
Martin's patch also checks for null new_prefix earlier. On Tue, Sep 1, 2015 at 5:40 PM, Joel Sherrill wrote: > Updates #2405. > --- > tools/cpu/nios2/ptf.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tools/cpu/nios2/ptf.c b/tools/cpu/nios2/ptf.c > index 7a31c11..2b9448c 100644 > ---

Re: [PATCH] Fix CppCheck errors

2015-09-02 Thread Gedare Bloom
Joel, Coordinate your patch/fixes with this patch. (I do prefer the separate patches that Joel gave. Small atomic commits are better.) Gedare On Wed, Sep 2, 2015 at 9:35 AM, Gedare Bloom wrote: > Apply to 4.11 and master > > On Wed, Sep 2, 2015 at 9:35 AM, Gedare Bloom wrote: >> Looks OK to me.

Re: cppcheck errors

2015-09-02 Thread Gedare Bloom
On Tue, Sep 1, 2015 at 5:43 PM, Joel Sherrill wrote: > > > On 9/1/2015 2:10 PM, Martin Galvan wrote: >> >> Hi everyone! >> >> I just ran CppCheck again on a fresh clone of the git repo and saw the >> number of error reports was quite smaller than what I reported before. >> That's because my previo

Re: [PATCH] Fix CppCheck errors

2015-09-02 Thread Gedare Bloom
Apply to 4.11 and master On Wed, Sep 2, 2015 at 9:35 AM, Gedare Bloom wrote: > Looks OK to me. > > On Tue, Sep 1, 2015 at 3:10 PM, Martin Galvan > wrote: >> This patch fixes the following CppCheck errors found throughout the code: >> >> [c/src/lib/libbsp/shared/umon/umon.h:21]: (error) Invalid n

Re: [PATCH] Fix CppCheck errors

2015-09-02 Thread Gedare Bloom
Looks OK to me. On Tue, Sep 1, 2015 at 3:10 PM, Martin Galvan wrote: > This patch fixes the following CppCheck errors found throughout the code: > > [c/src/lib/libbsp/shared/umon/umon.h:21]: (error) Invalid number of character > ({) when these macros are defined: '__cplusplus'. > [cpukit/libmisc

Re: [PATCH] [RTEMS] Update RTEMS thread model

2015-09-02 Thread Sebastian Huber
On 02/09/15 13:27, Daniel Gutson wrote: El 2/9/2015 5:17, "Sebastian Huber" > escribió: > > > > On 01/09/15 13:05, Sebastian Huber wrote: >> >> On 01/09/15 12:10, Sebastian Huber wrote: >>> >>> Shared mutexes are not implemented in general. >> >> >

Re: [PATCH] [RTEMS] Update RTEMS thread model

2015-09-02 Thread Sebastian Huber
On 02/09/15 13:32, Daniel Gutson wrote: El 2/9/2015 5:28, "Sebastian Huber" > escribió: > > > > On 02/09/15 02:50, Chris Johns wrote: >> >> On 1/09/2015 8:52 pm, Daniel Gutson wrote: >>> >>> > >>> >El 31/7/2015 3:28, "Chris Johns"

Re: [PATCH] [RTEMS] Update RTEMS thread model

2015-09-02 Thread Daniel Gutson
El 2/9/2015 5:28, "Sebastian Huber" escribió: > > > > On 02/09/15 02:50, Chris Johns wrote: >> >> On 1/09/2015 8:52 pm, Daniel Gutson wrote: >>> >>> > >>> >El 31/7/2015 3:28, "Chris Johns" >> >> escribió: >> >>On 31/07/2015 4:11 pm, Sebastian Huber wrote: >>

Re: [PATCH] [RTEMS] Update RTEMS thread model

2015-09-02 Thread Daniel Gutson
El 2/9/2015 5:17, "Sebastian Huber" escribió: > > > > On 01/09/15 13:05, Sebastian Huber wrote: >> >> On 01/09/15 12:10, Sebastian Huber wrote: >>> >>> Shared mutexes are not implemented in general. >> >> >> This works now also: >> >> https://gcc.gnu.org/ml/gcc-patches/2015-09/msg00027.html >> > >

Re: Outstanding Issues on 4.11 branch?

2015-09-02 Thread Sebastian Huber
Hello, On 01/08/15 19:17, Joel Sherrill wrote: Hi There are a couple of issues I know of like ticket 2376 (tftp ticket really needs a patch) and some site administration to do. But does anyone have any outstanding issues? we still have no up to date 4.11 manuals on the rtems.org website. I

Re: [PATCH] [RTEMS] Update RTEMS thread model

2015-09-02 Thread Sebastian Huber
On 02/09/15 02:50, Chris Johns wrote: On 1/09/2015 8:52 pm, Daniel Gutson wrote: > >El 31/7/2015 3:28, "Chris Johns" > escribió: >> >>On 31/07/2015 4:11 pm, Sebastian Huber wrote: >> >For synchronization objects use the self-contained objects available via >> >Newlib

Re: [PATCH] [RTEMS] Update RTEMS thread model

2015-09-02 Thread Sebastian Huber
On 01/09/15 13:05, Sebastian Huber wrote: On 01/09/15 12:10, Sebastian Huber wrote: Shared mutexes are not implemented in general. This works now also: https://gcc.gnu.org/ml/gcc-patches/2015-09/msg00027.html With this additional fix: https://gcc.gnu.org/ml/gcc/2015-09/msg00021.html We