[PATCH v2] ARMv7M: Fix exception handler for supporting FPU

2015-08-28 Thread Martin Galvan
On exception entry, _ARMV7M_Exception_default stores the previous Stack Pointer in a CPU_Exception_frame. The SP can be MSP or PSP, depending on the mode in which the exception was taken. To know this we must check the value of LR. Right now the code checks whether it should store MSP or PSP by co

Re: [PATCH] Fix exception handler for supporting FPU

2015-08-28 Thread sudarshan.rajagopalan
On 2015-08-28 17:18, Martin Galvan wrote: On Thu, Aug 27, 2015 at 3:53 PM, sudarshan.rajagopalan wrote: The instruction "cmn r2, #3\n" in line 31 basically compares the Link Register(lr) to value 0xFFFD (negative #3, because CMN negates the RHS and compares with LHS) and chooses MSP or PSP

Re: [PATCH] Fix exception handler for supporting FPU

2015-08-28 Thread Martin Galvan
On Thu, Aug 27, 2015 at 3:53 PM, sudarshan.rajagopalan wrote: > The instruction "cmn r2, #3\n" in line 31 basically compares the Link > Register(lr) to value 0xFFFD (negative #3, because CMN negates the RHS > and compares with LHS) and chooses MSP or PSP in the following IT block. > This is pr

Re: [PATCH] Fix exception handler for supporting FPU

2015-08-28 Thread sudarshan.rajagopalan
On 2015-08-28 13:44, Daniel Gutson wrote: On Fri, Aug 28, 2015 at 2:31 PM, sudarshan.rajagopalan wrote: On 2015-08-28 12:18, sudarshan.rajagopalan wrote: On 2015-08-28 11:30, Daniel Gutson wrote: On Fri, Aug 28, 2015 at 12:20 PM, Gedare Bloom wrote: Could you please open a ticket on our

Re: [PATCH] Fix exception handler for supporting FPU

2015-08-28 Thread Daniel Gutson
On Fri, Aug 28, 2015 at 2:31 PM, sudarshan.rajagopalan wrote: > On 2015-08-28 12:18, sudarshan.rajagopalan wrote: >> >> On 2015-08-28 11:30, Daniel Gutson wrote: >>> >>> On Fri, Aug 28, 2015 at 12:20 PM, Gedare Bloom wrote: Could you please open a ticket on our trac to describe the prob

Re: [PATCH] Fix exception handler for supporting FPU

2015-08-28 Thread sudarshan.rajagopalan
On 2015-08-28 12:18, sudarshan.rajagopalan wrote: On 2015-08-28 11:30, Daniel Gutson wrote: On Fri, Aug 28, 2015 at 12:20 PM, Gedare Bloom wrote: Could you please open a ticket on our trac to describe the problem this fixes, and add "closes #." to your patch commit message? Hi Gedare, Su

Re: ARMv7M Exception Handler

2015-08-28 Thread sudarshan.rajagopalan
On 2015-08-28 11:37, Daniel Gutson wrote: On Fri, Aug 28, 2015 at 12:33 PM, sudarshan.rajagopalan wrote: On 2015-08-27 17:06, Joel Sherrill wrote: On 8/27/2015 3:58 PM, Daniel Gutson wrote: On Thu, Aug 27, 2015 at 3:53 PM, sudarshan.rajagopalan wrote: Hey guys, I was working on the exce

Re: [PATCH] Fix exception handler for supporting FPU

2015-08-28 Thread sudarshan.rajagopalan
On 2015-08-28 11:30, Daniel Gutson wrote: On Fri, Aug 28, 2015 at 12:20 PM, Gedare Bloom wrote: Could you please open a ticket on our trac to describe the problem this fixes, and add "closes #." to your patch commit message? Hi Gedare, Sure will do! Additionally, please clarify which a

Re: ARMv7M Exception Handler

2015-08-28 Thread Daniel Gutson
On Fri, Aug 28, 2015 at 12:33 PM, sudarshan.rajagopalan wrote: > On 2015-08-27 17:06, Joel Sherrill wrote: >> >> On 8/27/2015 3:58 PM, Daniel Gutson wrote: >>> >>> On Thu, Aug 27, 2015 at 3:53 PM, sudarshan.rajagopalan >>> wrote: Hey guys, I was working on the exception handle

Re: ARMv7M Exception Handler

2015-08-28 Thread sudarshan.rajagopalan
On 2015-08-27 17:06, Joel Sherrill wrote: On 8/27/2015 3:58 PM, Daniel Gutson wrote: On Thu, Aug 27, 2015 at 3:53 PM, sudarshan.rajagopalan wrote: Hey guys, I was working on the exception handler for the CPU hard fault. Managed to register the fatal error user extension to RTEMS and call the

Re: [PATCH] Fix exception handler for supporting FPU

2015-08-28 Thread Daniel Gutson
On Fri, Aug 28, 2015 at 12:20 PM, Gedare Bloom wrote: > Could you please open a ticket on our trac to describe the problem > this fixes, and add "closes #." to your patch commit message? Additionally, please clarify which architecture this applies to. I suspect this is for cortex-m4. In any c

Re: cppcheck errors

2015-08-28 Thread Daniel Gutson
On Thu, Aug 27, 2015 at 6:38 PM, Joel Sherrill wrote: > > > On 8/27/2015 4:15 PM, Martin Galvan wrote: >> >> On Thu, Aug 27, 2015 at 6:10 PM, Daniel Gutson >> wrote: >>> >>> Maybe we can just provide the list until we provide the fixes? Martín? >> >> >> Gladly. Keep in mind we ran cppcheck only o

Re: obsolete m32r port

2015-08-28 Thread Gedare Bloom
Plesae check all obsoletes through users ml. On Thu, Aug 27, 2015 at 5:54 PM, Joel Sherrill wrote: > Hi > > Another one on my chopping block. I don't see the official > not recommended for new designs language but I also don't > seen much hinting an update in five years either. > > http://am.rene

Re: [PATCH] Fix exception handler for supporting FPU

2015-08-28 Thread Gedare Bloom
Could you please open a ticket on our trac to describe the problem this fixes, and add "closes #." to your patch commit message? Thanks, Gedare On Thu, Aug 27, 2015 at 4:33 PM, sudarshan.rajagopalan wrote: > Patch attached here for ARMv7M Exception Handler. Looks like git send-email > didn't