Re: [PATCH] rtems: rtems_interrupt_enable/flash/disable()

2015-06-18 Thread Sebastian Huber
On 12/06/15 22:26, Pavel Pisa wrote: Hello Sebastian and others, On Friday 12 of June 2015 17:47:42 Sebastian Huber wrote: - Gedare Bloom schrieb: I see. It provides the mutual exclusion for (SMP) applications that rely on interrupt_disable/enable locks? I guess we can never get rid of

Re: [rtems-libbsd commit] Add error() to the BSD program support.

2015-06-18 Thread Sebastian Huber
On 19/06/15 07:23, Chris Johns wrote: On 18/06/2015 5:54 pm, Sebastian Huber wrote: What is the reason for this #undef? I got warnings for printf in tcpdump for some reason so add the undef to all symbols present. Does it hurt having it present ? Yes, since in this case we don't get the r

Re: [rtems-libbsd commit] Add error() to the BSD program support.

2015-06-18 Thread Chris Johns
On 18/06/2015 5:54 pm, Sebastian Huber wrote: > >>> > >>> >What is the reason for this #undef? >>> > >> I got warnings for printf in tcpdump for some reason so add the undef to >> all symbols present. >> >> Does it hurt having it present ? >> > > Yes, since in this case we don't get the redefine

Re: [rtems-libbsd commit] Add BDS command support headers.

2015-06-18 Thread Chris Johns
On 18/06/2015 5:57 pm, Sebastian Huber wrote: > >>> Every RTEMS specific change should be in #ifdef __rtems__ sections. This >>> is very helpful if you have to review files. This is missing in a couple >>> of files. >> In tcpdump.c there is '#if __rtems__' and so you are asking these always >> be

Re: [rtems-libbsd commit] Add BDS command support headers.

2015-06-18 Thread Sebastian Huber
On 18/06/15 03:31, Chris Johns wrote: On 17/06/2015 9:17 pm, Sebastian Huber wrote: On 16/06/15 05:21, Chris Johns wrote: Module:rtems-libbsd Branch:master Commit:affed5e3f586860e2fd97445eaa20674dc4bcd25 Changeset: http://git.rtems.org/rtems-libbsd/commit/?id=affed5e3f586860e2fd9

Re: [rtems-libbsd commit] Add error() to the BSD program support.

2015-06-18 Thread Sebastian Huber
On 18/06/15 03:26, Chris Johns wrote: >>diff --git a/rtemsbsd/include/machine/rtems-bsd-program.h >>b/rtemsbsd/include/machine/rtems-bsd-program.h >>index b2e542e..7c2837e 100644 >>--- a/rtemsbsd/include/machine/rtems-bsd-program.h >>+++ b/rtemsbsd/include/machine/rtems-bsd-program.h >>@@ -56,6

Re: [rtems-libbsd commit] The BPF dev node needs a minor number for tcpdump.

2015-06-18 Thread Sebastian Huber
On 18/06/15 03:24, Chris Johns wrote: On 17/06/2015 9:08 pm, Sebastian Huber wrote: This breaks the DHCP client. I will fix this ... ruru chris $ ls -las /dev/bpf* 0 crw--- 1 root wheel 0xc Jun 9 10:45 /dev/bpf 0 lrwxr-xr-x 1 root wheel3 Jun 9 10:45 /dev/bpf0 -> bpf Looks lik