Re: [PATCH 1/2] i386/pc386/VESA framebuffer driver: modified and extended initialization options

2015-05-19 Thread Pavel Pisa
Hello Gedare, the first thanks for review. On Tuesday 19 of May 2015 19:11:13 Jan Dolezal wrote: > Hello Gedare, > thank you for the swift response.. > > On 19.5.2015 17:38, Gedare Bloom wrote: > > On Tue, May 19, 2015 at 10:34 AM, Jan Dolezal wrote: > >> driver is not initialized by default >

Re: [PATCH 1/2] i386/pc386/VESA framebuffer driver: modified and extended initialization options

2015-05-19 Thread Gedare Bloom
On Tue, May 19, 2015 at 1:19 PM, Gedare Bloom wrote: > On Tue, May 19, 2015 at 1:09 PM, Jan Dolezal wrote: >> Hello Gedare, >> thank you for the swift response.. >> >> >> On 19.5.2015 17:38, Gedare Bloom wrote: >>> >>> On Tue, May 19, 2015 at 10:34 AM, Jan Dolezal >>> wrote: driver is

Re: [PATCH 1/2] i386/pc386/VESA framebuffer driver: modified and extended initialization options

2015-05-19 Thread Gedare Bloom
On Tue, May 19, 2015 at 1:09 PM, Jan Dolezal wrote: > Hello Gedare, > thank you for the swift response.. > > > On 19.5.2015 17:38, Gedare Bloom wrote: >> >> On Tue, May 19, 2015 at 10:34 AM, Jan Dolezal >> wrote: >>> >>> driver is not initialized by default >>> initialization is possible through

Re: [PATCH 1/2] i386/pc386/VESA framebuffer driver: modified and extended initialization options

2015-05-19 Thread Jan Dolezal
Hello Gedare, thank you for the swift response.. On 19.5.2015 17:38, Gedare Bloom wrote: On Tue, May 19, 2015 at 10:34 AM, Jan Dolezal wrote: driver is not initialized by default initialization is possible through multiboot command line option or through string variable set in user's module al

Re: [PATCH 2/2] i386/pc386: default graphics driver changed from VGA to VESA based

2015-05-19 Thread Gedare Bloom
This one looks fine. On Tue, May 19, 2015 at 10:34 AM, Jan Dolezal wrote: > basic VGA driver can be enabled during configure phase by exporting variable > USE_VGA=1 so that it is available in configure environment > cirrus driver is enabled the same way by exporting variable > USE_CIRRUS_GD5446=1

Re: [PATCH 1/2] i386/pc386/VESA framebuffer driver: modified and extended initialization options

2015-05-19 Thread Gedare Bloom
On Tue, May 19, 2015 at 10:34 AM, Jan Dolezal wrote: > driver is not initialized by default > initialization is possible through multiboot command line option or > through string variable set in user's module allowing the driver > to evaluate this variable after the two modules are linked together

[PATCH 2/2] i386/pc386: default graphics driver changed from VGA to VESA based

2015-05-19 Thread Jan Dolezal
basic VGA driver can be enabled during configure phase by exporting variable USE_VGA=1 so that it is available in configure environment cirrus driver is enabled the same way by exporting variable USE_CIRRUS_GD5446=1 --- c/src/lib/libbsp/i386/pc386/Makefile.am | 12 +- c/src/lib/libbsp/i3

[PATCH 1/2] i386/pc386/VESA framebuffer driver: modified and extended initialization options

2015-05-19 Thread Jan Dolezal
driver is not initialized by default initialization is possible through multiboot command line option or through string variable set in user's module allowing the driver to evaluate this variable after the two modules are linked together --- c/src/lib/libbsp/i386/pc386/console/fb_vesa_rm.c | 152 +