Re: [PATCH 4/4 v2] SPARC: optimize IRQ enable & disable

On 24/11/14 16:30, Gedare Bloom wrote: + /* >+ * SW Trap 9-15 Reserved for Operating System >+ */ >+ IRQDIS_TRAP(0x89, SYM(syscall_irqdis)); ! 89 IRQ Disable syscall trap >+ IRQEN_TRAP(0x8A, SYM(syscall_irqen));! 8A IRQ Enable syscall trap This should be 0x80 + SP

[PATCH 7/7] smp09: Resolve missing prototype warning.

--- testsuites/smptests/smp09/init.c | 8 1 file changed, 8 insertions(+) diff --git a/testsuites/smptests/smp09/init.c b/testsuites/smptests/smp09/init.c index 8cf019c..d0ea3f7 100644 --- a/testsuites/smptests/smp09/init.c +++ b/testsuites/smptests/smp09/init.c @@ -19,6 +19,14 @@ const

[PATCH 6/7] smp07: Resolve missing prototype warning.

--- testsuites/smptests/smp07/init.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/testsuites/smptests/smp07/init.c b/testsuites/smptests/smp07/init.c index fabf722..c26669a 100644 --- a/testsuites/smptests/smp07/init.c +++ b/testsuites/smptests/smp07/init.c @@ -20,

[PATCH 5/7] smp05: Resolve missing prototype warning.

--- testsuites/smptests/smp05/init.c | 9 + 1 file changed, 9 insertions(+) diff --git a/testsuites/smptests/smp05/init.c b/testsuites/smptests/smp05/init.c index 06e6254..424e9df 100644 --- a/testsuites/smptests/smp05/init.c +++ b/testsuites/smptests/smp05/init.c @@ -16,6 +16,15 @@ co

[PATCH 4/7] smp02: Resolve unused method warnings.

--- testsuites/smptests/smp02/tasks.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/testsuites/smptests/smp02/tasks.c b/testsuites/smptests/smp02/tasks.c index 26ca851..22caf77 100644 --- a/testsuites/smptests/smp02/tasks.c +++ b/testsuites/smptests/smp02/tasks.c @@ -

[PATCH 3/7] smp03: Remove set but not used warning.

Added status validation. --- testsuites/smptests/smp03/init.c | 4 1 file changed, 4 insertions(+) diff --git a/testsuites/smptests/smp03/init.c b/testsuites/smptests/smp03/init.c index 4b443d0..03eddb0 100644 --- a/testsuites/smptests/smp03/init.c +++ b/testsuites/smptests/smp03/init.c @@ -

[PATCH 2/7] smpschedsem01: Remove unused variable warning.

--- testsuites/smptests/smpschedsem01/init.c | 1 - 1 file changed, 1 deletion(-) diff --git a/testsuites/smptests/smpschedsem01/init.c b/testsuites/smptests/smpschedsem01/init.c index 894ba81..3ef9ab1 100644 --- a/testsuites/smptests/smpschedsem01/init.c +++ b/testsuites/smptests/smpschedsem01/

[PATCH 1/7] smpschedaffinity02: Remove unused prototype.

--- testsuites/smptests/smpschedaffinity02/init.c | 1 - 1 file changed, 1 deletion(-) diff --git a/testsuites/smptests/smpschedaffinity02/init.c b/testsuites/smptests/smpschedaffinity02/init.c index 5f22110..1b81f6b 100644 --- a/testsuites/smptests/smpschedaffinity02/init.c +++ b/testsuites/smp

Re: [PATCH 2/2] sparc/leon2: LEON_Is_interrupt_masked for Leon2 in leon.h wrongly defined

Ok, Thanks! DanielH On 24 November 2014 17:15:03 CET, Jiri Gaisler wrote: >On 11/24/2014 05:02 PM, Daniel Hellstrom wrote: >> Ok, what about ERC32 which has the same macros? > >ERC32 is correctly defined. The leon2/3 were wrong because the >defines were copied from ERC32, but the mask bits have

Re: /etc/issue vs /etc/issue.net in shell.c

On 11/24/2014 1:12 AM, Sebastian Huber wrote: > On 22/11/14 04:36, Joel Sherrill wrote: >> On November 21, 2014 5:50:08 PM CST, Chris Johns wrote: On 22/11/2014 1:53 am, Joel Sherrill wrote: >> On 11/21/2014 1:38 AM, Sebastian Huber wrote: On 20/11/14 22:08, Joel Sherrill wrote:

Re: [PATCH 2/2] sparc/leon2: LEON_Is_interrupt_masked for Leon2 in leon.h wrongly defined

On 11/24/2014 05:02 PM, Daniel Hellstrom wrote: > Ok, what about ERC32 which has the same macros? ERC32 is correctly defined. The leon2/3 were wrong because the defines were copied from ERC32, but the mask bits have opposite meaning ... Jiri. > > On 11/24/2014 04:41 PM, Gedare Bloom wrote: >> D

Re: [PATCH 2/2] sparc/leon2: LEON_Is_interrupt_masked for Leon2 in leon.h wrongly defined

Ok, what about ERC32 which has the same macros? On 11/24/2014 04:41 PM, Gedare Bloom wrote: Daniel commit these if you agree with the assessment. On Sun, Nov 23, 2014 at 4:53 PM, Jiri Gaisler wrote: Condition needs to be inverted, as a 1 in the mask register means that the interrupt

Re: [PATCH 2/2] sparc/leon2: LEON_Is_interrupt_masked for Leon2 in leon.h wrongly defined

Daniel commit these if you agree with the assessment. On Sun, Nov 23, 2014 at 4:53 PM, Jiri Gaisler wrote: > Condition needs to be inverted, as a 1 in the mask register means > that the interrupt is enabled. Solves ticket #1959 in trac. > --- > c/src/lib/libbsp/sparc/leon2/include/leon.h

Re: [PATCH 4/4 v2] SPARC: optimize IRQ enable & disable

On 11/24/2014 04:29 PM, Gedare Bloom wrote: On Mon, Nov 24, 2014 at 5:15 AM, Daniel Hellstrom wrote: * Coding style cleanups. * Use OS reserved trap 0x89 for IRQ Disable * Use OS reserved trap 0x8A for IRQ Enable This will result in faster Disable/Enable code since the system trap handler does

Re: [PATCH 4/4 v2] SPARC: optimize IRQ enable & disable

On Mon, Nov 24, 2014 at 5:15 AM, Daniel Hellstrom wrote: > * Coding style cleanups. > * Use OS reserved trap 0x89 for IRQ Disable > * Use OS reserved trap 0x8A for IRQ Enable > > This will result in faster Disable/Enable code since the > system trap handler does not need to decode which function >

[PATCH 4/4 v2] SPARC: optimize IRQ enable & disable

* Coding style cleanups. * Use OS reserved trap 0x89 for IRQ Disable * Use OS reserved trap 0x8A for IRQ Enable This will result in faster Disable/Enable code since the system trap handler does not need to decode which function the user wants. Besides the IRQ disable/enabled can now be inline whic