Re: Coverity Issue with bdbuf.c

On 20/11/2014 2:10 pm, Joel Sherrill wrote: On November 19, 2014 8:37:47 PM CST, Gedare Bloom wrote: I'm more concerned with the hard-coded cache alignment value, than I am with the dead code. The code is likely not doing what the surge intended but Chris needs to comment on that bases on

Re: Coverity Issue with bdbuf.c

On November 19, 2014 8:37:47 PM CST, Gedare Bloom wrote: >I'm more concerned with the hard-coded cache alignment value, than I >am with the dead code. The code is likely not doing what the surge intended but Chris needs to comment on that bases on git blame. :) Definitely questionable having

Re: [PATCH 4/4] libtests/malloctest/init.c: Fix warning

On Wed, Nov 19, 2014 at 9:35 PM, Joel Sherrill wrote: > > > On November 19, 2014 8:34:23 PM CST, Gedare Bloom wrote: >>I'd prefer to see it hidden behind a macro, like other >>compiler-specific stuff (e.g. attributes). It could go in tmacros >>also, since it should be restricted to testing. > > C

Re: Coverity Issue with bdbuf.c

I'm more concerned with the hard-coded cache alignment value, than I am with the dead code. -Gedare On Wed, Nov 19, 2014 at 6:10 PM, Joel Sherrill wrote: > Hi > > Coverity ID: 1255327 > > I think this looks like a legitimately flagged piece of code : > > 1537 * For unspecified cache alignments

Re: [PATCH 2/4] sys/mman.h: New file. Clean up and add supporting stubs

On November 19, 2014 8:31:46 PM CST, Gedare Bloom wrote: >OK great I have an updated version of the patch. Something wasn't right with the mskefile that showed up later. Not sure how it built before. :( >On Wed, Nov 19, 2014 at 5:04 PM, Joel Sherrill > wrote: >> >> On 11/19/2014 2:55 PM, Ge

Re: [PATCH 4/4] libtests/malloctest/init.c: Fix warning

On November 19, 2014 8:34:23 PM CST, Gedare Bloom wrote: >I'd prefer to see it hidden behind a macro, like other >compiler-specific stuff (e.g. attributes). It could go in tmacros >also, since it should be restricted to testing. Can you write this as a macro? >I will oppose any #pragma within

Re: [PATCH 4/4] libtests/malloctest/init.c: Fix warning

I'd prefer to see it hidden behind a macro, like other compiler-specific stuff (e.g. attributes). It could go in tmacros also, since it should be restricted to testing. I will oppose any #pragma within cpukit or c subdirectories. -Gedare On Wed, Nov 19, 2014 at 5:45 PM, Joel Sherrill wrote: > >

Re: [PATCH 2/4] sys/mman.h: New file. Clean up and add supporting stubs

OK great On Wed, Nov 19, 2014 at 5:04 PM, Joel Sherrill wrote: > > On 11/19/2014 2:55 PM, Gedare Bloom wrote: >> Is this the same one that Chris has had in use before? (I think that >> is who had one in use..) > Yes. You wanted it in rtems to avoid me having to add a prototype to a file > to avoi

Re: [PATCH] more data structures public in mongoose.h

On Wed, 2014-11-19 at 19:16 +0100, Ben Gras wrote: > The attached patch is a proposed solution to a problem I am having > with interfacing with the mongoose httpd for which I've found no > canonical (or any other) clean solution. > > The problem is that some of the data structures needed for some

Coverity ID 26083 shell.c

Hi I think this also likely indicates an issue in shell.c and/or login_prompt.c. 644 CID 26083 (#1 of 1): Dereference after null check (FORWARD_NULL)4. var_deref_model: Passing null pointer out to rtems_shell_login_prompt, which dereferences it. [hide details

Coverity Issue with bdbuf.c

Hi Coverity ID: 1255327 I think this looks like a legitimately flagged piece of code : 1537 * For unspecified cache alignments we use the CPU alignment. 1538 */ assignment: Assigning: cache_aligment = 32U. 1539 cache_aligment = 32; /* FIXME rtems_cache_get_data_line_size() */ cons

Re: Access Control for RTEMS Shell

On 11/19/2014 4:54 PM, Peter Dufault wrote: > Are the UID and GID per-thread? I assume two different telnet sessions would > have different credentials. They can and do now if you want to try the telnetd example. There is an rtems and a root account as I recall. One can't write to parts of the f

Re: Access Control for RTEMS Shell

Are the UID and GID per-thread? I assume two different telnet sessions would have different credentials. I strongly agree that there is a need for credentials in embedded applications, but I don't see that they can be tied to the RTEMS shell. I'm not sure how UID and GID work in a single proc

Re: [PATCH 4/4] libtests/malloctest/init.c: Fix warning

On 11/19/2014 4:32 PM, Chris Johns wrote: > On 20/11/2014 6:59 am, Joel Sherrill wrote: >> + #pragma GCC diagnostic push >> + #pragma GCC diagnostic ignored "-Wnonnull" > Do we allow the use of #pragma in RTEMS ? I would say no except for this one particular class. If a method has the proper p

Re: [PATCH 4/4] libtests/malloctest/init.c: Fix warning

On 20/11/2014 6:59 am, Joel Sherrill wrote: + #pragma GCC diagnostic push + #pragma GCC diagnostic ignored "-Wnonnull" Do we allow the use of #pragma in RTEMS ? Chris ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/de

Re: [PATCH 2/4] sys/mman.h: New file. Clean up and add supporting stubs

On 11/19/2014 2:55 PM, Gedare Bloom wrote: > Is this the same one that Chris has had in use before? (I think that > is who had one in use..) Yes. You wanted it in rtems to avoid me having to add a prototype to a file to avoid a warning. I didn't integrate his implementation but only his .h file a

Re: [PATCH] more data structures public in mongoose.h

On Wed, Nov 19, 2014 at 3:07 PM, Joel Sherrill wrote: > Just to be clear, I approve Ben's patch with mg_ prefix. :) > > But long term, I want to see us consider moving the TCP/IP > to an external package so we can have IPV4, IPV4/V6, and > LWIP as options. Then layer various web services as RSB >

Re: [PATCH 2/4] sys/mman.h: New file. Clean up and add supporting stubs

Is this the same one that Chris has had in use before? (I think that is who had one in use..) -Gedare On Wed, Nov 19, 2014 at 2:59 PM, Joel Sherrill wrote: > * Makefile.am updated and preinstall.am regenerated. > * mprotect.c had a prototype removed now that we have mman.h >

Re: [PATCH] more data structures public in mongoose.h

Just to be clear, I approve Ben's patch with mg_ prefix. :) But long term, I want to see us consider moving the TCP/IP to an external package so we can have IPV4, IPV4/V6, and LWIP as options. Then layer various web services as RSB packages on top of that. That would also let us support the Mongo

[PATCH 4/4] libtests/malloctest/init.c: Fix warning

posix_memalign() is prototyped to take a non-NULL parameter. But our test is deliberately passing one in. With the -Wnon-null warning flag enabled, we will always get warnings on this test unless we disable that warning for this single test case. --- testsuites/libtests/malloctest/init.c | 24

[PATCH 3/4] libdl/rtl-mdreloc-powerpc.c: Fix warnings

This patch addresses the following warnings: + The variable "target" was unused. + The parentheses in the expression around line 72 were ambiguous. --- cpukit/libdl/rtl-mdreloc-powerpc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/cpukit/libdl/rtl-mdreloc-powerpc.c b

[PATCH 2/4] sys/mman.h: New file. Clean up and add supporting stubs

* Makefile.am updated and preinstall.am regenerated. * mprotect.c had a prototype removed now that we have mman.h * mmap.c, munmap.c: New stub files. --- cpukit/posix/Makefile.am| 5 ++ cpukit/posix/include/sys/mman.h | 189

[PATCH 1/4] libdl/.../mips/machine/elf_machdep.h: Fix typo so compiles

--- cpukit/libdl/include/arch/mips/machine/elf_machdep.h | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/cpukit/libdl/include/arch/mips/machine/elf_machdep.h b/cpukit/libdl/include/arch/mips/machine/elf_machdep.h index d27d431..26700ce 100644 --- a/cpukit/libdl/include/

Re: [PATCH] more data structures public in mongoose.h

On 11/19/2014 1:24 PM, Gedare Bloom wrote: > Hi Ben, > > Due to the license change, we can consider our version of Mongoose as > "RTEMS Project" maintained for now. I don't know if anyone is > maintaining a fork with an appropriate license. There is a fork with the appropriate license. https://gi

Intel Edison board anyone?

Hi Anyone tried RTEMS on one of these yet and want to pass along tips and pointers? -- Joel Sherrill, Ph.D. Director of Research & Development joel.sherr...@oarcorp.comOn-Line Applications Research Ask me about RTEMS: a free RTOS Huntsville AL 35805 Support Available

Re: [PATCH] more data structures public in mongoose.h

That is a good point. Shall I change the patch to use mg_* prefixes for all globally visible type names? On Wed, Nov 19, 2014 at 8:24 PM, Gedare Bloom wrote: > Hi Ben, > > Due to the license change, we can consider our version of Mongoose as > "RTEMS Project" maintained for now. I don't know if

Re: [PATCH] more data structures public in mongoose.h

Hi Ben, Due to the license change, we can consider our version of Mongoose as "RTEMS Project" maintained for now. I don't know if anyone is maintaining a fork with an appropriate license. Moving the struct definitions to the header file is sensible, although the usual caveat is that users might h

Re: [PATCH 4/4] SPARC: optimize IRQ enable & disable

This one needs a release note as it may impede some applications if they assumed they could use these trap vectors. Also, do these changes complicate the paravirtualization efforts done with sparc32 for xtratum? Otherwise, quick skim of the patch series looked good. On Wed, Nov 19, 2014 at 10:35

Re: RTEMS Rehosting Update

On 20/11/2014 4:41 am, Hesham Moustafa wrote: + www.rtems.org is alive there. (accept the certificate) + mailing lists never went down. They had been relocated months ago. This one is still down for me even after I accept the certificate. Make sure

[PATCH] more data structures public in mongoose.h

The attached patch is a proposed solution to a problem I am having with interfacing with the mongoose httpd for which I've found no canonical (or any other) clean solution. The problem is that some of the data structures needed for some operations, specifically writing callbacks that get invoked f

Re: RTEMS Rehosting Update

Hi, On Wed, Nov 19, 2014 at 5:01 PM, Joel Sherrill wrote: > Hi > > I am sure you all have noticed that the RTEMS Project has had > a lot of services offline for the past week. This has been part > of a rehosting and improvement effort that simply took longer > than anyone expected. > > At this p

Re: epiphany-rtems4.11-gcc: error: unrecognized command line option ‘-qnolinkcmds’

On Wed, Nov 19, 2014 at 4:08 PM, Joel Sherrill wrote: > > On 11/19/2014 10:04 AM, Hesham Moustafa wrote: > > Hi, > > > > I have been working on getting Epiphany toolchain built for RTEMS, and > > then compile mninmal RTEMS code. Once issue I face now is that I got > > this error: > > "epiphany-rt

RTEMS Rehosting Update

Hi I am sure you all have noticed that the RTEMS Project has had a lot of services offline for the past week. This has been part of a rehosting and improvement effort that simply took longer than anyone expected. At this point, most of the services are back online at the Oregon State University O

Re: epiphany-rtems4.11-gcc: error: unrecognized command line option ‘-qnolinkcmds’

On 11/19/2014 10:04 AM, Hesham Moustafa wrote: > Hi, > > I have been working on getting Epiphany toolchain built for RTEMS, and > then compile mninmal RTEMS code. Once issue I face now is that I got > this error: > "epiphany-rtems4.11-gcc: error: unrecognized command line option > ‘-qnolinkcmds’"

New Coverity Scan Results Posted

Hi It has been a while but since Josh and I have been looking at output from CodeSonar, I thought it would be a good idea to get new code pushed at Coverity Scan as a point of comparison. Based on my filtering of ignored and closed issues, I think there are 33 Coverity issues outstanding. Most ap

epiphany-rtems4.11-gcc: error: unrecognized command line option ‘-qnolinkcmds’

Hi, I have been working on getting Epiphany toolchain built for RTEMS, and then compile mninmal RTEMS code. Once issue I face now is that I got this error: "epiphany-rtems4.11-gcc: error: unrecognized command line option ‘-qnolinkcmds’" Is that something I have to add to the GCC port, or I can wo

[PATCH 4/4] SPARC: optimize IRQ enable & disable

* Coding style cleanups. * Use OS reserved trap 0x89 for IRQ Disable * Use OS reserved trap 0x8A for IRQ Enable This will result in faster Disable/Enable code since the system trap handler does not need to decode which function the user wants. Besides the IRQ disable/enabled can now be inline whic

[PATCH 2/4] SPARC: optimize window overflow trap entry

By using a optimized trap entry we can move instructions from the window overflow function into the trap entry vector. By using the saved locals instead of g1 we don't need to save that register temporarily. Also spead out non store instructions inbetween stores to use the write buffer better. ---

[PATCH 1/4] SPARC: window overflow optimization

I see no need for waiting the 3 instruction delay for wim to be written in this case, since the STD after does not depend on WIM --- c/src/lib/libcpu/sparc/reg_win/window.S |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/c/src/lib/libcpu/sparc/reg_win/window.S b/c/src/lib

[PATCH 3/4] SPARC: optimize window underflow trap

Save five instructions on underflow handling. By using an optimized trap entry we can move instructions from the window underflow function into the trap entry vector. By setting WIM=0 and using RESTORE it is possible to move the new WIM register content from the trapped window into the to-be-resto

[PATCH 1/1] spcpuset01: fix test comments

--- testsuites/sptests/spcpuset01/init.c |6 +- testsuites/sptests/spcpuset01/spcpuset01.doc |2 +- testsuites/sptests/spcpuset01/spcpuset01.scn | 130 +- 3 files changed, 69 insertions(+), 69 deletions(-) diff --git a/testsuites/sptests/spcpuset01/init.c

Re: [PATCH 1/3] smpschedaffinity02: Change semaphore attributes.

Hello, All three patches have whitespace on "RTEMS_PRIORITY | " below. Otherwise it looks good. Thanks! On 11/13/2014 07:15 PM, Jennifer Averett wrote: Change semaphore attributes to prevent semaphore from being locked and never released upon a context switch. --- testsuites/smptests/smpsc

Re: bootstrap issue | subdir-objects needs to be enabled | Fedora 21

On Wed, Nov 19, 2014 at 2:01 PM, Joel Sherrill wrote: > > > On November 19, 2014 7:55:24 AM CST, Hesham Moustafa < > heshamelmat...@gmail.com> wrote: > >Hi all, > > > >I have for just forked a vanilla RTEMS repo. This is the first time for > >me to build RTEMS after I have upgraded to Fedora 21.

Re: bootstrap issue | subdir-objects needs to be enabled | Fedora 21

On November 19, 2014 7:55:24 AM CST, Hesham Moustafa wrote: >Hi all, > >I have for just forked a vanilla RTEMS repo. This is the first time for >me to build RTEMS after I have upgraded to Fedora 21. > >When I run ./boostrap I got the following warning: > >Makefile.am:27: warning: source file '.

bootstrap issue | subdir-objects needs to be enabled | Fedora 21

Hi all, I have for just forked a vanilla RTEMS repo. This is the first time for me to build RTEMS after I have upgraded to Fedora 21. When I run ./boostrap I got the following warning: Makefile.am:27: warning: source file '../../shared/bsplibc.c' is in a subdirectory, Makefile.am:27: but option