Re: -Werror vs. NetBSD

2016-02-04 Thread Chris Newman
Why not just add -std=gnu99 to the gcc switches so the code can at least use the 16-year old version of the C standard? - Chris On February 3, 2016 at 17:59:14 , Martin Thomson (m...@mozilla.com) wrote: Yes, the landing of the first patches for TLS 1.3 was a bit messy. We are w

Re: -Werror vs. NetBSD

2016-02-04 Thread Martin Thomson
Yes, the landing of the first patches for TLS 1.3 was a bit messy. We are working on fixing these problems. We do have a requirement for c99, which might account for the //comments. We are trying not to land any of those though. On Feb 4, 2016 8:27 PM, "Thomas Klausner" wrote: > Hi Martin! >

Re: -Werror vs. NetBSD

2016-02-04 Thread Thomas Klausner
Hi Martin! Thanks for the reply. Yes, of course I can file a bug report for that. I guess I should finish the patch first? For two days now, I see a different build failure though: gcc -o NetBSD7.99.26_64_OPT.OBJ/tls13hkdf.o -c -O -fPIC -DPIC -ansi -Wall -Wno-switch -pipe -DNETBSD -Dunix -DHA

Re: -Werror vs. NetBSD

2016-01-31 Thread Martin Thomson
Hi Thomas, Do you think that you could push these patches to bugzilla? See https://bugzilla.mozilla.org/enter_bug.cgi?product=NSS&component=Libraries And it would be easier to review this as a single patch, I think, since all the changes are fairly simple. On Sat, Jan 30, 2016 at 11:40 PM, Thom

-Werror vs. NetBSD

2016-01-31 Thread Thomas Klausner
Hi! Recently nss turned on -Werror by default for all platforms. I think that's a good idea. However, it majorly broke the build on NetBSD with lots of these types of messages: certcgi.c: In function 'MakeNameConstraints': certcgi.c:1654:6: error: array subscript has type 'char' [-Werror=char-su