[dev-servo] Should commits landed in servo individually pass all tests?

2017-11-02 Thread Manish Goregaokar
So I and emilio were discussing whether or not to squash https://github.com/servo/servo/pull/18750 and it seemed like we have different ideas of how "atomic" commits should be before landing. When we land pull requests in servo/servo we like individual commits to build so that git bisect works. D

Re: [dev-servo] Should commits landed in servo individually pass all tests?

2017-11-02 Thread Gregory Szorc
On Thu, Nov 2, 2017 at 5:00 PM, Manish Goregaokar wrote: > So I and emilio were discussing whether or not to squash > https://github.com/servo/servo/pull/18750 and it seemed like we have > different ideas of how "atomic" commits should be before landing. > > When we land pull requests in servo/se

Re: [dev-servo] Should commits landed in servo individually pass all tests?

2017-11-02 Thread Emilio Cobos Álvarez
Hi Manish, On 11/03/2017 01:00 AM, Manish Goregaokar wrote: > So I and emilio were discussing whether or not to squash > https://github.com/servo/servo/pull/18750 and it seemed like we have > different ideas of how "atomic" commits should be before landing. First of all thanks for landing that PR