[dev-servo] Fwd: Re: Suggested code review workflow

2016-02-20 Thread Josh Matthews
-- Forwarded message -- From: "smaug" Date: Feb 20, 2016 4:33 PM Subject: Re: Suggested code review workflow To: "Josh Matthews" Cc: On 02/13/2016 07:26 AM, Josh Matthews wrote: > On 2016-02-12 6:16 PM, Olaf Buddenhagen wrote: > >> Hi, >> >> On Wed, Feb 03, 2016 at 02:21:46PM -0

Re: [dev-servo] Fwd: Re: Suggested code review workflow

2016-02-20 Thread Boris Zbarsky
On 2/20/16 5:10 PM, Josh Matthews wrote: (as a random comment, I never read multiline comments for Gecko. Only the first line + the bug number. It is the bug where the relevant information needs to be available. Whether it it available also elsewhere is less important, IMHO.) Having the info in

Re: [dev-servo] Fwd: Re: Suggested code review workflow

2016-02-20 Thread Lars Bergstrom
This may also be less of a big deal here at Mozilla, where there's (presumably?) only been one bug database since 1998 and will only be one forever, but when I was at MS, I had to make accessibility fixes in some code that was a bit more than 20 years old, and "fixes B1#2003" is really tough to tra