Re: [dev-servo] Planning to experiment with inline storage for DOMString / webidl binding codegen

2015-12-02 Thread Nick Fitzgerald
And there is also ArrayString[0] from the arrayvec crate[1]. I was considering reusing this and getting rid of the fixed size `InlineString` I rolled myself as ArrayString is almost identical. [0] http://bluss.github.io/arrayvec/doc/arrayvec/struct.ArrayString.html [1] https://crates.io/crates/arr

Re: [dev-servo] Planning to experiment with inline storage for DOMString / webidl binding codegen

2015-12-02 Thread Alan Jeffrey
Well, I tried eliminating the buffering, but I still didn't get any perf benefit, if anything there was a degrade. Sigh. https://github.com/asajeffrey/servo/commit/1533238eb822688572a04d5bd6eb8ac88297 On Wed, Dec 2, 2015 at 10:49 AM, Nick Fitzgerald wrote: > And there is also ArrayString[0]

Re: [dev-servo] Planning to experiment with inline storage for DOMString / webidl binding codegen

2015-12-02 Thread Andrew McCreight
For what it is worth, Gecko uses a single-entry per-zone cache for converting the result of JS strings to DOM strings in getAttribute (I think). bz added this in bug 773520, and it has had a few refinements since then. Maybe some kind of caching would help Servo, too. Andrew On Wed, Dec 2, 2015 a

Re: [dev-servo] Planning to experiment with inline storage for DOMString / webidl binding codegen

2015-12-02 Thread Alan Jeffrey
Yes, this is on my list of things to think about. On Wed, Dec 2, 2015 at 3:23 PM, Andrew McCreight wrote: > For what it is worth, Gecko uses a single-entry per-zone cache for > converting the result of JS strings to DOM strings in getAttribute (I > think). bz added this in bug 773520, and it has

[dev-servo] Error in Building Servo on Fedora 22 32 bit

2015-12-02 Thread JIGAR SHARDA
Hi, I am trying to build servo on Fedora 22 32 bit and while doing that I am getting the following error log with verbose flag. __ home/jigar/servo/components/script/lib.rs:72:1: 72:20 error: couldn't find crate `style` with expected targ

Re: [dev-servo] Error in Building Servo on Fedora 22 32 bit

2015-12-02 Thread Josh Matthews
I've never seen an error like this before, but my first instinct is to suggest `rm -rf target/ && ./mach build` to see if the problem occurs with a clean build. On 2015-12-02 4:48 PM, JIGAR SHARDA wrote: Hi, I am trying to build servo on Fedora 22 32 bit and while doing that I am getting the

Re: [dev-servo] Planning to experiment with inline storage for DOMString / webidl binding codegen

2015-12-02 Thread Boris Zbarsky
On 12/2/15 4:23 PM, Andrew McCreight wrote: For what it is worth, Gecko uses a single-entry per-zone cache for converting the result of JS strings to DOM strings in getAttribute (I think) No, that's the other direction: DOM strings to JS strings. -Boris

Re: [dev-servo] Error in Building Servo on Fedora 22 32 bit

2015-12-02 Thread Lars Bergstrom
Yes, please do let us know if this issue happens on a clean build, too! Unfortunately, we don't test 32-bit linux builds in our continuous integration so it's possible that something broke it (though I'd have hoped that 32-bit Android linux would catch it!). - Lars On Wed, Dec 2, 2015 at 3:56 PM,

Re: [dev-servo] Error in Building Servo on Fedora 22 32 bit

2015-12-02 Thread Till Schneidereit
I tried building on 32-bit Linux a few months ago because I wanted to use rr (and wasn't aware of the by-then-mature 64-bit support). It didn't work and people recommended I just use 64-bit Linux instead. I don't remember if the error was similar, though. On Thu, Dec 3, 2015 at 1:04 AM, Lars Bergs