Re: [dev-servo] Draft blog post about memory measurement

2015-06-01 Thread Andrew McCreight
Very cool! This is probably too esoteric for the blog post, but it seems like the malloc_size_of thing isn't passed in for the Rust version. (For those who don't know, in Firefox, this is used for the Dark Matter Detector (DMD): a method can be passed in to record all blocks that are measured via

Re: [dev-servo] Draft blog post about memory measurement

2015-06-01 Thread Jack Moffitt
> I've written a draft of a blog post about memory profiling in Firefox > vs. Servo, which focuses on the Rust features that make the task more > pleasant in Servo. There's a draft copy here: > http://njn.valgrind.org/measuring.html Very nice! One question I still had at the end was whether thing

Re: [dev-servo] Draft blog post about memory measurement

2015-06-01 Thread Manish Goregaokar
The comment goes away in that PR :) As for Arc, I think the plan is to divide by the refcount; to get a "weight" sort of thing. Note that we only need to worry about shared references, not all non-owning references (borrows can be ignored) -Manish Goregaokar On Mon, Jun 1, 2015 at 9:29 PM, Jac

[dev-servo] PSA: Do not use the try feature on homu

2015-06-01 Thread Manish Goregaokar
... it sets things on fire. I think Rust has a slightly different setup for try which somehow works, but in our case @bors-servo: try on jgraham's PR queued nearly 200 PRs for trying. -Manish Goregaokar ___ dev

[dev-servo] Meeting notes 6/1 (Critic; SpiderMonkey upgrade; Rust upgrade; Devops; Reviewable perf; Interns)

2015-06-01 Thread Josh Matthews
https://github.com/servo/servo/wiki/Meeting-2015-06-01 Cheers, Josh ___ dev-servo mailing list dev-servo@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-servo

Re: [dev-servo] Meeting notes 6/1 (Critic; SpiderMonkey upgrade; Rust upgrade; Devops; Reviewable perf; Interns)

2015-06-01 Thread Lars Bergstrom
Related to reviewable, we have a few ongoing discussions with them on performance: General conversation on large reviews vs. Critic - https://github.com/Reviewable/Reviewable/issues/103 Letting individual commits hide other content might help - https://github.com/Reviewable/Reviewable/issues/104

Re: [dev-servo] Meeting notes 6/1 (Critic; SpiderMonkey upgrade; Rust upgrade; Devops; Reviewable perf; Interns)

2015-06-01 Thread Fabrice Desré
On 06/01/2015 02:47 PM, Lars Bergstrom wrote: > I think the big issue, as jgraham points out, is that Critic does the diffs > server-side, whereas Reviewable does diffs client-side. When these diffs are > large, you get the slow script dialog in FF (and pretty slow behavior in > Chrome, too). I

Re: [dev-servo] Draft blog post about memory measurement

2015-06-01 Thread Azita Rashed
Hi Nick, This is very nice. One small note in the beginning of your post, you called Servo an experimental browser engine. We should take out the word experimental and just call it a new or next generation browser engine. The project isn’t in the experimental phase anymore and we don’t want t

Re: [dev-servo] Draft blog post about memory measurement

2015-06-01 Thread Nicholas Nethercote
Thanks for the comments so far. I will address them in the final version. BTW, some eager beaver posted my link to Hacker News where it made the front page. I knew this post would be perfect linkbait for HN but this was a little premature. Whoops. Anyway, I edited to the page to remove all the Wo

Re: [dev-servo] Draft blog post about memory measurement

2015-06-01 Thread Nicholas Nethercote
On Mon, Jun 1, 2015 at 8:46 AM, Andrew McCreight wrote: > > This is probably too esoteric for the blog post, but it seems like the > malloc_size_of thing isn't passed in for the Rust version. (For those who > don't know, in Firefox, this is used for the Dark Matter Detector (DMD): a > method can b

Re: [dev-servo] Draft blog post about memory measurement

2015-06-01 Thread Nicholas Nethercote
On Mon, Jun 1, 2015 at 8:59 AM, Jack Moffitt wrote: > > One question I still had at the end was whether things like Arc > (non-owning references) are accounted for somewhere? If there's a clear owner, then it makes sense to measure the struct from there. Otherwise, we'll have to do some kind of "

Re: [dev-servo] Draft blog post about memory measurement

2015-06-01 Thread Nicholas Nethercote
On Mon, Jun 1, 2015 at 4:07 PM, Azita Rashed wrote: > This is very nice. One small note in the beginning of your post, you called > Servo an experimental browser engine. We should take out the word > experimental and just call it a new or next generation browser engine. The > project isn’t i