Re: [dev-servo] Abstract-dimension geometry for CSS Writing Modes

2014-05-27 Thread Patrick Walton
On 5/26/14 3:11 PM, Simon Sapin wrote: I’m fine with that, but I’m more interested in the signature than the naming. That is, which of these (or others) to have, for each private field? fn(&self) -> T fn(&mut self, T) fn(&'a mut self) -> &'a mut T Hmm. My gut tells me the first and the third.

Re: [dev-servo] Abstract-dimension geometry for CSS Writing Modes

2014-05-27 Thread Simon Sapin
On 27/05/2014 18:14, Patrick Walton wrote: On 5/26/14 3:11 PM, Simon Sapin wrote: I’m fine with that, but I’m more interested in the signature than the naming. That is, which of these (or others) to have, for each private field? fn(&self) -> T fn(&mut self, T) fn(&'a mut self) -> &'a mut T Hm

Re: [dev-servo] Abstract-dimension geometry for CSS Writing Modes

2014-05-27 Thread Patrick Walton
On 5/27/14 11:04 AM, Simon Sapin wrote: On 27/05/2014 18:14, Patrick Walton wrote: On 5/26/14 3:11 PM, Simon Sapin wrote: I’m fine with that, but I’m more interested in the signature than the naming. That is, which of these (or others) to have, for each private field? fn(&self) -> T fn(&mut se