[dev-servo] Abstract-dimension geometry for CSS Writing Modes

2014-05-26 Thread Simon Sapin
In preparation for CSS Writing Modes and porting all of our layout code, I started adding geometry primitives in abstract dimensions. Permanent link as of this writing: https://github.com/SimonSapin/servo/compare/d6caf26 Link tracking the branch: https://github.com/SimonSapin/servo/compare/abst

Re: [dev-servo] Abstract-dimension geometry for CSS Writing Modes

2014-05-26 Thread Patrick Walton
On 5/26/14 2:44 PM, Simon Sapin wrote: Unlike C++, Rust does not have method overloading so the accessors are much more verbose. `nscoord ISize(WritingMode aWritingMode) const` overloaded with `nscoord& ISize(WritingMode aWritingMode)` becomes `get_i_size(&self, mode: WritingMode) -> T` and `set_

Re: [dev-servo] Abstract-dimension geometry for CSS Writing Modes

2014-05-26 Thread Patrick Walton
On 5/26/14 2:52 PM, Patrick Walton wrote: (In general, I find that single-letter abbreviations read better when squished up next to the word they go with, without underscores. Just personal preference, I guess.) Compare e.g. "xrange" in Python versus a hypothetical "x_range". I think "xrange"

Re: [dev-servo] Abstract-dimension geometry for CSS Writing Modes

2014-05-26 Thread Simon Sapin
On 26/05/2014 22:52, Patrick Walton wrote: On 5/26/14 2:44 PM, Simon Sapin wrote: Unlike C++, Rust does not have method overloading so the accessors are much more verbose. `nscoord ISize(WritingMode aWritingMode) const` overloaded with `nscoord& ISize(WritingMode aWritingMode)` becomes `get_i_si