Re: [dev-servo] Query on properties.mako.rs for CSSparser

2015-11-05 Thread Josh Matthews
Sorry, my fault for using links that only reference master, not a stable revision. I meant that you should add a new argument to the get_specified macro arguments. Cheers, Josh On 2015-11-05 1:28 PM, Pranesha Shashwath Kumar Kattepura Jayabheema Rao wrote: Hi Josh, The content in the 65

Re: [dev-servo] Query on properties.mako.rs for CSSparser

2015-11-05 Thread Pranesha Shashwath Kumar Kattepura Jayabheema Rao
Hi Josh, The content in the 6506 in the link you shared in your previous mail i.e., http://mxr.mozilla.org/servo/source/components/style/properties.mako. rs#6506 , and the content in line 6506 in properties.mako.rs in GutHub are different. Did you mean to ask me to add the argument -- `$error_r

Re: [dev-servo] Query on properties.mako.rs for CSSparser

2015-10-31 Thread Simon Sapin
On 31/10/15 03:00, Pranesha Shashwath Kumar Kattepura Jayabheema Rao wrote: Hi, We are getting an error "This function takes 4 parameters but 3 were supplied" for all the instances of the function get_specified!. Adding to what Josh said: get_specified! is not a function, it’s a macro. (Th

Re: [dev-servo] Query on properties.mako.rs for CSSparser

2015-10-31 Thread Josh Matthews
In answer to your question, the change that is causing all of these errors is https://github.com/GauriGNaik/servo/commit/c8b79b964d9f5225196a307102442abf3352c43b#diff-1816aa410246f8915a124610d4e5bc3cR5620 .. You need to modify http://mxr.mozilla.org/servo/source/components/style/properties.ma

Re: [dev-servo] Query on properties.mako.rs for CSSparser

2015-10-31 Thread Pranesha Shashwath Kumar Kattepura Jayabheema Rao
Thanks for the info. The small change we made to struct ParserContext in parser.rs seems to have lots of dependencies. This seems to be a scenario of metaprogramming where a new function is being created at run-time. Could you please help us understand if changing this function to accept 4 values w

Re: [dev-servo] Query on properties.mako.rs for CSSparser

2015-10-30 Thread Josh Matthews
This is a tricky one. I suspect if we look closely at the error messages, they would actually be pointing at a line _inside_ of the `get_specified` macro, rather than directly at users of the macro. Specifically, `get_specified!(get_box, display, value)` ends up expanding as something like this