Re: [dev-servo] Pull request template

2016-05-07 Thread Manish Goregaokar
If this is required for all PRs it could break the workflow of those who use `hub` to make PRs from the command line, but I'm sure that can be hacked around. Otherwise, +1 for the idea overall. Might want to explicitly mention "(for DOM, CSS, or layout changes)" for the third entry. It might a

Re: [dev-servo] Pull request template

2016-05-06 Thread Jack Moffitt
I'm willing to give it a try. I'd suggest shortening up the text of the third one, and for the fourth one, add a "because:" so that they have to justify their lack of tests. jack. On Fri, May 6, 2016 at 9:13 AM, Josh Matthews wrote: > Github introduced templates for issues and pull requests a co