Re: [dev-servo] NCSU Student Project: Implement HTML5 form validation

2016-03-22 Thread Ravi Ashok Kumar Patel
looping Arpit On Mon, Mar 21, 2016 at 9:37 PM, Keith Yeung wrote: > Hi Arpit, > > Just as a quick reminder, it's often a good idea to create a new feature > branch when trying to make a PR. You'll inadvertently need to rebase > against the changes in upstream master, so making a feature branch w

Re: [dev-servo] NCSU Student Project: Implement HTML5 form validation

2016-03-22 Thread Arpit Tyagi
Hi Keith, Thanks for your valuable suggestion. However this time I created a new feature branch in my repository and merged this branch with master only after rebasing my master with upstream master. Cheers!! Arpit On Mon, Mar 21, 2016 at 10:37 PM, Ravi Ashok Kumar Patel wrote: > looping Arpit

Re: [dev-servo] NCSU Student Project: Implement HTML5 form validation

2016-03-21 Thread Keith Yeung
Hi Arpit, Just as a quick reminder, it's often a good idea to create a new feature branch when trying to make a PR. You'll inadvertently need to rebase against the changes in upstream master, so making a feature branch will prevent weird issues from happening whilst you're rebasing. Regards, Keit

Re: [dev-servo] NCSU Student Project: Implement HTML5 form validation

2016-03-21 Thread Arpit Tyagi
Hi Josh, I believe, we have completed the coding for the initial steps, however I am not sure how can I test these changes. Could you please advise how can I test these changes. I will also appreciate if you could have a quick look on code changes in git (https://github.com/tyagiarpit/servo). Ch

Re: [dev-servo] NCSU Student Project: Implement HTML5 form validation

2016-03-20 Thread Josh Matthews
Welcome! Please ask questions here or on IRC if anything about the project is unclear :) Cheers, Josh On 2016-03-19 5:39 PM, Ravi Ashok Kumar Patel wrote: Hi, This is regarding the Student Project we are working on as part of our curriculum at NC State University. Me and my team are work