Re: [dev-servo] Minutes of the discussion regarding strings

2013-06-08 Thread Boris Zbarsky
On 6/8/13 9:19 PM, Boris Zbarsky wrote: There are, of course, some drawbacks. One more drawback, actually: in the model I described the immutable string assumes a flat buffer. So if you have a rope-based mutable thing, passing it somewhere means you have to flatten first. In practice, for

Re: [dev-servo] Minutes of the discussion regarding strings

2013-06-08 Thread Boris Zbarsky
On 6/7/13 9:43 AM, Benjamin Smedberg wrote: On 6/5/2013 8:42 PM, Patrick Walton wrote: * Gecko has mutable strings and this is bad for performance I'd like to understand/challenge this statement. Is this bad for performance because you have to check the extra SHARED flag on write? So I tho

Re: [dev-servo] Minutes of the discussion regarding strings

2013-06-07 Thread Nicholas Nethercote
On Thu, Jun 6, 2013 at 11:09 AM, Robert O'Callahan wrote: > Immutable strings sound good to me. > > How hard would it be to add UTF-8 strings to Spidermonkey? JSString already > has a lot of "modes", perhaps one more wouldn't hurt :-). I'm imagining > that for anything that required UTF-16 (charAt

Re: [dev-servo] Minutes of the discussion regarding strings

2013-06-07 Thread Benjamin Smedberg
On 6/7/2013 11:27 AM, Boris Zbarsky wrote: My context here is things like the code I changed in http://hg.mozilla.org/mozilla-central/rev/e5cc69819435 which was in theory trying to follow best practices (calling SetCapacity, etc). But then it also did appends one character at a time and each

Re: [dev-servo] Minutes of the discussion regarding strings

2013-06-07 Thread Benjamin Smedberg
On 6/7/2013 10:03 AM, Patrick Walton wrote: Was there discussion about whether string buffers should be refcounted or GCed (or copied, but I'm pretty sure that would cause memory explosion)? Ref counting versus GC is determined on a case-by-case basis in Servo. There's no one-size-fits-al

Re: [dev-servo] Minutes of the discussion regarding strings

2013-06-07 Thread Boris Zbarsky
On 6/7/13 9:43 AM, Benjamin Smedberg wrote: I would love to have been invited to this meeting. Was it announced anywhere? It sort of grew out of an IRC conversation over the course of 20 mins or so. :( * Gecko has mutable strings and this is bad for performance I'd like to understand/c

Re: [dev-servo] Minutes of the discussion regarding strings

2013-06-07 Thread Patrick Walton
On 6/7/13 6:43 AM, Benjamin Smedberg wrote: On 6/5/2013 8:42 PM, Patrick Walton wrote: Topics covered: Interning, mutability, cost of creating string objects, encoding UTF-8 versus UTF-16. https://github.com/mozilla/servo/wiki/Strings I would love to have been invited to this meeting. Was it a

Re: [dev-servo] Minutes of the discussion regarding strings

2013-06-07 Thread Benjamin Smedberg
On 6/5/2013 8:42 PM, Patrick Walton wrote: Topics covered: Interning, mutability, cost of creating string objects, encoding UTF-8 versus UTF-16. https://github.com/mozilla/servo/wiki/Strings I would love to have been invited to this meeting. Was it announced anywhere? I absolutely agree that

Re: [dev-servo] Minutes of the discussion regarding strings

2013-06-05 Thread Robert O'Callahan
Immutable strings sound good to me. How hard would it be to add UTF-8 strings to Spidermonkey? JSString already has a lot of "modes", perhaps one more wouldn't hurt :-). I'm imagining that for anything that required UTF-16 (charAt etc) you'd convert the string internals to UTF-16, and for passing