Re: [dev-servo] Creating a JSObject -> id map for the Debugger IPC server.

2016-12-13 Thread Jim Blandy
Those would serve, certainly. But won't they vary from run to run for reasons outside our control? I'd be a little more comfortable keeping the id's deterministic, if it's not a big deal. On Tue, Dec 13, 2016 at 8:58 AM, Nick Fitzgerald wrote: > We already have IDs for GC things that are stabl

Re: [dev-servo] Creating a JSObject -> id map for the Debugger IPC server.

2016-12-13 Thread Nick Fitzgerald
We already have IDs for GC things that are stable across moving GCs, but I'm not 100% sure they are exposed in JSAPI. Aha, looks like it is exposed: http://searchfox.org/mozilla-central/rev/594937fec2e2fc45fa9308ba2fb964816631f017/js/public/RootingAPI.h#660 On Mon, Dec 12, 2016 at 9:10 PM, Jim Bl

Re: [dev-servo] Creating a JSObject -> id map for the Debugger IPC server.

2016-12-12 Thread Jim Blandy
Honestly, I've never liked the devtools server's practice of using weakmaps for every little thing. They're expensive, and the Debugger itself is already using weakmaps internally for the association from real debuggee things to their Debugger shadows, and guarantees distinct shadows for each (debu