Re: [dev-servo] CSC 517 OSS Project

gstwebrtc is present. And I installed version 1.14.4 On Thu, Mar 28, 2019, 5:54 PM Josh Bowman-Matthews Is gstwebrtc-1.0.lib present in C:\gstreamer\1.0\x86_64\lib? If not, > your gstreamer installation is incorrect somehow. What version of > gstreamer did you install? > > cheers, > Josh > > On 3

Re: [dev-servo] CSC 517 OSS Project

Is gstwebrtc-1.0.lib present in C:\gstreamer\1.0\x86_64\lib? If not, your gstreamer installation is incorrect somehow. What version of gstreamer did you install? cheers, Josh On 3/28/19 1:00 PM, Niveditha Shankar wrote: Hello Josh I added the path to LIB variable and checked if the changes we

Re: [dev-servo] CSC 517 OSS Project

Hello Josh I added the path to LIB variable and checked if the changes were reflected. But I am still getting the same link error. https://gist.github.com/NivedithaShankar/47f6f06bcf788e11ba291c563685386a On Thu, Mar 28, 2019 at 9:38 AM Josh Bowman-Matthews wrote: > That looks like you need t

Re: [dev-servo] CSC 517 OSS Project

That looks like you need to set the LIB variable per the instructions in https://github.com/servo/servo/blob/master/README.md#on-windows-msvc . You can check whether that value is visible in your terminal with `echo %LIB%`; if it's not, try changing the environment variable and reopening the te

Re: [dev-servo] CSC 517 OSS Project

https://gist.github.com/NivedithaShankar/6850daeb74eede93e560f20bf3566573 On Thu, Mar 28, 2019 at 1:25 AM Josh Bowman-Matthews wrote: > The log file is missing. I recommend pasting the log in a gist > (https://gist.github.com/) and sending the resulting link. > > Cheers, > Josh > > On 3/27/19 9:

Re: [dev-servo] CSC 517 OSS Project

The log file is missing. I recommend pasting the log in a gist (https://gist.github.com/) and sending the resulting link. Cheers, Josh On 3/27/19 9:50 PM, Niveditha Shankar wrote: Hi I dont face that issue anymore. I deleted the servo repo and cloned it again and tried again. Now I face 'erro

Re: [dev-servo] CSC 517 OSS Project

Hi I dont face that issue anymore. I deleted the servo repo and cloned it again and tried again. Now I face 'error: linking with `link.exe` failed: exit code: 1181' error. I have attached the log file below Niveditha Shankar On Tue, Mar 26, 2019 at 12:48 PM Josh Bowman-Matthews wrote: > I hav

Re: [dev-servo] CSC 517 OSS Project

I have never seen this before. Does it persist if you restart the terminal, or even the operating system? Cheers, Josh On 3/25/19 8:53 PM, Niveditha Shankar wrote: I cant check if it works because of the previous issue I mentioned -- And now it just comes out of the build without displaying a

Re: [dev-servo] CSC 517 OSS Project

I cant check if it works because of the previous issue I mentioned -- And now it just comes out of the build without displaying any success/error message(doesnt run anything either) Like this: C:\Users\ndniv\rust>cd servo C:\Users\ndniv\rust\servo>mach.bat build --dev C:\Users\ndniv\rust\servo>

Re: [dev-servo] CSC 517 OSS Project

And now it just comes out of the build without displaying any success/error message(doesnt run anything either) On Mon, Mar 25, 2019 at 8:23 PM Niveditha Shankar wrote: > Hi > I tried to build the project in windows and got the following error > `link.exe` failed: exit code: 1181 ' > > I have at

Re: [dev-servo] CSC 517 OSS Project

Hi Niveditha, cc Josh I didn't see the attached log but I tried to search "exit code 1181" in Servo. Not sure if this issue is related, if yes, you might be able to refer to the last comment from learning

Re: [dev-servo] CSC 517 OSS Project

Hi I tried to build the project in windows and got the following error `link.exe` failed: exit code: 1181 ' I have attached the log file below Niveditha Shankar On Mon, Mar 25, 2019 at 1:31 PM Josh Bowman-Matthews wrote: > On 3/25/19 12:49 PM, Niveditha Shankar wrote: > > Thanks for that. The

Re: [dev-servo] CSC 517 OSS Project

On 3/25/19 12:49 PM, Niveditha Shankar wrote: Thanks for that. The build was successful! On running the test specified, we got this "ran 213 tests as expected". So am I right in assuming that the modifications we make to the servo code are correct if these tests run as expected? Correct. And

Re: [dev-servo] CSC 517 OSS Project

Thanks for that. The build was successful! On running the test specified, we got this "ran 213 tests as expected". So am I right in assuming that the modifications we make to the servo code are correct if these tests run as expected? And also we are asked to create a new adapter.rs file. I notice

Re: [dev-servo] CSC 517 OSS Project

If you are building on macOS, then you are probably hitting the problem described in https://github.com/servo/servo/issues/21792. The solution is to install the XCode 10.2 beta (https://github.com/servo/servo/issues/21792#issuecomment-459590626). Cheers, Josh On 3/23/19 10:47 PM, Niveditha Sh

Re: [dev-servo] CSC 517 OSS Project

Thank you for reply! We wanted to check the output using the command you suggested. We were unable to do so as we could not build the project(main servo repo). We followed all the steps mentioned in the read me file. We tried multiple times in Mac. But the build never got completed. It got stuck an

Re: [dev-servo] CSC 517 OSS Project

These are all good questions! You are correct about the reference to the code that you will be modifying. Servo imports the types from the devices crate in this code: https://github.com/servo/servo/blob/059ac12c00c4cfac4133b23fc3d81e71b90eb8e2/components/bluetooth/lib.rs#L19-L20 .. That means t

Re: [dev-servo] CSC 517 OSS Project

I have a few more doubts regarding the output: 1) What is the existing output for the code we have to work on? 2) Which file should we execute to obtain the same? As we are doing only refactoring, I am guessing there would not be any change in the output. Wanted to know against what we should che

Re: [dev-servo] CSC 517 OSS Project

Hello Just wanted to make sure that we are working with the correct part of the code, To convert the BluetoothAdapter from enum to trait, are we right in assuming that we will be working with the following, Line 93-106 in https://github.com/servo/devices/blob/master/src/bluetooth.rs. Could you br

Re: [dev-servo] CSC 517 OSS Project

Welcome! One nice property about this project is that it's more or less standalone, so there isn't much preparation necessary beyond understanding the Rust language concepts that you will be relying upon. Cheers, Josh On 3/7/19 8:41 PM, Niveditha Shankar wrote: Hello, I am Niveditha Shankar