Re: [dev-servo] Turning flexbox on by default

2016-10-04 Thread Patrick Walton
Thanks everyone! Based on the feedback, I've submitted a PR to do this: https://github.com/servo/servo/pull/13590 Feel free to leave comments on it. Patrick On Thu, Sep 29, 2016 at 6:26 PM, Patrick Walton wrote: > Hi, > > Given stshine's fantastic work implementing flexbox, I'm wondering wheth

Re: [dev-servo] Turning flexbox on by default

2016-09-29 Thread Josh Matthews
I agree, it's significantly improved since the initial implementation work. I think it's worth giving it wider exposure. On 2016-09-29 9:26 PM, Patrick Walton wrote: Hi, Given stshine's fantastic work implementing flexbox, I'm wondering whether it's worth turning it on by default now. At the v

Re: [dev-servo] Turning flexbox on by default

2016-09-29 Thread Emilio Cobos Álvarez
This sounds pretty good to me. I agree there was a reason at the moment where it made sense, since we didn't even support the most basic use cases (only the parsing bits were there IIRC). But now I guess it makes sense to un-mark as experimental all the flexbox properties we actually use in layou

[dev-servo] Turning flexbox on by default

2016-09-29 Thread Patrick Walton
Hi, Given stshine's fantastic work implementing flexbox, I'm wondering whether it's worth turning it on by default now. At the very least, I think turning it on should be easier than flipping nearly a dozen preferences. :) Flexbox is getting pretty important in rendering the Web (see [1] for an e