Re: [dev-servo] Regarding missing DOM features project: Named getter implementation

2019-12-02 Thread Josh Bowman-Matthews
1. Using the struct/enum combo that I suggested in the previous email, you would only need a vector of SourcedName, since the element is included in the struct. You are correct that this corresponds with the description of the specification for `sourced names`. 2. That code snippet looks like

Re: [dev-servo] Regarding missing DOM features project: Named getter implementation

2019-12-01 Thread Chintan Gandhi
Hi Josh, Sorry to bother you on a Sunday. We have added the enum and struct modifications as mentioned above. Listed below are some issues which we are unclear about: *1.* As mentioned on the project page, we need to create a *vector* *(SourcedName, DomRoot)* by iterating over *self.controls* me

Re: [dev-servo] Regarding missing DOM features project: Named getter implementation

2019-11-28 Thread Josh Bowman-Matthews
Great question! I recommend representing it like: enum SourcedNameSource { Id, Name, Past(Duration) } struct SourcedName { name: String, element: DomRoot, source: SourcedNameSource, } This will allow you to access the values that are always present as named fields of th

[dev-servo] Regarding missing DOM features project: Named getter implementation

2019-11-27 Thread Chintan Gandhi
Hi Josh, Greetings! We are currently working on the named getter implementation by following the spec and the steps you listed on the project page: https://github.com/servo/servo/wiki/Missing-DOM-features-project. There a couple of questions related to the SupportedPropertyNames method implement