Re: [dev-servo] Heads-up for a subtle breaking change in Rust

2014-08-27 Thread Simon Sapin
On 27/08/14 07:23, Tetsuharu OHZEKI wrote: I feel the change would also affect these points: https://github.com/servo/servo/blob/master/src/components/layout/flow.rs#L277 https://github.com/servo/servo/blob/master/src/components/layout/flow.rs#L290 2014-08-27 7:17 GMT+09:00 Jack Moffitt: There

Re: [dev-servo] Heads-up for a subtle breaking change in Rust

2014-08-26 Thread Tetsuharu OHZEKI
I feel the change would also affect these points: https://github.com/servo/servo/blob/master/src/components/layout/flow.rs#L277 https://github.com/servo/servo/blob/master/src/components/layout/flow.rs#L290 2014-08-27 7:17 GMT+09:00 Jack Moffitt : > There are at least two cases of this, both curre

Re: [dev-servo] Heads-up for a subtle breaking change in Rust

2014-08-26 Thread Jack Moffitt
There are at least two cases of this, both currently annotated with FIXME: https://github.com/servo/servo/search?utf8=%E2%9C%93&q=TraitObject Thanks for the heads up! jack. On Tue, Aug 26, 2014 at 4:14 PM, Nick Cameron wrote: > For the next Rust upgrade you should be aware of a subtle breaking

[dev-servo] Heads-up for a subtle breaking change in Rust

2014-08-26 Thread Nick Cameron
For the next Rust upgrade you should be aware of a subtle breaking change - the compiler's internal representation of trait objects has changed. Previously trait objects were represented as a pair of pointer-to-vtable, pointer-to-data. That order has been reveresed to pointer-to-data, pointer-to-vt